Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp4700102rwl; Sun, 8 Jan 2023 01:22:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXu9tjwj0TVyFq18FK8Prf/c/ZWQyCfBEfXJAfnzMHHFRQMHYcvyyUZewO8KcVC7q27haqEg X-Received: by 2002:a17:907:d48e:b0:7ae:b2e4:7b3f with SMTP id vj14-20020a170907d48e00b007aeb2e47b3fmr56739880ejc.8.1673169746093; Sun, 08 Jan 2023 01:22:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673169746; cv=none; d=google.com; s=arc-20160816; b=J7vcYqqmmxBO2Pq5Pv9RLZztmA3/wMMZPkGzMtx3rnggBVPIoRP1YLBGIIjCBolTHp DNByFlv/fYtEuaRQRnUDuF9+538k2Qg8hfQdBW/AkSBQ4+5rFgvG7ChrlJjUARD3yHh1 KL6laqKfCGReAOM65BoepCIbuJ6xfydM69zFgbHeyj7NycJ/GZg1oOAjInyJ2YNoEd2+ 0ZJ2UiG8aK10/vble6jtyDcFIdfJYBaIHzlrk8vKEYpO32FeDMV+MUpYEC7LvlOOMcFo MlL1QiGZE6nVTYWjzyOZjA+OodEvVJEJ6GUBZt/MkIVJri4Cs8jf/9wUbzIcisUNkv1X UxDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:references:in-reply-to:user-agent:subject:cc:to:from :date; bh=/z/xwcU0kIt23xa10NHSCsThIOdme3qV+LD35OJJj18=; b=biQg33uezhhlyTkJk9alzdQVLg1ik7ihe/EC4GYwBT1jngc4MOmzSWmE2cluHZjf+u 9hVzhKxowj1FaiJz2U9kiXy0NT2Hn7I1FjFnKcIV460XyZcLMfNn5VvBrFcbhRM9EF7U MNExyj6ziMsNicEuAKFpMi/y/C30iTSU6fAmvtgcXqIDKg2HVVqNt5d/RMVamBRWfY0n qBO3UI1CzybDt+PWg70Am3xb7V/pddCK+7zVMdtjBmRlBGB2MqwwQMoSWUVPxRm+m+d8 Yhr+DW9VUuQxTu2mDaYehxLcClF0/troEkZfHjNTHY2rAIIkqqQ7y1c0SCwRCyAIjgHA cfPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wz11-20020a170906fe4b00b007c0a96378easi7316314ejb.704.2023.01.08.01.22.12; Sun, 08 Jan 2023 01:22:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbjAHJES convert rfc822-to-8bit (ORCPT + 53 others); Sun, 8 Jan 2023 04:04:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230165AbjAHJEP (ORCPT ); Sun, 8 Jan 2023 04:04:15 -0500 X-Greylist: delayed 4603 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 08 Jan 2023 01:04:14 PST Received: from 15.mo561.mail-out.ovh.net (15.mo561.mail-out.ovh.net [87.98.150.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 301E6DF3C for ; Sun, 8 Jan 2023 01:04:13 -0800 (PST) Received: from director3.ghost.mail-out.ovh.net (unknown [10.108.16.8]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 464B923733 for ; Sun, 8 Jan 2023 07:45:54 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-dlrtv (unknown [10.109.156.99]) by director3.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 9B5F31FEF4; Sun, 8 Jan 2023 07:45:49 +0000 (UTC) Received: from sk2.org ([37.59.142.106]) by ghost-submission-6684bf9d7b-dlrtv with ESMTPSA id XCz1Hq10umNDGgAAuoryaQ (envelope-from ); Sun, 08 Jan 2023 07:45:49 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-106R0063ead8ad9-a798-4b11-941a-dcd5f5867b68, 5128B599F7D401446F64D4771BE19AB2B9CD7A8B) smtp.auth=steve@sk2.org X-OVh-ClientIp: 37.167.47.239 Date: Sun, 08 Jan 2023 08:45:46 +0100 From: Stephen Kitt To: Sam Ravnborg CC: Sam Ravnborg via B4 Submission Endpoint , Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Ludovic Desroches Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_01/15=5D_video=3A_fbdev=3A_atm?= =?US-ASCII?Q?el=5Flcdfb=3A_Rework_backlight_handling?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-1-1bd9bafb351f@ravnborg.org> <553AE999-CAF1-4E59-9F3F-68591ED192DE@sk2.org> Message-ID: <366FC0B8-21E2-4642-A5A5-CF4B6AB046B0@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Ovh-Tracer-Id: 8408783456216778374 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrkeefgdduuddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevufgfjghfkfggtgfgsehtqhhmtddtreejnecuhfhrohhmpefuthgvphhhvghnucfmihhtthcuoehsthgvvhgvsehskhdvrdhorhhgqeenucggtffrrghtthgvrhhnpeevieelieekfeelhfduffdvgfduvdegkeeljeejhfdtkeeujeeileekgeeugefhhfenucffohhmrghinheplhhkmhhlrdhorhhgpdhkvghrnhgvlhdrohhrghenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehsthgvvhgvsehskhdvrdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheeiuddpmhhouggvpehsmhhtphhouhht X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7 January 2023 21:53:46 CET, Sam Ravnborg wrote: >Hi Stephen. > >On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: >> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint wrote: >> >From: Sam Ravnborg >> > >> >The atmel_lcdfb had code to save/restore power state. >> >This is not needed so drop it. >> > >> >Introduce backlight_is_brightness() to make logic simpler. >> > >> >Signed-off-by: Sam Ravnborg >> >Cc: Nicolas Ferre >> >Cc: Alexandre Belloni >> >Cc: Ludovic Desroches >> >Cc: linux-fbdev@vger.kernel.org >> >Cc: linux-arm-kernel@lists.infradead.org >> >--- >> > drivers/video/fbdev/atmel_lcdfb.c | 24 +++--------------------- >> > 1 file changed, 3 insertions(+), 21 deletions(-) >... >> >> Hi Sam, >> >> I’d submitted quite a few more of these previously (and you’d reviewed them), see e.g. the thread starting at https://lkml.org/lkml/2022/6/7/4365, and yesterday, https://lkml.org/lkml/2023/1/6/520, https://lkml.org/lkml/2023/1/6/656, https://lkml.org/lkml/2023/1/6/970, https://lkml.org/lkml/2023/1/6/643, and https://lkml.org/lkml/2023/1/6/680. There are a few more, I can find them if it’s any use. > >The patches from yesterday was what triggered me to resurrect an old >branch of mine where I had done something similar. I had lost all >memory of reviewing similar patches from you. > > >Helge - could you pick the reviewed patches from: >https://lore.kernel.org/all/20220607192335.1137249-1-steve@sk2.org/ >[This is the same mail as Stephen refer to above - looked up via lore]. > >Stephen - I expect Daniel/Lee to take care of the patches from yesterday. >If you can look up other pending patches from you please do so, so we >can have them applied. >Preferably with links to lore - as this makes it easier to apply them. > >Review of what is unique in this set would be appreciated. > > Sam Hi Sam, Here are my pending patches from last June on lore: * https://lore.kernel.org/lkml/20220607190925.1134737-1-steve@sk2.org/ * https://lore.kernel.org/lkml/20220608205623.2106113-1-steve@sk2.org/ * https://lore.kernel.org/lkml/20220607192335.1137249-1-steve@sk2.org/ * https://lore.kernel.org/lkml/20220616170425.1346081-1-steve@sk2.org/ I’ll send reviews of your other patches later today or tomorrow. Regards, Stephen