Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp4719974rwl; Sun, 8 Jan 2023 01:51:38 -0800 (PST) X-Google-Smtp-Source: AMrXdXv7Xc/xn32a+0hb92WouE6TbLRYwmJGNNjcvwNgfYQv4GA3eL0KJtJTbspeP+2BWMQN5s1y X-Received: by 2002:a17:903:2c2:b0:189:c8d9:ed30 with SMTP id s2-20020a17090302c200b00189c8d9ed30mr58032792plk.24.1673171498058; Sun, 08 Jan 2023 01:51:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673171498; cv=none; d=google.com; s=arc-20160816; b=HK4fvrHC6iVBjDfbWxrp6FCxqcvHgDudoUrOK60y7vVN16hGlsMgFVtvvPYfGu/QDu PiLbBFh4TZP5jJW8dZLZuiOrWQvr8QyLyW/oX+zsVkWmqasLMDaLunzXScLTx8yfd3Y7 XdFSxlBHiX50QL4oN9RKmjRCd27xDJHjpK4cZeqRbLEd++5gtpCYeNVvaRlSKI9Gm32i Ubrl94NOEx8nbzCwAq8E05Si2CZ3i/IS6Ij3EUqDx9nmM+xUgrROdBMTKCNuA8G7QfqT b4CXwTjpAIfEVF1XDzFHc+sEgeO/05sZndPmYt5a16FBnO1FWGSr0AHcyxVqdexL0tj4 FYfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=Oybl0kFzJk1OHKBfarCPAX+ldUYM8qIDtwFbpLc8Wqg=; b=LchixAUBi7opZOgov5AMvzfhQpw5oHBeFMHowbOn/GcSSN47LT2aZoHEhX6/l7jK7I RHQzNjoEsuQ/1W0HBJrap+a2cBuEqJ1FFziwi9M/SuiNloXJwhPfCYp10G9/+tDy1yIk +sdUaMh6crzNUQecjyhSO/GkU9GsLlWe6raMXtpG3vFSs//L1AjuM7QeyBIyBh6HUMp+ 34BIi7N3pq6DEU89uCQFm3HpWrSxMflbmKhj4KUHGax/xxiEoBML279aELpY3k+hSVve Gq2y8jNEWmBh2VfImBBxYjmkk7f0LjcSBFSJjqAEr3AhCEEHlQejc6YH0OKJt6gnLsUP CUFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa2 header.b=OMBp7D4Q; dkim=neutral (no key) header.i=@ravnborg.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d11-20020a170902f14b00b00192cf9b7020si5729699plb.182.2023.01.08.01.51.29; Sun, 08 Jan 2023 01:51:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa2 header.b=OMBp7D4Q; dkim=neutral (no key) header.i=@ravnborg.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230205AbjAHJ3j (ORCPT + 55 others); Sun, 8 Jan 2023 04:29:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbjAHJ3g (ORCPT ); Sun, 8 Jan 2023 04:29:36 -0500 Received: from mailrelay5-1.pub.mailoutpod2-cph3.one.com (mailrelay5-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:404::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4FC010B6D for ; Sun, 8 Jan 2023 01:29:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=Oybl0kFzJk1OHKBfarCPAX+ldUYM8qIDtwFbpLc8Wqg=; b=OMBp7D4Q1taCLAC26KHZDvW1MnN8LDDXjmMIinVqeHcS40c2e/r5bEtpEA1YOrQKsE8uJwyy+dzX1 4JKIKJwtxexTCDBai/T/gN1pQFF6GZA/r8/jGnp3ACvSRRpcV8FriJldv+JY/8nNw3PBeN3zBHgAQS gqwLkZC+F6kFgl05fAfdYG8tRkpCGkZwSL5dkqVYiQSgQQ/aMCdQHrSn/VegiB4aoijKO5TFJ9bump HWqdwba3Kn4ZlYTE9d0fRPV50RONoQmTzzLdRTRPjJ82VVzJsAfRc4taGrrIqPH/zeF2yTJogJvsBY Akt7pBD48e76OSMuArRnMD0vHtnM3jw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=Oybl0kFzJk1OHKBfarCPAX+ldUYM8qIDtwFbpLc8Wqg=; b=1bH+enBd3Rzx4lTdU2Ew/3w4RNpW2B4i5DDhzGEZCxhwTP59EcA+tuKMI2XuhVP+RWekbgj/wgKSQ SVYt0YTBw== X-HalOne-ID: f2a3e065-8f36-11ed-9179-7703b0afff57 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay5 (Halon) with ESMTPSA id f2a3e065-8f36-11ed-9179-7703b0afff57; Sun, 08 Jan 2023 09:29:30 +0000 (UTC) Date: Sun, 8 Jan 2023 10:29:29 +0100 From: Sam Ravnborg To: Miguel Ojeda , Robin van der Gracht Cc: Stephen Kitt , Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Geert Uytterhoeven Subject: Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness() Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-12-1bd9bafb351f@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin. On Sat, Jan 07, 2023 at 10:02:38PM +0100, Miguel Ojeda wrote: > On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint > wrote: > > > > Introduce backlight_get_brightness() to simplify logic > > and avoid direct access to backlight properties. > > Note: Stephen sent this one too a while ago (with some more details in > the commit message, which is always nice); and then he sent yesterday > v2 [1] (to mention the functional change with `BL_CORE_SUSPENDED` > [2]). Thanks for the pointers. I will try to move forward with Stephen's patches. > > Anyway, if it goes via drm-misc, feel free to have my: > > Acked-by: Miguel Ojeda > > Though it would be nice to have Robin test the change. Robin - can I get your ack to apply Stephen's original v2 patch to drm-misc? Sam > > Thanks! > > [1] https://lore.kernel.org/lkml/20230106143002.1434266-1-steve@sk2.org/ > [2] https://lore.kernel.org/lkml/CANiq72kRhmT37H1FAGYGny83ONYXeqJuO8ZPbym0ajQOWKY4Kw@mail.gmail.com/ > > Cheers, > Miguel