Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730
Mime-Version: 1.0
Message-Id: <2d085660-41a2-492c-a343-7df80d510a59@app.fastmail.com>
In-Reply-To: <m2sfglh02h.fsf@free.fr>
References: <20230105134622.254560-1-arnd@kernel.org>
 <20230105134622.254560-5-arnd@kernel.org> <m2sfglh02h.fsf@free.fr>
Date:   Sun, 08 Jan 2023 14:40:47 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Robert Jarzmik" <robert.jarzmik@free.fr>,
        "Arnd Bergmann" <arnd@kernel.org>
Cc:     "Daniel Mack" <daniel@zonque.org>,
        "Haojian Zhuang" <haojian.zhuang@gmail.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        "Michael Turquette" <mturquette@baylibre.com>,
        "Stephen Boyd" <sboyd@kernel.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        "Viresh Kumar" <viresh.kumar@linaro.org>,
        "Ulf Hansson" <ulf.hansson@linaro.org>,
        "Dominik Brodowski" <linux@dominikbrodowski.net>,
        linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
        "linux-mmc @ vger . kernel . org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 04/27] ARM: pxa: drop pxa310/pxa320/pxa93x support
Content-Type: text/plain
Precedence: bulk

On Sun, Jan 8, 2023, at 09:49, Robert Jarzmik wrote:
> Arnd Bergmann <arnd@kernel.org> writes:
>> There is currently no devicetree support for any of these three
>> SoCs, and no board files remain. As it seems unlikely that 
>> anyone is going to add DT support soon, let's drop the SoC specific 
>> code now.
>
> Hi Arnd,
>
> Here you're dropping pxa variant support. For the currently 
> "partly" working boards in devicetree, such a zylonite, this
> will break their current support.
>
> For example the zylonite I have which is working on DT has a 
> pxa310 variant.
> The cm-x300, which also works in DT, has a pxa320 variant.
>
> What these boards need is their IO mappings and cpufreq to still 
> work after
> your serie in DT. What bothers me are the changes to :
>  - drivers/clk/pxa/clk-pxa3xx.c
>  - drivers/cpufreq/pxa3xx-cpufreq.c
>
> Here the clock changes will probably remove the clock provided to 
> specific
> pxa310/pxa320 drivers for example.
>
> I don't know how you want to proceed, yet this change will break 
> some pxa3xx platforms.

Hi Robert,

Thanks for pointing this out, I thought that I had caught
all the missing dependencies ones after you pointed out
the AC97_BUS_NEW that I fixed in patch 14.

From what I can tell, commit b5aaaa666a85 ("ARM: pxa: add
Kconfig dependencies for ATAGS based boards"), the
PXA310/PXA320 DT support became dead code because
MACH_PXA3XX_DT only selects CPU_PXA300, so if it worked
before that commit, it now needs CONFIG_UNUSED_BOARD_FILES
and CONFIG_EXPERT as well as enabling one of the legacy
board files with the corresponding chip support.

If that's all you think is missing, I can add this
trivial patch as well and rework the series to not
drop code that depends on PXA310/PXA320:

--- a/arch/arm/mach-pxa/Kconfig
+++ b/arch/arm/mach-pxa/Kconfig
@@ -45,6 +45,8 @@ config MACH_PXA27X_DT
 config MACH_PXA3XX_DT
        bool "Support PXA3xx platforms from device tree"
        select CPU_PXA300
+       select CPU_PXA310
+       select CPU_PXA320
        select PINCTRL
        select POWER_SUPPLY
        select PXA3xx

Can you have a look at the other patches to see if there
are more removed drivers or platform bits that are currently
dead code but are actually required?

     Arnd