Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <50111a6f-08de-1da8-0deb-50b0e7a172b7@gmail.com>
Date:   Sun, 8 Jan 2023 15:09:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 2/7] staging: rtl8192e: Rename TSSI_13dBm, Pwr_Track and
 NumTotalRFPath
To:     Dan Carpenter <error27@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <cover.1672330343.git.philipp.g.hortmann@gmail.com>
 <c7d3be41602e656170de46ea649b5bdf1081d5cf.1672330343.git.philipp.g.hortmann@gmail.com>
 <Y7Pni7tvFPhcz7bu@kadam>
Content-Language: en-US
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <Y7Pni7tvFPhcz7bu@kadam>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/3/23 09:30, Dan Carpenter wrote:
> On Thu, Dec 29, 2022 at 05:25:46PM +0100, Philipp Hortmann wrote:
>> Rename variable TSSI_13dBm to tssi_13dbm
> 
> I would probably have kept this one as-is.  It's not CamelCase, it's the
> correct way to capitalize it.
> 
> regards,
> dan carpenter
> 

Hi Dan,

sorry for late.

No issue with keeping this variable as is. But can you tell me the rule 
for the rest of the variables in this driver?

Here just some examples: (I know that checkpatch is not always right)
CHECK: Avoid CamelCase: <Avg_TSSI_Meas>
CHECK: Avoid CamelCase: <TSSI_13dBm>
CHECK: Avoid CamelCase: <Avg_TSSI_Meas_from_driver>

Are those OK as well?

I would like to do it the right way. I do not want to discuss every 
variable change.

Thanks for your support.

Bye Philipp