Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230107184827.2837347-1-trix@redhat.com>
In-Reply-To: <20230107184827.2837347-1-trix@redhat.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Sun, 8 Jan 2023 16:51:26 +0200
Message-ID: <CAFCwf10tOe4H1wyOeJiDk_0NWUAbsNRXemzg1H_6RBsf7Yz8dw@mail.gmail.com>
Subject: Re: [PATCH] habanalabs: remove redundant memset
To:     Tom Rix <trix@redhat.com>
Cc:     gregkh@linuxfoundation.org, dliberman@habana.ai,
        osharabi@habana.ai, obitton@habana.ai, talcohen@habana.ai,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jan 7, 2023 at 8:48 PM Tom Rix <trix@redhat.com> wrote:
>
> From reviewing the code, the line
>   memset(kdata, 0, usize);
> is not needed because kdata is either zeroed by
>   kdata = kzalloc(asize, GFP_KERNEL);
> when allocated at runtime or by
>   char stack_kdata[128] = {0};
> at compile time.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/accel/habanalabs/common/habanalabs_ioctl.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/accel/habanalabs/common/habanalabs_ioctl.c b/drivers/accel/habanalabs/common/habanalabs_ioctl.c
> index 619d56c40b30..949d38527160 100644
> --- a/drivers/accel/habanalabs/common/habanalabs_ioctl.c
> +++ b/drivers/accel/habanalabs/common/habanalabs_ioctl.c
> @@ -1123,8 +1123,6 @@ static long _hl_ioctl(struct file *filep, unsigned int cmd, unsigned long arg,
>                         retcode = -EFAULT;
>                         goto out_err;
>                 }
> -       } else if (cmd & IOC_OUT) {
> -               memset(kdata, 0, usize);
>         }
>
>         retcode = func(hpriv, kdata);
> --
> 2.27.0
>

Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.

Thanks,
Oded