Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 8 Jan 2023 10:37:41 -0600
From:   Rob Herring <robh@kernel.org>
To:     Faiz Abbas <faiz.abbas@arm.com>
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        alsa-devel@alsa-project.org, broonie@kernel.org,
        lgirdwood@gmail.com, krzysztof.kozlowski+dt@linaro.org,
        kuninori.morimoto.gx@renesas.com, Anurag.Koul@arm.com,
        Deepak.Pandey@arm.com
Subject: Re: [PATCH] ASoC: dt-bindings: simple-card: Document
 simple-audio-card,plat
Message-ID: <20230108163741.GA30997-robh@kernel.org>
References: <20230105160346.29018-1-faiz.abbas@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230105160346.29018-1-faiz.abbas@arm.com>
Precedence: bulk

On Thu, Jan 05, 2023 at 09:33:46PM +0530, Faiz Abbas wrote:
> The simple card driver has support for adding cpu, codec and platform
> nodes with the simple-audio-card prefix. Add documentation for the plat
> binding.

Another node, is it still 'simple card'?

> 
> Signed-off-by: Faiz Abbas <faiz.abbas@arm.com>
> ---
>  .../bindings/sound/simple-card.yaml           | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
> index ed19899bc94b..fa67c76d4dbb 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
> @@ -205,6 +205,8 @@ patternProperties:
>      $ref: "#/definitions/dai"
>    "^simple-audio-card,codec(@[0-9a-f]+)?$":
>      $ref: "#/definitions/dai"
> +  "^simple-audio-card,plat(@[0-9a-f]+)?$":

What does 'plat' mean?

Don't continue the 'simple-audio-card,' prefix.

> +    $ref: "#/definitions/dai"
>  
>    "^simple-audio-card,dai-link(@[0-9a-f]+)?$":
>      description: |
> @@ -285,6 +287,27 @@ examples:
>          };
>      };
>  
> +#-------------------------------
> +# single DAI link with platform
> +#-------------------------------

Really need another example for 1 simple node?

> + - |
> +   sound {
> +        compatible = "simple-audio-card";
> +        simple-audio-card,format = "i2s";
> +        simple-audio-card,mclk-fs = <384>;
> +        simple-audio-card,cpu {
> +                sound-dai = <&iofpga_i2s>;
> +        };
> +
> +        simple-audio-card,codec {
> +                sound-dai = <&hdmi_tx>;
> +        };
> +
> +        simple-audio-card,plat {
> +                sound-dai = <&audio_formatter>;
> +        };
> +};
> +
>  #--------------------
>  # Multi DAI links
>  #--------------------
> -- 
> 2.25.1
> 
>