Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp5154069rwl; Sun, 8 Jan 2023 09:26:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXuq5f2R05Pwrb1aMGTGaEFAeLGlRG+cW/87K8Frp0bJggzS7FBKe1uKBSFR3qLJj14VGeL6 X-Received: by 2002:a17:90a:8d0d:b0:226:e0da:fcc2 with SMTP id c13-20020a17090a8d0d00b00226e0dafcc2mr8680839pjo.47.1673198819695; Sun, 08 Jan 2023 09:26:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673198819; cv=none; d=google.com; s=arc-20160816; b=X8CI0x1faJTFvKAH4MX7gyuEkmyaIxhE3hn4bb+xnCFwp3x0ILcXfZ650Ce7M7uEt8 GvQEZI9QEpI2rAB2Z4mVJOzXIaCmpxGiRLsGvxEAyjRqc1UyKMKWGhX8i964BBSaDVlC z4ucU1yYcdrSL289I+W4hbrcz6KQ5KI7ASPtBPcBGb8Opr3LFYNLVkGlk1ggPcVO/jYI JNP29W48znhd6aYviDhq6/VSIqp9sJZgbVmQO8XWEzWTSuaAR8yGa1VNGqtV4HlgsLlU 8gK8CrICBCL2x62qaAzEG5tU4aP+e8L0gpRLvMcOJ8dbYiR8kOlNcLWSKUsDuWZpYRxg zevA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=PQrkiZqtjvYUA/zRH+LNayj1jZUQ4/wLMEUCzn490bk=; b=B1CQKDb7OuOcOIV8HvCWzkBUvK9wcsVYC5tCg1V4H5wy7GB92keWB0Pnf9gxajV/M9 N55FlTLE3FLI8kXJrEKQ5pBC6xKi3pKybEiEzvjuQ4KNTdDvLjXVSLQDMQRJGWhLAinF 3l69GrP0PFvAIUhQBjMrj2UYvA4mA446Ze23p3iH3BBdNQCI4GUhUozNJX/n9ABvLAHt 5wbQuUV6i/zJmb/gmybnhma1zmO7Ycrh/xezGPl+c8x8v6TlSQD1yC37MQvXzpegcIBr aWjsZxJAaU5D7aNavmLLXthM/q7TZl4VxOimgaKV0VtvH1CFWdHo6R3Gow5PmDtrN2q5 ZIhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h37-20020a631225000000b00476db6fe4cfsi7132084pgl.829.2023.01.08.09.26.52; Sun, 08 Jan 2023 09:26:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233065AbjAHRHV (ORCPT + 51 others); Sun, 8 Jan 2023 12:07:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjAHRHS (ORCPT ); Sun, 8 Jan 2023 12:07:18 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C315795BB for ; Sun, 8 Jan 2023 09:07:17 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 2F1CE68AA6; Sun, 8 Jan 2023 18:07:15 +0100 (CET) Date: Sun, 8 Jan 2023 18:07:14 +0100 From: Christoph Hellwig To: Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , Tony Battersby , Kernel Team , Keith Busch Subject: Re: [PATCHv3 08/12] dmapool: consolidate page initialization Message-ID: <20230108170714.GC19739@lst.de> References: <20230103191551.3254778-1-kbusch@meta.com> <20230103191551.3254778-9-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230103191551.3254778-9-kbusch@meta.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2023 at 11:15:47AM -0800, Keith Busch wrote: > From: Keith Busch > > Various fields of the dma pool are set in different places. Move it all > to one function. > > Signed-off-by: Keith Busch Looks good: Reviewed-by: Christoph Hellwig