Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp5168089rwl; Sun, 8 Jan 2023 09:40:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXv+FdSGt5c/9Gi7ylYnVD8V87ZbgvUcjQxU3ox2zUg15TF7AZIUEQF5+fcSKRj+AKtH7WlF X-Received: by 2002:aa7:de8f:0:b0:499:376e:6b27 with SMTP id j15-20020aa7de8f000000b00499376e6b27mr2798991edv.5.1673199643027; Sun, 08 Jan 2023 09:40:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673199643; cv=none; d=google.com; s=arc-20160816; b=GcRXbXbZ7NnF5250yONXjw+Cq/9mWhYhel38pPNsnqFWycu2ICIU01X8p5cKE1nQub CkTpZR7i3T35rKpFKcoqR8oUqP/YI2grODgQ/cc4ArlCACWX2EtUyPhtx/gul8HS62rj wun58f7WdA2PBcTwa7EMR8H5OlaNy8EJM//6cJVraeNVyXYSnEEhcfvc5dvPrphq5Ob/ nI4Lx7S7B//2EmbVDaGRjuO6F0gUuJwKbVoJsibmGFIShrYNHwfZotcFrI6lCNiXQEcI CRC8KRVlQKYt58qWtlKj9QGoz/lC/BTBAavlDMCWUsFfnrlUJSWMaA4lAMpkgZESovAe T9bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WNyoZTkoExUmXqvGesIlbw00ZoUJyc/GjFEcWcL7Kds=; b=rpQSllDWMgUAUMP2MhsNnSNRc/eewuKfQKL9HBeLuf8/3sWPfDt/2zoWs1W7nUy0LY dW9j3ZHLcd3eKUM+9N+OyxIJ/YKMrcpRRTq3t40X1qlSwfogYQ4LjDXW4ArHXwshI8X5 qhJI/JDjZhOfOB6Zit6Q2R4qtC3gChtkyQS8IlB245b0fMx4zi7PiKbCNb48RLDmt2ih NZxy2yP66bR61vVp/pgmx9URlLxM+DpGNu17Fl+5IE27geByRIMQ2fkHEgn9oSyfi9w3 Vbx5rOIoQjEn7meMBRjbeyPMqmSUw0DxJVm3CBwv4QW7svEAuzLBdZmpjK9l473jqqKx TuJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=qUzNX0tR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c25-20020aa7c759000000b0046b0b4ee617si6512199eds.442.2023.01.08.09.40.31; Sun, 08 Jan 2023 09:40:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=qUzNX0tR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233171AbjAHRYx (ORCPT + 51 others); Sun, 8 Jan 2023 12:24:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbjAHRYu (ORCPT ); Sun, 8 Jan 2023 12:24:50 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12A37BE14; Sun, 8 Jan 2023 09:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WNyoZTkoExUmXqvGesIlbw00ZoUJyc/GjFEcWcL7Kds=; b=qUzNX0tRX01ErBEc7fP7m/YKw5 Vl9A2wqkoOPgdtb/ViHgWzLFySziDrbsGPQEciuxYE+eLJ2KJVrCt0s1tsGMEzTjJ5oBN8T6HAt98 ZueqRxzfQxwffqrB7FC8wOEqeDDr4yI1l9Y+nDUAJDOKnoK38QQ+lNzRMH67/RDrrUV86MVwShjUh +od5SncJtBeR3pIMyQS29S8Pj1NK4eSP6VKZSHR1kC1jvx6WKK3F0UPToatlxbaxBYEibfbmLL6sj 6tNls6oW09X/F17GUl3TAwy3L5sEH2aauE39Vs8oEPzgJXSsd/t5C0rh+dxSXjRUdZAknWbzX/Vet FlfKKoww==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEZPZ-00EZ7r-S9; Sun, 08 Jan 2023 17:24:45 +0000 Date: Sun, 8 Jan 2023 09:24:45 -0800 From: Christoph Hellwig To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, Christoph Hellwig , David Hildenbrand , Michal Hocko , Peter Xu , Nadav Amit , Matthew Wilcox , Vlastimil Babka , Rik van Riel , Will Deacon , Michael Ellerman , Palmer Dabbelt , Christian Borntraeger , Dave Hansen , Christian Brauner , Eric Dumazet , Andrew Morton Subject: Re: [PATCH] mm: remove zap_page_range and create zap_vma_pages Message-ID: References: <20230104002732.232573-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104002732.232573-1-mike.kravetz@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I would have split this into one patch that adds the new zap_vma_pages helper, and one to remove zap_page_range to split the separate changes. But the overall result looks fine, so feel free to add: Reviewed-by: Christoph Hellwig to this or the split patches.