Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp5257796rwl; Sun, 8 Jan 2023 11:28:15 -0800 (PST) X-Google-Smtp-Source: AMrXdXvftK89s8sm8xL+aFK8S2Wyz8xW5Y7VvG6pWe4jUXiHZGwa7hlZ6EGw+N1RAMq0pQF0NQED X-Received: by 2002:a17:906:b150:b0:7c1:2931:2263 with SMTP id bt16-20020a170906b15000b007c129312263mr56540136ejb.71.1673206094913; Sun, 08 Jan 2023 11:28:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673206094; cv=none; d=google.com; s=arc-20160816; b=fPaS0tpnRyGnfRExDO4QVNthXvr/rzGigOf1Y27ayW6bIxDcety4x0Ra8b8GiIkaFw fNZRaGmZAMKS9H/7CX+OYGy56yS0guwPOQx84uNEKuSQgnDfwgQ0J790T8hVZFi0b5mI BXbfVpsUGuryIUE5RdT/mdt6o1lXjrUq6jhV8hzfKHCzTn1LPyCZKP0uchkqkMof6U0i A0ITqzEuov+Exfo0ll7WprOI87p19bmjWbGE8miV4FvlkG+TiyA6CFxdgxl8yy2fs8IK EDT+qst6vE8Q6gaCn6yRGv7uW289/vQKQqycsSvSpHwE6SWv39swGDWK1WRYE/9z4HxD Z+dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cMJ3ceXvxgPdEbPMxQqDRLI8Ognh9U7d/fpuwhuSCfE=; b=Tg95bM9gSjDL0MGoegi/IRwNX/J33Tgtt8nk9Y+QHc5NZxdosCXai0ThYRhnHJQdTX LZqUJLal4RvA+E2GDt9WZRcAzrgkpP3eiC1f7yorexBg/i0Q4NYQd3AfmLVRbrh5pOmg I+lb02XC2fcENmQl9DkwfRFzu1A/5zhUX8zklXQirDihyvqE0kdj6u7t7fslAkHpPj+U njd+ZG8vCaAxg7Ya/Yo4tnz5T7vNyZcMFdth75DvXCw2hUSzTpYaf91k7SrhyoE1z7M5 F5I7PVBlmNnMDezkZFRhUJ2j3PH6+AClI4vos1x6oHv60cwh6JVuu5K/4sMac38vSuNv PZEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f16-20020a0564021e9000b004676034f552si9218390edf.45.2023.01.08.11.28.03; Sun, 08 Jan 2023 11:28:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236534AbjAHS62 (ORCPT + 51 others); Sun, 8 Jan 2023 13:58:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236095AbjAHS6D (ORCPT ); Sun, 8 Jan 2023 13:58:03 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CFACE00F for ; Sun, 8 Jan 2023 10:58:02 -0800 (PST) Received: from dslb-188-096-147-053.188.096.pools.vodafone-ip.de ([188.96.147.53] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pEarl-0003b8-JN; Sun, 08 Jan 2023 19:57:57 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 09/13] staging: r8188eu: txirp_cnt is write-only Date: Sun, 8 Jan 2023 19:57:34 +0100 Message-Id: <20230108185738.597105-10-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230108185738.597105-1-martin@kaiser.cx> References: <20230108185738.597105-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org txirp_cnt in struct xmit_priv is initialised but never read. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_xmit.c | 2 -- drivers/staging/r8188eu/include/rtw_xmit.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index 8211b858573f..1cd560630de3 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -192,8 +192,6 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) for (i = 0; i < 4; i++) pxmitpriv->wmm_para_seq[i] = i; - pxmitpriv->txirp_cnt = 1; - pxmitpriv->ack_tx = false; mutex_init(&pxmitpriv->ack_tx_mutex); rtw_sctx_init(&pxmitpriv->ack_tx_ops, 0); diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h index 7e6cf745d913..50d9311d3e40 100644 --- a/drivers/staging/r8188eu/include/rtw_xmit.h +++ b/drivers/staging/r8188eu/include/rtw_xmit.h @@ -279,7 +279,6 @@ struct xmit_priv { u8 wmm_para_seq[4];/* sequence for wmm ac parameter strength * from large to small. it's value is 0->vo, * 1->vi, 2->be, 3->bk. */ - u8 txirp_cnt;/* */ struct tasklet_struct xmit_tasklet; struct __queue free_xmitbuf_queue; struct __queue pending_xmitbuf_queue; -- 2.30.2