Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp5312993rwl; Sun, 8 Jan 2023 12:37:51 -0800 (PST) X-Google-Smtp-Source: AMrXdXulD4b72FJZ7JsxsLDk7+9P4sjLC9ZCX6ICYr/rFAFIX5j4DLidKwLoY5zrySTMasp0VIgw X-Received: by 2002:a05:6a20:a6a8:b0:9d:efd3:66bf with SMTP id ba40-20020a056a20a6a800b0009defd366bfmr74531326pzb.6.1673210271026; Sun, 08 Jan 2023 12:37:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673210271; cv=none; d=google.com; s=arc-20160816; b=OQatuEfu6K2srgFQGOXLaQvoT469ci6IBJG4wQYnXcq4ZxMxaP1NNosaJLu3jHkHeY 2gNYTxbLSLB1VmaV9JpGGrhfuL2G65eE+nNHfZ5laGAUaAKSIGHbZ3Oy1ut2HKsVQlAB 0b0sBW7GkbjZyMYzBC0Qpv/zbTXphXK+wt7Lm2YHqrk/luvBPMHrEwp7Y9fuhR+miRbQ E7SWA5tlBmFbHTcbzWRR6KtH3m9ET4DCDMMoUTCTUfhwwugef53UW5foGhOXawNM6UpI oPmAMWR8OBrBh/zpzWHDovmTtGPY4nNS7GWqD9Lry1qGPGioyzg5MWxJRRhOIlJywqrq geWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=jwMbo3jZwfzrxPAlrx2iocMxlsap6lAjNhHYy958phg=; b=VSPNTW2e1x1RjAjk7Nb0JrZOpovLmSUD6rBQJ18Rn4qoYloWnZXieYzeVCw2aRf21o CQ9AFhpZhlK3sbWHC+MK3TksmfXC6S1co1hpJxToWs31rkP95hqUsFOT31p2KR4yCCBE sOWcp/tbctRKa1UMcuMSGaUoynoo8VG1814DOTcCGk1XWBQ+QEZoVZdIPheBSUG+K2n0 FzcQEU9XGwpH7ft+ZuqHs7IVzvXoH0ZnEhWVvdGonVOl7MhO5ZxHF7+WHWXaiyBz7r0y i2iZmVbfPEkt/1t/8nx+jSfUq91KeuIJ1j6cbiqTUmIKNO2BklhF5vAxcym08l0QJJaT 1jMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=B9LBMt+F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v5-20020a631505000000b0047865b303a5si7975212pgl.762.2023.01.08.12.37.44; Sun, 08 Jan 2023 12:37:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=B9LBMt+F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235893AbjAHT6I (ORCPT + 51 others); Sun, 8 Jan 2023 14:58:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233036AbjAHT5n (ORCPT ); Sun, 8 Jan 2023 14:57:43 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11F4C6176 for ; Sun, 8 Jan 2023 11:57:42 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id y25so9940413lfa.9 for ; Sun, 08 Jan 2023 11:57:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jwMbo3jZwfzrxPAlrx2iocMxlsap6lAjNhHYy958phg=; b=B9LBMt+FOLmA/fahhqUqnasBWh4kgAk/a985k6HdSmC38eRp4yhdBaTl7sJjj6W5vG 25nAMGL7754E7ONiiB3KKGIXPKrT4S+1qpAiXrGCwSf8wSH8yUHyPIY1MNGqTV+eA2jy pdKbZbbiS4ASIgfErAFDpRyCb1MnmIlPEyaQbvywTntiZ6R/nbygbxM1VvwHbUxxz+C/ 70v8wPuju2kg373UmaTxY3b5uIUOCk8PbNR/oYFRh1ImjOzU+s3zs02BNa0IXdCjSYvT +Zevjp/aFfw0Iz3U5sXMsM3KFzGtpX44dEwGIaOCYjPSOvMznerptwZYEyWp6w7e3Lq5 9Gaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jwMbo3jZwfzrxPAlrx2iocMxlsap6lAjNhHYy958phg=; b=FwuDJcB31QIG9k1yD7ZXuRbsqxVEiNK82l5PG91IgGRkYRUz1qeYyTEViIaB+PXbas B41otU5rwhe12ZzFxPBFnuH42Ty3glT2h2WylGcfN6mhWOAP8SCYRyszKgXYXIaln3l3 7Tx2c7zHnw0fTf/JhbUBauMsyaTTiTo7h54lL2DRJOiaXO5irGm1820dF541Qo0Fr/gN XP2y73iNuSP8Rw7hK9OTdCw4tGm+7akQhB0GYakCCzrYvVQmpWUw0tmCI8NXoLIADme0 78p4NV+nvqSZuj3GllPzip4Vx0kTXBbUNpPi1/5R4Tb8r6/4ooX76YdW0EQO0a8PVKVU 1STQ== X-Gm-Message-State: AFqh2krgSpKU3GjBuasVIVFf4lgLVt4swuvX/ysd7YZKLeqyt68Zf5BO NR2BmjXNZ28PKqTdazutVvRAMp/Xo2o= X-Received: by 2002:ac2:50d9:0:b0:4cb:2c19:ec21 with SMTP id h25-20020ac250d9000000b004cb2c19ec21mr8188083lfm.0.1673207860199; Sun, 08 Jan 2023 11:57:40 -0800 (PST) Received: from ?IPV6:2a00:1370:8180:6b00:a1a8:4887:1af4:637a? ([2a00:1370:8180:6b00:a1a8:4887:1af4:637a]) by smtp.gmail.com with ESMTPSA id d7-20020ac25447000000b004b40c1f1c70sm1205176lfn.212.2023.01.08.11.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Jan 2023 11:57:39 -0800 (PST) Message-ID: Date: Sun, 8 Jan 2023 22:57:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 06/13] staging: r8188eu: make rtl8188eu_inirp_init a void function To: Martin Kaiser , Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20230108185738.597105-1-martin@kaiser.cx> <20230108185738.597105-7-martin@kaiser.cx> Content-Language: en-US From: Pavel Skripkin In-Reply-To: <20230108185738.597105-7-martin@kaiser.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, Martin Kaiser says: > rtl8188eu_inirp_init's return value is not checked by its caller. Make > rtl8188eu_inirp_init a void function. > > Signed-off-by: Martin Kaiser > --- > drivers/staging/r8188eu/hal/usb_halinit.c | 14 +++----------- > drivers/staging/r8188eu/include/hal_intf.h | 2 +- > 2 files changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c > index d28b4dc2a767..afa24a59fbb3 100644 > --- a/drivers/staging/r8188eu/hal/usb_halinit.c > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c > @@ -851,29 +851,21 @@ u32 rtl8188eu_hal_deinit(struct adapter *Adapter) > return _SUCCESS; > } > > -unsigned int rtl8188eu_inirp_init(struct adapter *Adapter) > +void rtl8188eu_inirp_init(struct adapter *Adapter) Hm, shouldn't we actually check return value on caller side? This thing is called from netdev_open and issues urbs to read data from the device. So let's imagine that we fail on 1st iteration (for some reason): netdev_open() says all is OK, but driver does not communicate with the device. Maybe these urbs are not that important, tho.. With regards, Pavel Skripkin