Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 8 Jan 2023 22:27:45 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Joan Bruguera <joanbrugueram@gmail.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Wake-up from suspend to RAM broken under `retbleed=stuff`
Message-ID: <Y7s1Ubyxfdz9V+sp@zn.tnic>
References: <Y7qp80cK+r247eCU@zn.tnic>
 <20230108171159.1311342-1-joanbrugueram@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230108171159.1311342-1-joanbrugueram@gmail.com>
Precedence: bulk

On Sun, Jan 08, 2023 at 05:11:59PM +0000, Joan Bruguera wrote:
> Arch Linux kernel config (and I leave any new options at their defaults):
> https://aur.archlinux.org/cgit/aur.git/plain/config?h=linux-mainline&id=20ffc62e08f6b0d48a088bccb6e0c3606b88083a

That .config works here.

> I need to either disable the BPF LSM or apply this patch to boot it:
> https://lore.kernel.org/lkml/20230107051456.8800-1-joanbrugueram@gmail.com/
> I suspend with `systemctl suspend`. Waking up hangs with `retbleed=stuff`
> and works without it.

I booted another, more modern guest which has systemd to see whether a different
userspace could be the issue but it works too.
 
> For verification I booted Fedora-Cloud-Base-Rawhide-20230107.n.0.x86_64.qcow2
> (from https://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Cloud):
>     qemu-system-x86_64 -nodefaults -enable-kvm -smp 1 -m 1024 -vga std \
>         -hda Fedora-Cloud-Base-Rawhide-20230107.n.0.x86_64.qcow2 \
>         -serial stdio -monitor tcp:127.0.0.1:55555,server,nowait
> I appended `retbleed=stuff,force init=/bin/sh` to the kernel command line,
> suspended through sysfs and then wrote `system_wakeup` on the QEMU monitor.

I guess I'll try that next.

And maybe try that on an Intel machine - I'm using an AMD one but the ",force"
thing enables the same stuffing on AMD too even if it is not the fitting
mitigation for it.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette