Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761701AbXHUPdq (ORCPT ); Tue, 21 Aug 2007 11:33:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760173AbXHUPdi (ORCPT ); Tue, 21 Aug 2007 11:33:38 -0400 Received: from DELFT.AURA.CS.CMU.EDU ([128.2.206.88]:54366 "EHLO delft.aura.cs.cmu.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759870AbXHUPdi (ORCPT ); Tue, 21 Aug 2007 11:33:38 -0400 X-Greylist: delayed 1770 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Aug 2007 11:33:37 EDT Date: Tue, 21 Aug 2007 11:04:06 -0400 From: Jan Harkes To: Jeff Layton Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/4] Fix mainline filesystems to handle ATTR_KILL_ bits correctly Message-ID: <20070821150406.GA30675@cs.cmu.edu> Mail-Followup-To: Jeff Layton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <200708202053.l7KKrMYv017763@dantu.rdu.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708202053.l7KKrMYv017763@dantu.rdu.redhat.com> User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 19 On Mon, Aug 20, 2007 at 04:53:22PM -0400, Jeff Layton wrote: > This should fix all of the filesystems in the mainline kernels to handle > ATTR_KILL_SUID and ATTR_KILL_SGID correctly. For most of them, this is > just a matter of making sure that they call generic_attrkill early in > the setattr inode op. > > Signed-off-by: Jeff Layton Coda part looks fine to me. Couldn't test it beyond 'it compiles and doesn't oops', because our userspace client unconditionally strips setuid/setgid bits anyways. Acked-by: Jan Harkes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/