Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp5739092rwl; Sun, 8 Jan 2023 21:53:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXtNQtWXq8EIKuxqjkkjbZYVKM3P+CrhsZdnrehhNTuDH3h78U/NabeV1s9eT/29Rs2giuT2 X-Received: by 2002:a17:906:eb8f:b0:7ae:7e6:3a87 with SMTP id mh15-20020a170906eb8f00b007ae07e63a87mr50269757ejb.41.1673243627658; Sun, 08 Jan 2023 21:53:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673243627; cv=none; d=google.com; s=arc-20160816; b=MOYly1T18kBIIO01BFAojuwxGE5hXImE41wlrcDYXh2GUBseorhq1zZIl3cU0Rjxao HO365lf8OKrxpLFzxsWk23To6Bf/fqF6rckfBbgUq1Y5ggy803Y6U9L1BCFbZe6uFomK MxtBeSTJbXxlN1t+KuMRPEidrYz0SRiL/f8ylEMc9YatHV2WdriQnPTaQqB2zA+D8cni TtMdkLgfVO/v/PNxM3XnbxGh/MPXR5XJioXS2ZOAVkhblxDZ7qaAzkNscqmEZClO947w vUEwtiAlYBBK2BMVmhSBSsI9jjS5gcYoblTYZ74y/fAOTAYFZ8zhIe4w2b1PUQSYyRFH FZvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=6AZ7MMyDzIH6MS2KDjBbHW4VImfdBxKDb57aWuEHLN0=; b=EnYBaXcUmnBnHad4pDm4toLubfVECJWVpuUXcAjXW6F2wN+5zWYmO/C4p73Af/12Ec wJL/1hahVKTUkAHbBXdKLKfGYExSosic81CSuLhYUHWkoHfGu9feTNQ4c3FVfaY4a3TO outu/AhcTG/aeUbtsU7IbqVkQJ1Sft3Gq1nTVXLqX9XX8NdAvGXMw49f1xaKxF3I5/3K FV2ansKqtgclfrajYITEpB2J5FCooAP1IKhHdeYVBVi0yDWHvteG+gKk1X5M+nYoyDiU NQs5fyckHimYlnh0l7LxvUzmRplwcyNbqPCxeNN38NCNOV/H+kMK6o1cTAo7uv/F9qjv xrWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Rtn7FQwa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sz15-20020a1709078b0f00b0073d5a794b43si6649910ejc.985.2023.01.08.21.53.35; Sun, 08 Jan 2023 21:53:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Rtn7FQwa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236511AbjAIFZO (ORCPT + 52 others); Mon, 9 Jan 2023 00:25:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236475AbjAIFYr (ORCPT ); Mon, 9 Jan 2023 00:24:47 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B47A1055D for ; Sun, 8 Jan 2023 21:21:11 -0800 (PST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3091LYt9005579; Mon, 9 Jan 2023 05:21:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=6AZ7MMyDzIH6MS2KDjBbHW4VImfdBxKDb57aWuEHLN0=; b=Rtn7FQwau8o1jSUmat38y7sYMQ512RoT4cB+cxCrCWzFUL+0BuGvy1i204uau2FWne/x 7dyYfRozSzCqgRhjhiZtZIPcyvdLyQOF+/y5KOyd3x3cy1CPuTcGh1SLkHcCbOV+M//M HWIQXXHl05Cyfb8bHcCItdzKgV/iJadip3wZS8FF4Sfy5Q6wIcdVBZNDf/0qhybHt2Gg 1cFAPf5PNxeiEVEuug2WCn7roE4I8AuKrkIEpbyOifO9DI31GAcuBbo1ixbFooihQCp4 QWXcEsvB/SDHizXFGMNKDQagFR4jL0Hkae/FpXYbCQP9KoBl9xBgFZs75Ln1RskLbQB6 Mw== Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3myjgdceyc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Jan 2023 05:21:00 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3084cmxA023308; Mon, 9 Jan 2023 05:20:58 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma05fra.de.ibm.com (PPS) with ESMTPS id 3my0c6spsn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Jan 2023 05:20:58 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3095Ktou37159386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 9 Jan 2023 05:20:55 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B702D20043; Mon, 9 Jan 2023 05:20:55 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 39E7420040; Mon, 9 Jan 2023 05:20:55 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 9 Jan 2023 05:20:55 +0000 (GMT) Received: from [10.61.2.128] (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 0983B600D2; Mon, 9 Jan 2023 16:20:52 +1100 (AEDT) Message-ID: Subject: Re: [PATCH v2 7/7] powerpc/pseries: Implement secvars for dynamic secure boot From: Andrew Donnellan To: Russell Currey , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Cc: gregkh@linuxfoundation.org, gcwilson@linux.ibm.com, linux-kernel@vger.kernel.org, nayna@linux.ibm.com, zohar@linux.ibm.com Date: Mon, 09 Jan 2023 16:20:51 +1100 In-Reply-To: References: <20221230042014.154483-1-ruscur@russell.cc> <20221230042014.154483-8-ruscur@russell.cc> <87zgawgcpa.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: i2LBh1VeUFY3WIKwJGdKFpTyqNTtpmDJ X-Proofpoint-ORIG-GUID: i2LBh1VeUFY3WIKwJGdKFpTyqNTtpmDJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-08_19,2023-01-06_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 mlxlogscore=823 impostorscore=0 mlxscore=0 priorityscore=1501 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301090034 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2023-01-09 at 14:34 +1100, Russell Currey wrote: >=20 > > > +static int plpks_secvar_init(void) > > > +{ > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (!plpks_is_available()) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0return -ENODEV; > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0set_secvar_ops(&plpks_secv= ar_ops); > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0set_secvar_config_attrs(co= nfig_attrs); > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0; > > > +} > > > +device_initcall(plpks_secvar_init); > >=20 > > That must be a machine_device_initcall(pseries, ...), otherwise we > > will > > blow up doing a hcall on powernv in plpks_is_available(). >=20 > OK, can do.=C2=A0 I don't understand your case of how powernv could hit > this, but I think I to have to move plpks_is_available() into > include/, > so it's going to be even more possible anyway. Kernels can be compiled with both pseries and powernv support, in which case plpks_secvar_init() will be called unconditionally even when booting on a powernv machine. I can confirm that as it is, booting this on powernv qemu causes a panic. --=20 Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited