Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp5820962rwl; Sun, 8 Jan 2023 23:34:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXvgT1EfwzUmyJ79ZGmllirx95PXHbltRt6/UNVN+U9pjVFoFYrR8gj8bx9Jf/c2CaxEMVG8 X-Received: by 2002:a17:907:8a16:b0:7c1:458b:a947 with SMTP id sc22-20020a1709078a1600b007c1458ba947mr85310502ejc.26.1673249660875; Sun, 08 Jan 2023 23:34:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673249660; cv=none; d=google.com; s=arc-20160816; b=ChDDw5j2Wh2q1PaY8osJrOVf+IF9zbbWuzExwLGCEMEGpvtb9L0dzSLPralOJtokxA d009kR02jGUTjZK8KNiNTIfXCyFCG3wJq2A9grPeCdRUgfGdo1S32H6T5iqm0UB2S1xz DEDyzvnolWdvYtQF+bRzND+bjOU9E4u4/5yzlWcw7Q4FTYxV4DJUWNMZp9MTUYx4UiHo Q63Zbl2mWpfCF8mhyLDXmt+tOVvX6PCId5hgoRuDusWCFURfuiDuXdQjlQaV2aZ/XNRD QEFiKpX13A6+kMV379jblJkQ02K0m9v9U47VxALTSG5d9OfGk4gLzZxJQsHmOQkbtg3z L+Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=7SH+m1s4mS63bciNGemMDYRFyOd29SGUjqryHuCFfQY=; b=NKYboehY10VkYE1zTFwCzzO7ZKuUXQjDRjhz+n6x2lHSVijEqBhsLqbqLCaF46BsRR xVf05F7Ji/pbNdXRWr8Lv5X+6aA10t2p1x93o+UrX2fvvR5OeOLnKATXqlxyu/5tvGQT 4eqk0Fr7rrohGCVAnXlpT94MnKKwb3+0ZuJtyau8SQp0tW4RNL0haDw79K84OZgubxAg uwx9udHGWVXAxPohp24YQlicmUIgEihBffN8GeWnOX5u2bQNh4FEy+UqdGKHo7bpfK6S oh7sSOaVxHjUs3mCpgK1jFL3CmLvypb1N9cte6K/j5d+L/wltLUxxuN0Ey95zHOD2KYs wBVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EJtDcDS8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dd19-20020a1709069b9300b0080a15fe49bfsi8911179ejc.896.2023.01.08.23.34.08; Sun, 08 Jan 2023 23:34:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EJtDcDS8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233987AbjAIHag (ORCPT + 54 others); Mon, 9 Jan 2023 02:30:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233151AbjAIHaV (ORCPT ); Mon, 9 Jan 2023 02:30:21 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1908C1275A; Sun, 8 Jan 2023 23:30:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id DA941CE0EA2; Mon, 9 Jan 2023 07:30:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 15AE3C433D2; Mon, 9 Jan 2023 07:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673249417; bh=ZCUEoA+q5Y84FmkEwkCc0/nI1EnWj90AeV4mz06wEPw=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=EJtDcDS834gb+MQJViYN6J1w5bmWGQXT4EzMDPi+kZRL243D+uMqGGg61S6jAi/qf py4bF3OXFNnZxJhK6ImjDlQimeNmlKpunkmuLLBssfXx1V344Km2iyhHdICnDBg/YS 501ZTs6m6bToAje3zcKCloVHkBc8Lni+Pq2rnlGMGCOUFBMKcaUP+a+/ptxQuffmGH S9NvaECoi+YimZmcKjsk9jXW+1EV64C17m9E5T78XRoW6dnZiAPZc4ZeeV1W/nVEUe qAlhjeBHdpmbVZUruM6jbheUmvP58uyRB3myG+svWpeN7u/TyNS5DPYPCFPHPCAmQ6 y6kBnwZMLTRUA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 02FE7E4D005; Mon, 9 Jan 2023 07:30:17 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v4] usbnet: optimize usbnet_bh() to reduce CPU load From: patchwork-bot+netdevbpf@kernel.org Message-Id: <167324941700.24554.6732820998527805542.git-patchwork-notify@kernel.org> Date: Mon, 09 Jan 2023 07:30:17 +0000 References: <20230106104950.22741-1-lsahn@ooseel.net> In-Reply-To: <20230106104950.22741-1-lsahn@ooseel.net> To: Leesoo Ahn Cc: oneukum@suse.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Fri, 6 Jan 2023 19:49:49 +0900 you wrote: > The current source pushes skb into dev-done queue by calling > skb_dequeue_tail() and then pop it by skb_dequeue() to branch to > rx_cleanup state for freeing urb/skb in usbnet_bh(). It takes extra CPU > load, 2.21% (skb_queue_tail) as follows, > > - 11.58% 0.26% swapper [k] usbnet_bh > - 11.32% usbnet_bh > - 6.43% skb_dequeue > 6.34% _raw_spin_unlock_irqrestore > - 2.21% skb_queue_tail > 2.19% _raw_spin_unlock_irqrestore > - 1.68% consume_skb > - 0.97% kfree_skbmem > 0.80% kmem_cache_free > 0.53% skb_release_data > > [...] Here is the summary with links: - [net-next,v4] usbnet: optimize usbnet_bh() to reduce CPU load https://git.kernel.org/netdev/net-next/c/fb59bf28cd63 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html