Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230105070357.274-1-liming.wu@jaguarmicro.com>
In-Reply-To: <20230105070357.274-1-liming.wu@jaguarmicro.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Mon, 9 Jan 2023 17:00:17 +0800
Message-ID: <CACGkMEtOAiV4v=-d1SA-wAVvD2WJyes3wWghpAJ9q0baG_aKGg@mail.gmail.com>
Subject: Re: [PATCH] vhost-test: remove meaningless debug info
To:     liming.wu@jaguarmicro.com
Cc:     "Michael S . Tsirkin" <mst@redhat.com>, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, 398776277@qq.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 5, 2023 at 3:04 PM <liming.wu@jaguarmicro.com> wrote:
>
> From: Liming Wu <liming.wu@jaguarmicro.com>
>
> remove printk as it is meaningless.
>
> Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>

Acked-by: Jason Wang <jasowang@redhat.com>

Thanks

> ---
>  drivers/vhost/test.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c
> index bc8e7fb1e635..42c955a5b211 100644
> --- a/drivers/vhost/test.c
> +++ b/drivers/vhost/test.c
> @@ -333,13 +333,10 @@ static long vhost_test_ioctl(struct file *f, unsigned int ioctl,
>                         return -EFAULT;
>                 return 0;
>         case VHOST_SET_FEATURES:
> -               printk(KERN_ERR "1\n");
>                 if (copy_from_user(&features, featurep, sizeof features))
>                         return -EFAULT;
> -               printk(KERN_ERR "2\n");
>                 if (features & ~VHOST_FEATURES)
>                         return -EOPNOTSUPP;
> -               printk(KERN_ERR "3\n");
>                 return vhost_test_set_features(n, features);
>         case VHOST_RESET_OWNER:
>                 return vhost_test_reset_owner(n);
> --
> 2.25.1
>