Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jani Nikula <jani.nikula@linux.intel.com>
To:     =?utf-8?Q?Ma=C3=ADra?= Canal <mcanal@igalia.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Maxime Ripard <mripard@kernel.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     Melissa Wen <mwen@igalia.com>,
        =?utf-8?Q?Andr=C3=A9?= Almeida <andrealmeid@igalia.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        =?utf-8?Q?Ma=C3=ADra?= Canal <mcanal@igalia.com>
Subject: Re: [PATCH 1/2] drm/debugfs: use octal permissions instead of
 symbolic permissions
In-Reply-To: <20230105193039.287677-1-mcanal@igalia.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20230105193039.287677-1-mcanal@igalia.com>
Date:   Mon, 09 Jan 2023 11:22:37 +0200
Message-ID: <877cxw2hb6.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 05 Jan 2023, Ma=C3=ADra Canal <mcanal@igalia.com> wrote:
> Currently, debugfs functions are using symbolic macros as permission
> bits, but checkpatch reinforces permission bits in the octal form, as
> they are more readable and easier to understand [1].
>
> Therefore, use octal permission bits in all debugfs functions.
>
> [1] https://docs.kernel.org/dev-tools/checkpatch.html#permissions
>
> Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Ma=C3=ADra Canal <mcanal@igalia.com>

The commit message should also mention S_IFREG is redundant. Can be
fixed while applying.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/drm_debugfs.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index 5ea237839439..4f643a490dc3 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -207,7 +207,7 @@ void drm_debugfs_create_files(const struct drm_info_l=
ist *files, int count,
>=20=20
>  		tmp->minor =3D minor;
>  		tmp->dent =3D debugfs_create_file(files[i].name,
> -						S_IFREG | S_IRUGO, root, tmp,
> +						0444, root, tmp,
>  						&drm_debugfs_fops);
>  		tmp->info_ent =3D &files[i];
>=20=20
> @@ -246,7 +246,7 @@ int drm_debugfs_init(struct drm_minor *minor, int min=
or_id,
>  		dev->driver->debugfs_init(minor);
>=20=20
>  	list_for_each_entry_safe(entry, tmp, &dev->debugfs_list, list) {
> -		debugfs_create_file(entry->file.name, S_IFREG | S_IRUGO,
> +		debugfs_create_file(entry->file.name, 0444,
>  				    minor->debugfs_root, entry, &drm_debugfs_entry_fops);
>  		list_del(&entry->list);
>  	}
> @@ -263,7 +263,7 @@ void drm_debugfs_late_register(struct drm_device *dev)
>  		return;
>=20=20
>  	list_for_each_entry_safe(entry, tmp, &dev->debugfs_list, list) {
> -		debugfs_create_file(entry->file.name, S_IFREG | S_IRUGO,
> +		debugfs_create_file(entry->file.name, 0444,
>  				    minor->debugfs_root, entry, &drm_debugfs_entry_fops);
>  		list_del(&entry->list);
>  	}
> @@ -508,15 +508,15 @@ void drm_debugfs_connector_add(struct drm_connector=
 *connector)
>  	connector->debugfs_entry =3D root;
>=20=20
>  	/* force */
> -	debugfs_create_file("force", S_IRUGO | S_IWUSR, root, connector,
> +	debugfs_create_file("force", 0644, root, connector,
>  			    &drm_connector_fops);
>=20=20
>  	/* edid */
> -	debugfs_create_file("edid_override", S_IRUGO | S_IWUSR, root, connector,
> +	debugfs_create_file("edid_override", 0644, root, connector,
>  			    &drm_edid_fops);
>=20=20
>  	/* vrr range */
> -	debugfs_create_file("vrr_range", S_IRUGO, root, connector,
> +	debugfs_create_file("vrr_range", 0444, root, connector,
>  			    &vrr_range_fops);
>=20=20
>  	/* max bpc */

--=20
Jani Nikula, Intel Open Source Graphics Center