Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp5994570rwl; Mon, 9 Jan 2023 02:47:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXuK46MsojFA6WDmACDjaczlCs3YFq5wmF9XbbR4kzeLHch0UmmN52qifQNII+g2sGQcPEyY X-Received: by 2002:a17:906:30d3:b0:7c0:a1f9:c778 with SMTP id b19-20020a17090630d300b007c0a1f9c778mr55388933ejb.13.1673261234708; Mon, 09 Jan 2023 02:47:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673261234; cv=none; d=google.com; s=arc-20160816; b=H99YiX3/A7ESbYkMRHkeTZBt3v2W1iEDUi7t89xsojBFFhSo2IqrCgNuoumW5I4VCJ kcf8Lk/Klxz1cvGxBovnQqFxMzDBCgA0Ciz66UgmIzgS67edTE2XCJIiQ18CgwPIRRUt x/WPgloGrM59ZxRcymN+k5NAcVXBmEB9QiADNPc8L9mQBoS+0Zpc4Y7s79YI3+qhdvXB oUJCbKCQe4lHPI2rD75RQfhcaMrRPQb5a8zZCflBNmk7dBaxYLDKX1rnsMdqQb/f7F++ UbYQAY0bCAJTmd6pUDst7XnJ4kcdaPK0FUEYSC/bsmROvyrt6LJHa17Bq1T5VqBL5jde i+Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=s3E9dpbJtVH4yEt7zzsizo9ZhgWRrl0Z4FFOZogFsGQ=; b=rqTbUt3GInoh6Vh7BeOljjs71wtlLCcGjxoAm9Yhg/cNHMRhSIbPMurN/cMLJGo1hL PGgNqVen86kmIJqDsoD5rl1mWoxXR5BbWbnnwiNVHxyTk/ZDa2LtNEQwIupPwVDcNQAr RlE4+jZhjq3FlC1Tn7s8zowjFOYPJPDX9KNk/F3KeK1xbzgkMK16rGqFBs8gIrhUJKAz LJqrEg6Yd6xWgg9SAs10u5aCx0yTJchCMcxAxq0wEfDKcuvvjBTIdPjwvSVEKpJ48vPF OxXmh0us1DBEkIoEh8Yqe7ecG5B1qCeSjeQ2ub6mC7C4pj8uSu8fdkUV59Yb+K6FFVh/ 6d2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=jCSwIarR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa41-20020a1709076d2900b0084cb98e14e2si8888643ejc.621.2023.01.09.02.47.02; Mon, 09 Jan 2023 02:47:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=jCSwIarR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236703AbjAIKNW (ORCPT + 54 others); Mon, 9 Jan 2023 05:13:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236514AbjAIKMt (ORCPT ); Mon, 9 Jan 2023 05:12:49 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3B6D13D4D; Mon, 9 Jan 2023 02:11:08 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7B54A1EC0532; Mon, 9 Jan 2023 11:11:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1673259067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=s3E9dpbJtVH4yEt7zzsizo9ZhgWRrl0Z4FFOZogFsGQ=; b=jCSwIarRYH0YWxO8139x/U/oNZxdg0R7f3zhQcU7d4Q7VoxAuTSz88tJZZeKWa93qp9LAe +/XNcLKvOLLjXemde+ebcLKd9+9nzaLc8zN5y4RxQjidPHMtLJB/1Avp0SgEvEcaQjDPBg ZGYstu9CV8LZoV+HOfBBK+LgTxa5pFM= Date: Mon, 9 Jan 2023 11:11:03 +0100 From: Borislav Petkov To: "Potthuri, Sai Krishna" Cc: Rob Herring , Krzysztof Kozlowski , Michal Simek , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "saikrishna12468@gmail.com" , "git (AMD-Xilinx)" , "Datta, Shubhrajyoti" , kernel test robot Subject: Re: [PATCH v7 2/2] EDAC/zynqmp: Add EDAC support for Xilinx ZynqMP OCM Message-ID: References: <20230104084512.1855243-1-sai.krishna.potthuri@amd.com> <20230104084512.1855243-3-sai.krishna.potthuri@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2023 at 06:09:02AM +0000, Potthuri, Sai Krishna wrote: > As we are raising a warning message in intr_handler() if the flagged interrupt > is not UE or CE and we return from there, so do we really need else if{} and > WARN_ON_ONCE() in else{} here? Yeah, ok, lemme remove it and queue the thing. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette