Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6025150rwl; Mon, 9 Jan 2023 03:16:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXtE708MBABMF4wvsyfDbA2CBuipJ4f6BApy/f7mbHvIvkCEW13kqNDF1CJJR7UuA9aoibqg X-Received: by 2002:a17:906:6441:b0:7c1:994c:f168 with SMTP id l1-20020a170906644100b007c1994cf168mr60854412ejn.54.1673262990475; Mon, 09 Jan 2023 03:16:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673262990; cv=none; d=google.com; s=arc-20160816; b=xerI80fAy2hZdLbh3syU+TGGZvbZVSp+bwajTvcNIrQZLMioaTJlMwVM+0zPZRem5k 3lkGQQLS/Gv0m5xABNQGFeYzWVokDBdtnpb8zw1S5opA7e2+VeH26zICLWOZ5T5NX5AI BqWDcL3UFymFHzscRJRoh9PoHDrlmkZteaGNmDJLmm82Hvy5DP0uSRk/BCXfBhb/KlXd Vru1tObqEHo8HZOJ4Jo9y4NPGH3JKtVKnS0XzI1H6Gih4JAcGXOnFUM9UkzImy2VrsxN ll5279mhrcPsae7n/ZodZW/GDPX1xWOLC5RfpIrhnklhcpQhENl+lOdVQgiZS4tQgooX QRyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mH4f9OANiE6I82Rid3V8ENaOi03PPyxh8l5jpzwCQ2g=; b=Zg1HCDKPyDg/91HrDMJ7RYcV9DmyNKZHU2FusC+TM50UsKNdgtZbMBDoz12uBS0bAi hczLF8Jx7ZUhbkGzUxwp5u+JEGMCDnVUHt2fjOnGLnzjwOWSgjtkcTPL04N7nfDetZi9 Eio0YUOgVWbDKFTmlscH6KqbgAia/bT53Zhr70fT4/wGJFOckyGulL+lTIw7H5CU/rL8 yc1mdCfgHSod2/2KscVDp+50XNwS3MR4Ovhwykx0QFL7yVXHG/9AsCyYw8Vr3bdMJKFg L+jbs8Ru5IKb4zTaPAakNzz4XzOdCLW521HoTOVKm8CVBiFcGQLehclhk+wEg9gBEevM T06g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=moQWNsgT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fd17-20020a056402389100b00484cd38e00dsi8188181edb.629.2023.01.09.03.16.17; Mon, 09 Jan 2023 03:16:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=moQWNsgT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233666AbjAIKSB (ORCPT + 53 others); Mon, 9 Jan 2023 05:18:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237079AbjAIKQu (ORCPT ); Mon, 9 Jan 2023 05:16:50 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DCF16169 for ; Mon, 9 Jan 2023 02:16:42 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id k26-20020a05600c1c9a00b003d972646a7dso8591078wms.5 for ; Mon, 09 Jan 2023 02:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mH4f9OANiE6I82Rid3V8ENaOi03PPyxh8l5jpzwCQ2g=; b=moQWNsgTXKScXgCJUB9sQ+uMKOIfJExITq8dYoMSPNwcVjlG8F3+FhYxyVh4mGab5D WPiXjNjY6lbEwvUtN9024Wrnx3OUzFIw0m/ZG8q1W6rCDpa1OoN0eTzHWcgTYugr7EDL YuY02QZRv0AJ8p+UNO/6Ogy0wV3o+Iz78jfaTQzZ7ei9W5SH4b6Rj2NS4RVOQ1RmtqYD AwOrO3RLmFBkhvmD+X+7RozXxiVNmh0qKURl1hGhMdJYI4NTFZPDH0blYgsP/9otzFgP K01EH5s5q7BmAd84+euEhlkabIW9Ub+SNuvUL391QaNXzwQqDIupg5ItSsvCS8YlK+/2 oHXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mH4f9OANiE6I82Rid3V8ENaOi03PPyxh8l5jpzwCQ2g=; b=1IaqZj2V/Rd7INjf5n+7Le85FsJB0pEjeEYr9j8cMb4X9qkan9Dnkrze8dTf1Jco+s J7HdkN2OoNb5gN4CU0rlHKLaiQzF70BDJcyxtgimD9yf8DzHDewtNpOprxPyQR72XE/L pwLslGbEgzgPM2066RGll99q6kGufbpyikNoADlN7sYKNw56yB7LTjn7JgcEnNaUiFj4 NgieOkgQA1wU2Zqikissv7JTmcTjXNnER79uPq6Qd3YT0esisu1gBSrkk9iADoH3s5OI NbueFRoNgDJhQP4+39/aNMyy2R74TtCB3Sg8/xEy8aYa6meJ67RqilY83z3uKyWh8d9c elfA== X-Gm-Message-State: AFqh2krDje3LPIkLs7XMYjyu0TLnWPM23A2nWMWtXMSCO4wSkHeEiu6/ P9weuJk2k3+pn02+c4tc387VjA== X-Received: by 2002:a05:600c:220c:b0:3d2:3831:e5c4 with SMTP id z12-20020a05600c220c00b003d23831e5c4mr49516520wml.40.1673259400970; Mon, 09 Jan 2023 02:16:40 -0800 (PST) Received: from aspen.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id u8-20020a05600c19c800b003d9780466b0sm11970130wmq.31.2023.01.09.02.16.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 02:16:39 -0800 (PST) Date: Mon, 9 Jan 2023 10:16:37 +0000 From: Daniel Thompson To: Stephen Kitt Cc: Lee Jones , Jingoo Han , Sam Ravnborg , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper Message-ID: References: <20230106164856.1453819-2-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230106164856.1453819-2-steve@sk2.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt This RESEND seems to have dropped the Reviewed-By tags provided the last time is was circulated: https://lore.kernel.org/all/20220608143233.l5pbopafqc4n6uwq@maple.lan/ There's only four patches so I guess I can add them again so the tools can pick them up. Reviewed-by: Daniel Thompson Daniel.