Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6047882rwl; Mon, 9 Jan 2023 03:36:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXsceGq/OxY9Ql8HLdjT36VEYLopUbVXjud3MdEAunrmQ/1PVz+bddeeE3ke5mGD0DfOsEFC X-Received: by 2002:a05:6a20:4291:b0:b0:47e7:6cba with SMTP id o17-20020a056a20429100b000b047e76cbamr89058693pzj.46.1673264196111; Mon, 09 Jan 2023 03:36:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673264196; cv=none; d=google.com; s=arc-20160816; b=VqNl0p052qk39IuyrXfst/vxChtjl0WH2HiEPLtfHXzNBryHGCZzxGwiQWAetTJMYt krB51mIuCsFapkSL4sbN5gtdtzIk5Lsitjb2ANq+BRiBNK9xCVLJbRy0tFNgkCL8D1Gu M39ZcNtb9+PzoC5w2byzNEE9Q9a1geXlxE+eEU+sUM1wQBMeML7Ytl6UmOOEuc/h97qB 3NNnKOW88qXKLVP4E6PtoiCXVIQ8EM3mECVF/z2lvevAQEVT+E//jbH5DEE42+2jTpww +tnc3w/NRIyAXPRIfAAST0Zt7/DAD/lB3OphQXmLgJQvdvnycREOgg2N6XCbFqbgR/YQ jUNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=F1o1h0/8Z9CTd9JzV9HYcBGjMEGQHN88SqgrqMI3CKE=; b=HG/20qFdrkl72gEpkeoo9rD14IGcELzKxNL20RDQrVx/FIg2aAyD9EugtT0AtcbwS3 zg0CHkOHyrxEMcjBGKVNg0ped9PaPOEPr79ABwu+8GQqPznml6pBPXQ18UyQcM/QlJUz GMEmYqqza8D4ijlIST4+ibUOVIwSCwDPvbh5BoWBfqPAz4WcXxROQW8fs9t6kZY+yM6X eDTQVAOc+VPjEZSsnqzEf0Firm6XrN53fyDqwEttddCCJNqF4d2N+TtOP5lHfRgjXefN vo44kvxFLWZEquuKOtPesHVd7dVuhIHSPV4gyMkWS1HyGSYVQPNN5maCVV/rWE6JMxsB 1HIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JfOf7Ybc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t1-20020a639541000000b0049bb86670d0si8829279pgn.290.2023.01.09.03.36.29; Mon, 09 Jan 2023 03:36:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JfOf7Ybc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237129AbjAILEv (ORCPT + 55 others); Mon, 9 Jan 2023 06:04:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236807AbjAILEr (ORCPT ); Mon, 9 Jan 2023 06:04:47 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CF4D1743F for ; Mon, 9 Jan 2023 03:04:38 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id z5so6690508wrt.6 for ; Mon, 09 Jan 2023 03:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F1o1h0/8Z9CTd9JzV9HYcBGjMEGQHN88SqgrqMI3CKE=; b=JfOf7Ybc+GU1nn8y1UcCvxhLZxdJnTmM6yTssoaGD6iHkSp9kw+vB/gkiSd9BYh1Ev 0QFxzWP/4tG540eJGRXWjtCmZaqkjyjagRDq8bBhASM3grdf91bjsYv4KgV91OB6++4s YsO8YvQsF+0XVZ29S/f//4CfrmOe9Sy50FKX3juIAKrtyF082yVw33n51qKs/qdi7yYI 5jeqjXKki1UkPiZnTc5D0T6QLRHn9xrUgbQ09ydGm4qnjFUmkdixeoByKFU5eYtKy7FR 6A31HILTPPT2+/z7YlxLdMYcewFPN71b3Dgv09t0GfYu7LRrYZNWfX48SDylX3W4GzdP ASMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F1o1h0/8Z9CTd9JzV9HYcBGjMEGQHN88SqgrqMI3CKE=; b=bYVGaxoqUAayU0M9LmdJWCIYey65wlGKWk9io+xplL2fl2D7zbpohZWXEvoXeCZfka fUC1+lf1DSZgB0wdoIcVCY0cGkjnlXW2EhfgBq5MQ5P6GgHcXYrNGrRSZpizHB8vTVN6 iUh8uC9XFx30Mjfp5kZbgMd+hZqcF8Jz6tunr9JnjYDLSptEzaxhZSTXjZfVlGPpZ5dY lEmEWyNi/JSdahZz5yA+VJetEmaNNKnihBd2hMx3HOgYy+BIkVd4Jyndmj1YIH2L9KV1 9LLzA6LG6d4Jmzj+yVbRyViXyXbxFJLGaiR4AuQE9Pq/WRUq+9BCUE1f7RYmCTnLGYW0 p4kw== X-Gm-Message-State: AFqh2kqOEHSMVY+JWr+YS6FgcG/LM+b2MSw92b8qSeBfu8KwJt/dadNN YG/16TjuFBmcjkwO3Z0vEz6Jpw== X-Received: by 2002:adf:d846:0:b0:29f:4e42:33c5 with SMTP id k6-20020adfd846000000b0029f4e4233c5mr14183491wrl.55.1673262277116; Mon, 09 Jan 2023 03:04:37 -0800 (PST) Received: from aspen.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id z6-20020a5d6546000000b002bc371a08adsm2060413wrv.101.2023.01.09.03.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 03:04:36 -0800 (PST) Date: Mon, 9 Jan 2023 11:04:34 +0000 From: Daniel Thompson To: sam@ravnborg.org Cc: Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Stephen Kitt Subject: Re: [PATCH 14/15] backlight: tosa: Use backlight helper Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-14-1bd9bafb351f@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-14-1bd9bafb351f@ravnborg.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 07, 2023 at 07:26:28PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Stephen Kitt > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Signed-off-by: Sam Ravnborg Just for completeness... Reviewed-by: Daniel Thompson Daniel.