Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 13:40:16 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Linux-Arch <linux-arch@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: Sparse warning when using ioread64() from
 include/asm-generic/io.h
Message-ID: <20230109114016.z6qowgppuh7uoj75@skbuf>
References: <20230109104054.gabdvjxyawdfbqii@skbuf>
 <9105d6fc-880b-4734-857d-e3d30b87ccf6@app.fastmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9105d6fc-880b-4734-857d-e3d30b87ccf6@app.fastmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1WmIq2LABxuX1xzlMhxux2Eta/w5/i56iFOjGkeWxwyxeR4jj9Dx29SzPzn/?=
 =?us-ascii?Q?d2aPudtiFbG9X5JVq/lVFjlLPCfbT92exSVGwNdt1ZSav2JZh/KkW+V5zKdZ?=
 =?us-ascii?Q?QDmD5zlGBcsUS8jmiO16TIiEOYrKQkXtpPWiUbHmIYyRGIhaOVw8Z6AEmrDh?=
 =?us-ascii?Q?YsD2VB6JL7gBWPMTz955MW/sveOjuHdQ1EWWlirI9FdJXdf7QcXkUmucybgY?=
 =?us-ascii?Q?Be+PdH8tf//TmKnADTj5ZltfoiatsKaBszmYn6Fr+EHGKbkRdrPBHIFxocgh?=
 =?us-ascii?Q?rZ9jdrdKvCWxnxZj2WJg7mKh5M1k+IwIyqD0jF5RUNdeSYbjG8ZtC0kQJ/VT?=
 =?us-ascii?Q?4Lm74/G5BIL1kOGz60Mc3y3GJp6j4DWKhdc/MgdgizTkagr78y0GL/S/7kkE?=
 =?us-ascii?Q?4kY6G9fQMTDhJ3bs2tDBUQ6d23T3Uy9vjGgUCY4ESQK2cd/I+lrzO2lZjKH+?=
 =?us-ascii?Q?g8onOL8OQZsN57LYrZWUxtO+pUS/XwWJs+rwa0600zLzxdBS34suHRi6+B8D?=
 =?us-ascii?Q?U3Ox5Tf5DfTugwan0HnjF9thbQaCF2Gg7iC0e9driRQdlXIO2EyPebkXQvMq?=
 =?us-ascii?Q?q1f36cBK84sY8lQ5iH+4OYQ4QdRkMZHKX86AH+hK3KQ6tQqpPa9gaJdA3A7K?=
 =?us-ascii?Q?Co6DTUPBp1WjBOQT4MnsgGhl7+VnzJcXtK8gindLzLZSKDR2PRMwto/ODlcz?=
 =?us-ascii?Q?XSV5CCOrQh1Xo850HXgzm1i3viBFxgibfjJH1X2/ZStTDj+SUyOjAGjU951L?=
 =?us-ascii?Q?JVyio4aWLOQ46a3QSCnULntWcuAbaFoOpe0ZRNLECCb5a7gARPHVaIAqpzYY?=
 =?us-ascii?Q?E3xRxUxznR+zQbuD41LtjsuJTBsoDdhrk8xnnSOnDag5C4QJKM7C1WwhjlxR?=
 =?us-ascii?Q?LsDDB1rRAyC/fj2FskNJlkLirE48vAYbiCib9Nsc9p3SSjg95mWA62mzziof?=
 =?us-ascii?Q?mtQ+xpgknCR2plHti70XPa10P87SQut2IcFtH5FAVzE8LRgKxHKCEhoSTHgk?=
 =?us-ascii?Q?eJfE8BXcm7yNGRiATt2HncTWdKf/eAb4EnjzWgJt4tjhfjyOM6OjLuPGswP3?=
 =?us-ascii?Q?jROnYrcCrSxhojT40zqC8dS2BoF+853oUNGUnASH9vAX6gc5mFjbj9gmlzr1?=
 =?us-ascii?Q?D5rL7cV1Vm4Z5Q4ArDUcueg7aXiPjzbiAOFxfeXQ7lWBxFEGRDBIyjppEH2z?=
 =?us-ascii?Q?Tu9H8jwtC1QFppUrsERv56NOoiF/HB8H7ydTdHKvFpWnE/NNKLdvuQN7B+4c?=
 =?us-ascii?Q?HD964RLLufSS42EhRAgXsk1tll5Qq6CkxEETNcK7xUGO18BHgIFCEwkrikxW?=
 =?us-ascii?Q?HRd+xCIuh4o1Y4K0HPM7BDNEeovbAiyw1feSo2yX/zawmq2MDHL3RJB7t8P+?=
 =?us-ascii?Q?jGh1N6BNVtUb7juyclmm9qm9AFx+a5Be239BGX6iIy14V8DW248hG0QjYd/Z?=
 =?us-ascii?Q?YuXLAdmJ2GWIA84p2GlyB7sjKYEByWTO4w4R0ngoiZ6E6/EdzHbi+8l2EuLH?=
 =?us-ascii?Q?3MGM0WuAsxJ6oZqzFlrRZL187dM9uXwP/5HrT1vD6kPqmb9uYsCX+ThSPWh4?=
 =?us-ascii?Q?bEmliXQhMENwzGXjZIE0bCPWi/io9BkLCTNlYf3ThPN+PORHtCU95wO2KZ6X?=
 =?us-ascii?Q?Sg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 341ada09-5cb0-4d2b-6262-08daf2364941
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 11:40:19.9242
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zwWpXZsxwP7+wDCtGP9w3SGI1R+hBfqs54miLpXt2j9zO+k7B5R29Vg2miHFDB+B1uGq2kn4u1AAXEZxF/N4OQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8903
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 09, 2023 at 12:33:31PM +0100, Arnd Bergmann wrote:
> On Mon, Jan 9, 2023, at 11:40, Vladimir Oltean wrote:
> > Hi,
> >
> > I would like to get rid of the following sparse error in the enetc
> > driver (for arm64), which uses ioread64().
> >
> > ../drivers/net/ethernet/freescale/enetc/enetc_ethtool.c: note: in included file
> > 	(through ../arch/arm64/include/asm/io.h, ../include/linux/io.h,
> > 	../include/linux/irq.h, ../include/asm-generic/hardirq.h,
> > 	../arch/arm64/include/asm/hardirq.h, ...):
> > ../include/asm-generic/io.h:239:15: warning: cast to restricted __le64
> >
> > The trouble is I don't understand why the casts to __le64 and use of
> > __le64_to_cpu() are even needed, when everything seems to be native
> > endianness. I've seen commit c1d55d50139b ("asm-generic/io.h: Fix sparse
> > warnings on big-endian architectures"), but that doesn't claim to fix
> > anything for little endian (and doesn't touch the 64 accessors, for some
> > reason).
> >
> > Could you please help?
> 
> From what I can tell, the fix for openrisc was described as
> a big-endian warning fix, but the warning is actually the same
> on both. The difference is that on little-endian kernels,
> the __le64_to_cpu() conversion only changes the type but not
> the value, while on big-endian machines, the value would
> be wrong without the conversion: __raw_readl() is defined
> to never byteswap the data, while readl() must byteswap
> little-endian MMIO registers into big-endian CPU registers
> when CONFIG_CPU_BIG_ENDIAN is set.
> 
> Since Stafford only tested on 32-bit OpenRISC, he missed the
> readq()/writeq() accessors that need the same warning fix.
> 
>      Arnd

Hmm, ok, didn't know that difference between __raw_readq() and readq().
With this information, I guess I can submit a patch. Thanks!