Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ebdd688-a1e5-f687-2842-b5005fdd89db@amd.com>
Date:   Mon, 9 Jan 2023 17:00:11 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2] ASoC: amd: ps: Fix uninitialized ret in
 create_acp64_platform_devs()
Content-Language: en-US
To:     Nathan Chancellor <nathan@kernel.org>, lgirdwood@gmail.com,
        broonie@kernel.org
Cc:     Syed.SabaKareem@amd.com, ndesaulniers@google.com, trix@redhat.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, Vijendar Mukunda <Vijendar.Mukunda@amd.com>
References: <20230105-wsometimes-uninitialized-pci-ps-c-v2-1-c50321676325@kernel.org>
From:   syed saba kareem <ssabakar@amd.com>
In-Reply-To: <20230105-wsometimes-uninitialized-pci-ps-c-v2-1-c50321676325@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UURMRTJnZUU0U3NDWmF4dHhRbTZZSVhWZWozVkJnVXAzNHNBbEREM0NXR3lm?=
 =?utf-8?B?aHFHVTYvek5jK3hVMG5ZU2lTOGt0amg3SGV3S0xLR3JMajJaLzB5dlZTelFa?=
 =?utf-8?B?YVZLaTc4cXRxS2tCeFRmQzR4Z0Z1WVNlYUpsTkRQUnpkVVVBRklOemdzbDVw?=
 =?utf-8?B?OWdOYVhkVE1VLzdtOFdIWHpraW9zVno0ZmxzbkdZWXduZWFmM3l1dExKT1Ni?=
 =?utf-8?B?MVBNSmM2QzNJZDdtS1lsVHlNa3Z2cndXR2NTNThRUUR1azd0bVNMb2U2SXZB?=
 =?utf-8?B?M0NxUnlQU1FCQk1LSEhaNjdzby94NU1VYTdPdllVK0xaK0d6clFrRitlMnVF?=
 =?utf-8?B?VUVDNUVYTmhmZThtS25mdHdwZHVwemdxb2h0VVc0K2JWUmQ2WktTWDFodFlr?=
 =?utf-8?B?UGxRSW5mazk5S1lBK2FCeFBhRTZEYVZmRGdXZW10TDlNZExYVnVrTHVwY2pp?=
 =?utf-8?B?YkwvV3F5U0FHaytvTnEvUmxhcjhyR2FpZDV1UjlTcmYxaU1IaDIyWlI1TFpw?=
 =?utf-8?B?TjNMQW5pSi9xL0ZZR2lhL3Z2Nk9OVmsyUXFOLzVpRUVaRjc4VDhEQ2pHRU95?=
 =?utf-8?B?a0MxRk1LSTlpeXNEUEhvdkx4YitOdnlQMi96dGl3ZEdvRU01N2RUVXgzNkRk?=
 =?utf-8?B?ZFBEQjU1aWFhSnN3V1VvWnR3dHczdUlMTSsxTmZxaGlOZVorc3FhNUY2OVBT?=
 =?utf-8?B?Ky82c1Z1V05PeEZQcDhQYzBSVGRPSUppTGo4blF4WUg2TGF3Qi91OWRtZDY5?=
 =?utf-8?B?WHNGRzRwVS9mZ3drRVFZaTlkckdqZ2tVMTJvQ2xxNGVnV1VLRTRKaFFJdWNm?=
 =?utf-8?B?c1c1S2JqM0ZINlU3azV4Sm9UdW5rQVhHZE5zaHhxMllxUk1kNUdNSnJ6STJk?=
 =?utf-8?B?Ynd6WXc2OHRGblFBTzQzNTE1MmVFa1pvcnpxZTY2YU85RnczWjZRa2FxQVBs?=
 =?utf-8?B?c1U1R20rQUd6Mm95NXJDZzN4Wm8vMkc1SjhmemRTWjhiUVY2MVloUmJwUjZa?=
 =?utf-8?B?dlVRQS9ENStVSEF0d0xYZVFrT3VHWjNWUnhTeHZxRGxKTXNLQldVNUYvc0s5?=
 =?utf-8?B?VXNMcG1Nc09zZFRuelBielJOeWRTU3RXckwvN3pRUVRTZ2FDeFZ1akZ2ZHo3?=
 =?utf-8?B?di9ZUEhJK083Q0FsZlNVbmt6aTR2cm5lMXhmZEVBblhZMFFBVUIvVmp5TDhS?=
 =?utf-8?B?a3NRelJaMnByWjRYYm1KcEJEZG8wcTc4QjNJY3JZVzZVK05EdDJiVjA1SjVu?=
 =?utf-8?B?RVA3eXJGa1ZKcXVuNUphby9tb1RkbGZ3dVIvQmRQQ1pJeEh1S1RkczgxU3Q5?=
 =?utf-8?B?eURYOFdBWWc2bmlhRURya2JKZ0pJeFR1Vzd2ZWh1ZERqNXIvcEhjOU9xOEhS?=
 =?utf-8?B?dFQ2MjNWOTUwL1I1THFGMVN6cG9HZUlaWGtPQmFwVFprNjNSUzNFR0JGK1Na?=
 =?utf-8?B?ZUtHZW5hbmJ1bHdRN2pDWVZlY0RWNGNYMkh3WERMRzV6RTYrdW8vUnFUMkt0?=
 =?utf-8?B?Z0U1TVlRVmtoV1ZSdUNENzVaOFZLLytBNUFhUmJiMWJjZ3BpME1ObmZjZmNu?=
 =?utf-8?B?VmNrZTBFQnUwbGVTUWE5ZjUxT3JQaVh3RDJzWmQyK3I2SHpDTVd6VWhYS2pt?=
 =?utf-8?B?R1htZEFFYTlMYWxzb1ZjYmxPOFQ5RU1uR1FPN2lGZ2RTTW9CTzdRbURRV1dE?=
 =?utf-8?B?ZlZoZnlmZ1FGK1M5ak1ydlFmUUlpV0JVUjM1RVpVOHBVMEN3UjN0L1l0bmE5?=
 =?utf-8?B?RGd6WVlPc0Y0QmdURjRnYVdaQjFwUWlpR2xVODVBK2dYekVwdlo1UlM5M0dX?=
 =?utf-8?B?NTlTRjNnRlFCVWJuS2hEVjdyTEpVTFhEaEY2SEp6d2hkSWJqNE9sKzJKS1V5?=
 =?utf-8?B?dEg5aCt1ek1SelpEbDRPNUxOUkh3anZ5MUxkdzRaeU85Q3BBKzZQZjBrTmk5?=
 =?utf-8?B?KzlmaG1VUkdpeG1jVTdrRFQzb0tueVdwVWZ5a0haTDRnMUZDY1JqY3F1TzJF?=
 =?utf-8?B?L1hqZEFvQ0ZHckgySDR4THhnVDYzS1dQYjVOVisxd2VrM1lQaGhYSDBHY1hL?=
 =?utf-8?B?VldrV2g5bEZKdTh5UDlUOERJZjEyUUZIRGFzQU1odTl6QnU5NithTjJycWx4?=
 =?utf-8?Q?39vp9yXsNMfwAiMFDbeO8QWwR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a15dc4c6-3e07-42db-ca92-08daf2358c8b
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3661.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 11:35:03.5412
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0sqIOWis5WFrEZTzN0yRffbX+0I5Qq5rrfuuMlWoKnVuimeT0m+xIG3avlvfOJNLQyrV9235E3yWuRHXWfOBew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4282
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/6/23 06:13, Nathan Chancellor wrote:
> Clang warns:
>
>    sound/soc/amd/ps/pci-ps.c:218:2: error: variable 'ret' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
>            default:
>            ^~~~~~~
>    sound/soc/amd/ps/pci-ps.c:239:9: note: uninitialized use occurs here
>            return ret;
>                   ^~~
>    sound/soc/amd/ps/pci-ps.c:190:9: note: initialize the variable 'ret' to silence this warning
>            int ret;
>                   ^
>                    = 0
>    1 error generated.
>
> ret is used uninitialized if 'goto de_init' is taken. As this is not an
> error nor should the ACP be deinitialized, just directly return 0 in
> this case statement, which resolves the warning.
>
> Fixes: 1d325cdaf7a2 ("ASoC: amd: ps: refactor platform device creation logic")
> Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FClangBuiltLinux%2Flinux%2Fissues%2F1779&data=05%7C01%7CSyed.SabaKareem%40amd.com%7Cab19d64e997043ee07ae08daef7f10d0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638085626264112039%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ximBlRFOMQKg0q6Rac19%2FaVNnyNaBUfkHm9Me5NYj2k%3D&reserved=0
> Suggested-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Reviewed-by : Syed Saba Kareem<syed.sabakareem@amd.com>

> ---
> Changes in v2:
> - Instead of setting ret to -ENODEV and going to de_init, just 'return 0' in
>    the default case (Vijendar)
> Link to v1: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fr%2F20230105-wsometimes-uninitialized-pci-ps-c-v1-1-4022fd077959%40kernel.org&data=05%7C01%7CSyed.SabaKareem%40amd.com%7Cab19d64e997043ee07ae08daef7f10d0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638085626264112039%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=rjsus%2BLxO7v%2F94R48F8VxQXtkt8QnibZLcCbEFLq%2F1g%3D&reserved=0
> ---
>   sound/soc/amd/ps/pci-ps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
> index 401cfd0036be..64648b75de6b 100644
> --- a/sound/soc/amd/ps/pci-ps.c
> +++ b/sound/soc/amd/ps/pci-ps.c
> @@ -217,7 +217,7 @@ static int create_acp63_platform_devs(struct pci_dev *pci, struct acp63_dev_data
>   		break;
>   	default:
>   		dev_dbg(&pci->dev, "No PDM devices found\n");
> -		goto de_init;
> +		return 0;
>   	}
>   
>   	for (index = 0; index < adata->pdev_count; index++) {
>
> ---
> base-commit: 03178b4f7e2c59ead102e5ab5acb82ce1eaefe46
> change-id: 20230105-wsometimes-uninitialized-pci-ps-c-3b5725c6ed31
>
> Best regards,