Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 13:07:49 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Hanna Hawa <hhhawa@amazon.com>
Cc:     jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
        mika.westerberg@linux.intel.com, jsd@semihalf.com,
        linus.walleij@linaro.org, ben-linux@fluff.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        dwmw@amazon.co.uk, benh@amazon.com, ronenk@amazon.com,
        talel@amazon.com, jonnyc@amazon.com, hanochu@amazon.com,
        farbere@amazon.com, itamark@amazon.com, lareine@amazon.com
Subject: Re: [PATCH v5 1/1] i2c: designware: use casting of u64 in clock
 multiplication to avoid overflow
Message-ID: <Y7wDlaOX8f9LhkCI@ninjato>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Hanna Hawa <hhhawa@amazon.com>, jarkko.nikula@linux.intel.com,
        andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com,
        jsd@semihalf.com, linus.walleij@linaro.org, ben-linux@fluff.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        dwmw@amazon.co.uk, benh@amazon.com, ronenk@amazon.com,
        talel@amazon.com, jonnyc@amazon.com, hanochu@amazon.com,
        farbere@amazon.com, itamark@amazon.com, lareine@amazon.com
References: <20221221195900.23276-1-hhhawa@amazon.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wdw+qpb2+KvBw02n"
Content-Disposition: inline
In-Reply-To: <20221221195900.23276-1-hhhawa@amazon.com>
Precedence: bulk


--wdw+qpb2+KvBw02n
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 21, 2022 at 07:59:00PM +0000, Hanna Hawa wrote:
> From: Lareine Khawaly <lareine@amazon.com>
>=20
> In functions i2c_dw_scl_lcnt() and i2c_dw_scl_hcnt() may have overflow
> by depending on the values of the given parameters including the ic_clk.
> For example in our use case where ic_clk is larger than one million,
> multiplication of ic_clk * 4700 will result in 32 bit overflow.
>=20
> Add cast of u64 to the calculation to avoid multiplication overflow, and
> use the corresponding define for divide.
>=20
> Fixes: 2373f6b9744d ("i2c-designware: split of i2c-designware.c into core=
 and bus specific parts")
> Signed-off-by: Lareine Khawaly <lareine@amazon.com>
> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>

Applied to for-current, thanks!


--wdw+qpb2+KvBw02n
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmO8A5UACgkQFA3kzBSg
KbZHyA//epQ1hwTlx9ELobS2Ytyu3/pQdlzz7w+RhyMK34KnoMJzC/DGte5oreqI
x5VPqeFJ3qQy+Qr/yKrTXzA6ag5zAb8t1iFqWmpPYAj4EHRsGdc4qlwr7bax/xOF
vxJ27Pu5TMEiNQCy4jpYCMMGF9IWPnfMZdDiK2Xl86OKhLAgHBTdLViu5ARCjFSR
LNGHXOXuyjSx6+FfaVnjta5VJoyTrSX/HojLotfXBQ5HmkFTUEC1Z+Go5by2+3jt
nXWwZnzrk1oQvJ/UBkca1gLLQHxliDWtCnm6L+8Mwg+59yJo3anAulf0Vf5zVqIG
HcBWjxie9lHEhRCEdOkTy8e63c/6AYL7b4VERcxmmSkw7qnYKT4NrbaSpRVqbbiN
I4diroaLoEqmE5a5+YmIgvjgpcGVCQJrnOLoG9yWZTHUmqef5/XSiob40+RCRqLH
5jAnl7jBRjF820BkMkbZ5tHgYneI8ygNHgK6KWOH+75KiYe4tixrxl8SMylSij9B
fIVAF/61FM44fEespPXpH4gLLLhpC3rVQkBrTt2yyY8kjmUVIgV+qQyGGrcRILET
6UOo6f0wbmr3Irpu8dut4Mcz66HOzVmitq9MBHlZqpcfjDidJkKPSobr1KoyITK6
F8X1nxSoGeMTrPlPvQOmjhr3CUX1ZX1yLmQ0iYLY05ihI2FAu+E=
=Ka1V
-----END PGP SIGNATURE-----

--wdw+qpb2+KvBw02n--