Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 15:53:59 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] staging: rtl8192e: Rename TSSI_13dBm, Pwr_Track and
 NumTotalRFPath
Message-ID: <Y7wOZ0tm7XiJ4Bhx@kadam>
References: <cover.1672330343.git.philipp.g.hortmann@gmail.com>
 <c7d3be41602e656170de46ea649b5bdf1081d5cf.1672330343.git.philipp.g.hortmann@gmail.com>
 <Y7Pni7tvFPhcz7bu@kadam>
 <50111a6f-08de-1da8-0deb-50b0e7a172b7@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50111a6f-08de-1da8-0deb-50b0e7a172b7@gmail.com>
Precedence: bulk

On Sun, Jan 08, 2023 at 03:09:40PM +0100, Philipp Hortmann wrote:
> On 1/3/23 09:30, Dan Carpenter wrote:
> > On Thu, Dec 29, 2022 at 05:25:46PM +0100, Philipp Hortmann wrote:
> > > Rename variable TSSI_13dBm to tssi_13dbm
> > 
> > I would probably have kept this one as-is.  It's not CamelCase, it's the
> > correct way to capitalize it.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Hi Dan,
> 
> sorry for late.
> 
> No issue with keeping this variable as is. But can you tell me the rule for
> the rest of the variables in this driver?
> 
> Here just some examples: (I know that checkpatch is not always right)
> CHECK: Avoid CamelCase: <Avg_TSSI_Meas>
> CHECK: Avoid CamelCase: <TSSI_13dBm>
> CHECK: Avoid CamelCase: <Avg_TSSI_Meas_from_driver>
> 
> Are those OK as well?

You can change the others.  It's just dBm where the capitalization is
correct in the original.

https://en.wikipedia.org/wiki/DBm

(Ironically it's capitalized incorrectly in the URL, but it's probably
too late the fix the URL).

regards,
dan carpenter