Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 09:43:21 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Baolu Lu <baolu.lu@linux.intel.com>
Cc:     Vasant Hegde <vasant.hegde@amd.com>,
        Matt Fagnani <matt.fagnani@bell.net>,
        Thorsten Leemhuis <regressions@leemhuis.info>,
        Joerg Roedel <jroedel@suse.de>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        LKML <linux-kernel@vger.kernel.org>,
        "regressions@lists.linux.dev" <regressions@lists.linux.dev>,
        Linux PCI <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [regression, bisected, =?utf-8?Q?pci?=
 =?utf-8?Q?=2Fiommu=5D_Bug=C2=A0216865_-_Black_screen_whe?= =?utf-8?Q?n?=
 amdgpu started during 6.2-rc1 boot with AMD IOMMU enabled
Message-ID: <Y7wZ+SvT455HS2b6@nvidia.com>
References: <15d0f9ff-2a56-b3e9-5b45-e6b23300ae3b@leemhuis.info>
 <5aa0e698-f715-0481-36e5-46505024ebc1@bell.net>
 <aea57c5f-2d20-c589-ad44-a63f1133a3db@linux.intel.com>
 <157c4ca4-370a-5d7e-fe32-c64d934f6979@amd.com>
 <223ee6d6-70ea-1d53-8bc2-2d22201d8dde@bell.net>
 <6fff9d10-f77f-e55a-9020-8a1bd34cf508@amd.com>
 <Y7gs0zYKp/VXACBi@nvidia.com>
 <bb865b8f-6f8f-769a-6364-d46b45caca85@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bb865b8f-6f8f-769a-6364-d46b45caca85@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EdfabGIqSPqtPc9/Q2TsthzklkE8SNjC6NreYiKjtOa7LdrQt9gL9i36QdBk?=
 =?us-ascii?Q?uK1yPc7k92vfhj8eMmOY12hrjO5MjUdRMiLwtDoGVJSePsvO6UQQmoOrqfPB?=
 =?us-ascii?Q?yc3wf3hDA1LOfr40nDzgM2MpSN8ccai7UTBaqECGBpFIMxSb4sQCx+uVPk2q?=
 =?us-ascii?Q?I5iSEEmL49b4Af+14TCLJ9H6swfWBb6jM/P193ncQ6dumjGBkj6g8D8ka3tV?=
 =?us-ascii?Q?hK5vBQBmo2OGD5ILn1zSYVJdA/6PicGo1PJov8/uJA8GpaWHKR8Gxl+GNdcO?=
 =?us-ascii?Q?xsTXLf9pPOL8pOUTMsHyzk92JGgxPbY1cMjgTz+e8SVhVpz7RuqJFSzwojze?=
 =?us-ascii?Q?zOkfW1khxVIFbC+2gGB7Fuv3AzxDX933GNK434Sbq95oGGjt1cW9Iz2epHq3?=
 =?us-ascii?Q?E9P1I3K1EyMMrl0JPN9H0D0R+YkhFo7IQ1qUqZlIGMisAvXHiTqSBRCaZf/+?=
 =?us-ascii?Q?Lb3j6iPQbN60Ch2YAdS2524W2eQoOAiy9+phJUcVt+GaXSne04/rjpQjlv3h?=
 =?us-ascii?Q?Vf6tzvdmEfeZcebSqe3jY7xzbG3B7Gq1ulc0ptS7JDhwjIKG7hTuPo0/fvtz?=
 =?us-ascii?Q?8UfhUVPcZRvEwnzbrW4z075bg9NuQbMec2pCM6vJVangeqJRp0uhup7AIMaI?=
 =?us-ascii?Q?y1r17GmwiPgRrZvSVBOyyUPhgOvpx8x73V9aH5zTYYNxmliYjmal+kuAI6Zo?=
 =?us-ascii?Q?39JxPLhYE0Dul31dk/4X9Kh39sjYlhK4+nAzB6MTI253oxHy39a+OA9Yv9a5?=
 =?us-ascii?Q?TcdbKEYW95qZNJ0y/0TZ3IrI9XYkTcD660oP0GkUzN/bn8moqOa1BxnFwnzB?=
 =?us-ascii?Q?mhGnYrEKjwSIGGOWYBHzCAmt+IkNTLzT/9yKCoFAtfSzguiCZrK3Qx44u3V6?=
 =?us-ascii?Q?HemX6MHvfWjhIWbOB7SfOvh7dMXG4rRoh+EljOOvHqA0Sb25EuQDPHMLhiPY?=
 =?us-ascii?Q?oia/7HsD8XRij1s2IQIZ4/B2iIpawpofM9nMyCbVfw+BFEMuOkMGSs+WnAdV?=
 =?us-ascii?Q?lXEGTZIrdAMuwr/5a25+coi480aJS+iqmsCzltxIXXodQcgWUvQPLQjIJzzJ?=
 =?us-ascii?Q?vAw91dD9CkKr9B7y6sh4DiBWqcvNYuQWecK1EieTUgr6NLcGOEszGM+kCONr?=
 =?us-ascii?Q?o/Kpy3Qd3qxz+I3ofak7/PFHoDJ+DxCaXSkvQqnuBtBbDT7T4TtjYwlWj8Ao?=
 =?us-ascii?Q?OO4AwtjyxNTw7ZhQ8Ze+CO1JjFJntuPPZmex0x70Gc3oedrvi+/NuxJWYSne?=
 =?us-ascii?Q?Y8GleTQh6FnoOKO6+i6NKlMbwpcBOQaklOVy8BC5KQs9ADWbexHtftUHH8Tf?=
 =?us-ascii?Q?guOhilY/sfa7zRCN6DWA/LZbDTFTLys6DPAVg2KaPmyIP0wjdOc0Vuq0bNxb?=
 =?us-ascii?Q?RT7FBT7zjcajACLW/8U2mGl6JkGTZ1CAiqwKDQVw1yes4PhSaY3LjyDj4Gxj?=
 =?us-ascii?Q?4/d8gCnwaTXylgvgYZcYZOmvxcUs/kvy75mqP5hmXJvTvdab3yp+6SZiL7/5?=
 =?us-ascii?Q?9V+TiWF2UillF8wnnmYr0L0EdLOlY3EOINubHseDTfCS4YhMecnZgHwuXwZm?=
 =?us-ascii?Q?wqQn41EuXE1bjBZZOhWMNrx0kYeRI7eJFygCyiw4?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c176ff9-6ba8-46b4-f1a4-08daf2477964
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 13:43:22.0386
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nxlCN//FQaCmKVrIP18tIrLay1sIXBUzF7wpoBaucjlswqaGeXRMaGEGVo0grfDZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6432
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 07, 2023 at 10:44:46AM +0800, Baolu Lu wrote:
> On 1/6/2023 10:14 PM, Jason Gunthorpe wrote:
> > On Thu, Jan 05, 2023 at 03:57:28PM +0530, Vasant Hegde wrote:
> > > Matt,
> > > 
> > > On 1/5/2023 6:39 AM, Matt Fagnani wrote:
> > > > I built 6.2-rc2 with the patch applied. The same black screen problem happened
> > > > with 6.2-rc2 with the patch. I tried to use early kdump with 6.2-rc2 with the
> > > > patch twice by panicking the kernel with sysrq+alt+c after the black screen
> > > > happened. The system rebooted after about 10-20 seconds both times, but no kdump
> > > > and dmesg files were saved in /var/crash. I'm attaching the lspci -vvv output as
> > > > requested.
> > > > 
> > > 
> > > Thanks for testing. As mentioned earlier I was not expecting this patch to fix
> > > the black screen issue. It should fix kernel warnings and IOMMU page fault
> > > related call traces. By any chance do you have the kernel boot logs?
> > > 
> > > 
> > > @Baolu,
> > >    Looking into lspci output, it doesn't list ACS feature for Graphics card. So
> > > with your fix it didn't enable PASID and hence it failed to boot.
> > 
> > The ACS checks being done are feature of the path not the end point or
> > root port.
> > 
> > If we are expecting ACS on the end port then it is just a bug in how
> > the test was written.. The test should be a NOP because there are no
> > switches in this topology.
> > 
> > Looking at it, this seems to just be because pci_enable_pasid is
> > calling pci_acs_path_enabled wrong, the only other user is here:
> > 
> > 	for (bus = pdev->bus; !pci_is_root_bus(bus); bus = bus->parent) {
> > 		if (!bus->self)
> > 			continue;
> > 
> > 		if (pci_acs_path_enabled(bus->self, NULL, REQ_ACS_FLAGS))
> > 			break;
> > 
> > 		pdev = bus->self;
> > 
> > 		group = iommu_group_get(&pdev->dev);
> > 		if (group)
> > 			return group;
> > 	}
> > 
> > And notice it is calling it on pdev->bus not on pdev itself which
> > naturally excludes the end point from the ACS validation.
> > 
> > So try something like:
> > 
> > 	if (!pci_acs_path_enabled(pdev->bus->self, NULL, PCI_ACS_RR | PCI_ACS_UF))
> > 
> > (and probably need to check for null ?)
> 
> Yeah! This really is a misuse of pci_acs_path_enabled().
> 
> But if @pdev is an endpoint of a multiple function device, perhaps we
> still need to check acs on it?

Ah, I don't know anything about what this means from a spec
perspective.

Certainly if a function can internalize MMIO and loop it back to
another function then it surely is not OK for PASID either, nor should
those functions be in different iommu groups.

So, either this never happens for some spec reason, or the test in the
iommu code forming groups is incorrect.

Jason