Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6269336rwl; Mon, 9 Jan 2023 06:24:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXtT433bJSN09UEh8717meS/IlMHR9yT8j9vnaUyPjUlDKMCE/IrVi9Ffy358f5m5FXkajlm X-Received: by 2002:a05:6402:5145:b0:462:7b85:33aa with SMTP id n5-20020a056402514500b004627b8533aamr54754318edd.2.1673274257775; Mon, 09 Jan 2023 06:24:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673274257; cv=none; d=google.com; s=arc-20160816; b=uXIYALbxxbGjb+WFUMGtop3GLQkV6Ci8jm+5nlpf+FQtqu0n4HFYwEyVVpEDe1EbvZ /2vgjPEFGtx9752jMCvIhGpZu0t3EWhDQwyQ71WkTORINTNFnU4isBSOsG47PWpSPLmp 6eIQT+xt4HRLGYykz5XJpVpArXxgWnaK+4nfw800p5V3+K994aubBo4vtMzkbBHiAEG7 XZOyYI/dSA6/Es0JPc2KZdCxZuokB+FIms28nBjxxmtnG9bDUPkfvGuN34RD8CqhPqj/ 3ooW12EAVwsZjyE9VMBwxxCOZt5q4s2WZyfjLRsMOAlZ+B2EVZZ1nzGRQZ+VsHPpvVba yswg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=TBh4l+oOox7qqr2Os5BHCfwojNKX4LdoqbYoYYXSeWc=; b=BLi2h6GAP8wCx2T7RSOzGi2rMPNRB4/ABSJFUEOA7/Rg/dXcPleb/bB54q4olmiqsZ okT63AXWxbhmZ7AoLO6FEwogH/gyr6HJM3NdT6FugAE8xvaqA9wIF5B6ZOJf4WvPRsLS 1ZwRZVi8toQFOJwqrIQMAjZBIzedabbMfZt2CFHN8V6wnL/ZKd0o7edHvJ9fy5iuhLws PY0nvnn2xSxNiUeXYXjPOa3IPBcthAk8tTypwHOGK2M2yRYv+BgEnaLSlMzfRVGY06I1 G67BmeeV30qmB1v0pLe3dDb4ZKmzER7dOqWOTkM0ang+GqCgH6MCZLzVB2RtA655JWu7 zFwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g9oVhOi6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a056402190a00b00489b995ceffsi11463850edz.196.2023.01.09.06.24.04; Mon, 09 Jan 2023 06:24:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g9oVhOi6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237299AbjAIOOG (ORCPT + 53 others); Mon, 9 Jan 2023 09:14:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237225AbjAIONt (ORCPT ); Mon, 9 Jan 2023 09:13:49 -0500 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D795E2BA for ; Mon, 9 Jan 2023 06:13:48 -0800 (PST) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-4a263c4ddbaso114818457b3.0 for ; Mon, 09 Jan 2023 06:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TBh4l+oOox7qqr2Os5BHCfwojNKX4LdoqbYoYYXSeWc=; b=g9oVhOi6NBeZ3c6t9S7kMzfafGBNT0c7U1ze1kmYSwKckb8wiQ9yZgQyi9zNzLX7UD pcp8JjxfjfmayoO0N3t7l2yLR98E/M+BGbgbmv1/dv9dvyteUIgoyhSsjOQwkuIVZipF iM85F56uXm/GDIjajFGZSvafT7Xkz9R1u3fcvQ2lRMLgOyXTpxb9TDhhHzPS8Nlk6jZi dUkAW2oSKRZtNNV5ELOTuApP/hQxAXdk0eFrXb6U9f7lPEGR3y4/RjB8tCtLHAB4cR2D Ywjbo50cEh4/xJ3u80W5o5VRcnPiciACu/a2Mc2bTA6WQ1EPhD8iN+5U+b0l7QFtMDgF 6nBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TBh4l+oOox7qqr2Os5BHCfwojNKX4LdoqbYoYYXSeWc=; b=sDBIkr/ottuCgUjNHiQGTHZCEVcn1wuQBZtm336jz/k2wKeQziCqvYI7mNly6s7mM7 Pyw9ZsZ2OjjeTuRydb4J6WKCJ/GFVDd7PoTVDLOVkWQyJ+mimG5iIjacle0FAcuQHD4A arzxEZ2Il7kGs7j2huekz3esLEeL+YUwNQif6sotrHysZRTDkKijb20WrslYu6YEYber aGiD3azeIj7bpUHyKLVbQLRXNMlI80xU6ytTstMPzwRWHG95qGv65VuUjD/CgXIZLGWc yxqmKxMooNskyG+Q0ObrSUKe2PSk4VE0XRQme7IlAFBvlf1JhFXT1zXeT95n0XBg5Xlp yyAQ== X-Gm-Message-State: AFqh2kpYBi+EtlaWJynNBrvV8UPlqit1HmEvpP4j1O2r56NuYnEhX5Mk +yiYGZSbPC+0GBc4B3XyHnXFbV4SgqyQ9XJjpa5zVw== X-Received: by 2002:a81:7784:0:b0:461:49a3:db6a with SMTP id s126-20020a817784000000b0046149a3db6amr1433928ywc.185.1673273628147; Mon, 09 Jan 2023 06:13:48 -0800 (PST) MIME-Version: 1.0 References: <20230102082503.3944927-1-linmq006@gmail.com> In-Reply-To: <20230102082503.3944927-1-linmq006@gmail.com> From: Linus Walleij Date: Mon, 9 Jan 2023 15:13:36 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: stm32: Fix refcount leak in stm32_pctrl_get_irq_domain To: Miaoqian Lin Cc: Maxime Coquelin , Alexandre Torgue , Fabien Dessenne , Andy Shevchenko , Marek Vasut , linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 2, 2023 at 9:25 AM Miaoqian Lin wrote: > of_irq_find_parent() returns a node pointer with refcount incremented, > We should use of_node_put() on it when not needed anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: d86f4d71e42a ("pinctrl: stm32: check irq controller availability at probe") > Signed-off-by: Miaoqian Lin Patch applied! Yours, Linus Walleij