Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6280456rwl; Mon, 9 Jan 2023 06:31:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXtOU6gdojdTXkexPLoErZjAApqbX3BH8XjCSm1ik3AhmcigskaiSSwrWgm6+wRv98GaYRVK X-Received: by 2002:a50:fe86:0:b0:48c:bd9b:1fa4 with SMTP id d6-20020a50fe86000000b0048cbd9b1fa4mr32108953edt.10.1673274712469; Mon, 09 Jan 2023 06:31:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673274712; cv=none; d=google.com; s=arc-20160816; b=JnhywFC+YuO7ZWvI3YMzayNNNzkbWnyC0rn5OzyqpHUjEzKEf79ZDvVAZKtNfN/iT7 j/JhGGIPevOaf8ADLknLI490vkhT2RVpKDoGUnoEwaYx1wfPjTaWLiL7RtqkCEoEv/Vm KZIKimPspqcENWlt7LrudaL/aiNU/fk+5/ST+inT9/AHzgbvbUQvX8lg6alhXBR+wNe4 BfVg1UeRKIDECZ+BIT7b8pSgzo++ZDeDYBFlk7Jmul9DuEtms5rQp/aTczN7jY8IWi/k R69BQlKl4Aysmw48QVxnEUrzDZk7i+4vt4UsODDdHx3CAEGAHqxxQemxKXgocisDdPU9 8y/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=P5bobKMsIRznoOvXz7SWvkB6xJnFk6PiGIGY3G6MS2o=; b=nZujxQtioDKkDV43ysUxrefRl4ngkVCX77dtKMEeOV+DfVW0SfzDbqOfvcKJgVncyQ pRq42kQ3jvW3wxEllnUIQ+utuhFBQq7z3Bfr+L1eeB4/J2tjLqUCrTzWOMh3lHqNYI64 qCT0eY5LPCMEgIrjfo1X8BkZuGs+5FkY/ZfSe2c76AQMW93SsRwHdZECNwdMzdGgDo3/ DMH4Ha3lz9cH92QGUVFNAe/d6ns6lnAL8QSK4AC6QzH6XEWIXAfcdVXXdAJ+WJ/AFwxK w4c9drOqA/qutJakrar1ZPDxWPCyK644rwV14cJ1GQ7514biexjbw0ywN+idTzA2lRyN wTbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="HOzC/Pq5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cx19-20020a05640222b300b00494cb3beb5bsi8680004edb.180.2023.01.09.06.31.39; Mon, 09 Jan 2023 06:31:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="HOzC/Pq5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbjAIOOu (ORCPT + 53 others); Mon, 9 Jan 2023 09:14:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbjAIOOp (ORCPT ); Mon, 9 Jan 2023 09:14:45 -0500 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2CDD12616 for ; Mon, 9 Jan 2023 06:14:44 -0800 (PST) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-4d0f843c417so295047b3.7 for ; Mon, 09 Jan 2023 06:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=P5bobKMsIRznoOvXz7SWvkB6xJnFk6PiGIGY3G6MS2o=; b=HOzC/Pq5ulIIhA/KnqPJQFum3MX1CVNtRK6oFn+qIyK8JqJgTT715WipABxQaFbEIF 1JRnwSZ1iTMbopEbnyJarYGppK+0WlOe+lRVtcbvzLLP4OKuQzanGeosfsnAQ2rzBvme ifEHdi6brOwOevGA90SB3nzXbWGUx8iijhMoAS5uCrdXdpWSO2WRFkn/a4EjmL1UFdzI LGF8EngxkFLPNipXCCuv4RLuwe082RQHDDIpuow4i/Ek7CL4z6nc5wmLxgt2tYhZJWk5 Z6ZJ886e1bKQG28ifP4evROVVFlQbCMbPOPfo9XM3Xo8A6eY+zCa2e42XKO9JBTFrbp/ bc+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P5bobKMsIRznoOvXz7SWvkB6xJnFk6PiGIGY3G6MS2o=; b=Wmh/mVJc6byGB6dM6oNZIpynJu9Tcu9dJGgBalTVgnXiqXcYQMhrPqUT4IGgEslNfj nh2pTSIsmdA0jTC+d7BGP+dU5M6xCMP4eWSXS9FK3VyXZULBly3i2tu63KnzQyg44Mpm tMkPVanY5gb5odKna5a8UWvNynMs/s/Q8etIgvd1SeiNekCi11toxrjIfN7wSYwikClu bXwWuFHk0GBY2d55XMa69I32Ab9nabfckEoE6nZs3WQodjrF/1aFjNjytigIR4y8QE6j L4L0sQHKPxVShWfbqiFmGGDG7vvGHp+vsgclDHXuDdTSqsGjaOe20xqV+TkqX8LVr3D+ efSg== X-Gm-Message-State: AFqh2kr5MRMmhvn8XsEpxtBcXaTbFYkE2e5MfmovF8WLh+8rKi89wI6T MdS+9mSArUKFpI4trFQRew+d3ZN03HMsMGWn2/cQ4D027GgapA== X-Received: by 2002:a81:484c:0:b0:36a:de9d:825e with SMTP id v73-20020a81484c000000b0036ade9d825emr1508199ywa.477.1673273684076; Mon, 09 Jan 2023 06:14:44 -0800 (PST) MIME-Version: 1.0 References: <20230102112845.3982407-1-linmq006@gmail.com> In-Reply-To: <20230102112845.3982407-1-linmq006@gmail.com> From: Linus Walleij Date: Mon, 9 Jan 2023 15:14:32 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: rockchip: Fix refcount leak in rockchip_pinctrl_parse_groups To: Miaoqian Lin Cc: Heiko Stuebner , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,SUSPICIOUS_RECIPS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 2, 2023 at 12:28 PM Miaoqian Lin wrote: > of_find_node_by_phandle() returns a node pointer with refcount incremented, > We should use of_node_put() on it when not needed anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: d3e5116119bd ("pinctrl: add pinctrl driver for Rockchip SoCs") > Signed-off-by: Miaoqian Lin Patch applied! Yours, Linus Walleij