Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Usyskin, Alexander" <alexander.usyskin@intel.com>
To:     Michael Walle <michael@walle.cc>,
        "Winkler, Tomas" <tomas.winkler@intel.com>
CC:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <pratyush@kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] mtd: spi-nor: macronix: add support for mx77l51250f
Thread-Topic: [PATCH v2] mtd: spi-nor: macronix: add support for mx77l51250f
Thread-Index: AQHZIuEvkp/AelVvj02xUgjj1TvLia6VyKwAgABYi4A=
Date:   Mon, 9 Jan 2023 14:09:03 +0000
Message-ID: <CY5PR11MB636696A89B94C4C659738290EDFE9@CY5PR11MB6366.namprd11.prod.outlook.com>
References: <20230107214345.2524851-1-tomas.winkler@intel.com>
 <5076cc829fb5a9c5959687a401b120ca@walle.cc>
In-Reply-To: <5076cc829fb5a9c5959687a401b120ca@walle.cc>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JthYAXZ+ri8Dd3AlQHIa2rYsndxVQz1D7kO5/JCVMwqaMI5/7H/0UGUrY/JY?=
 =?us-ascii?Q?ob+oo1dGzfc0lMXByub5L1wagppiFFN+qNpKsbPWrtdieq2ZdQGnZc3zz4Rb?=
 =?us-ascii?Q?/Jhpq4JvbeUPzfNQ+xhjMN6sP8YzjNxLoH+VeBHJ6UBMpCyImNdmV5WWS5B8?=
 =?us-ascii?Q?8S8RxrtJozSQnsLiRZaCB1H6g5U/q5945IrO7hY7y6JHcpliVNkMWeTY9ExK?=
 =?us-ascii?Q?D/wm+/Iwl8dfOVUSqdbHJ5ayllaoc4q02gZBQyqeSJGnW9pRT/SUNCq8BOlu?=
 =?us-ascii?Q?dxcIq3mBX2TOXPKZFurnU8xes1xwqVpYxvxa9tBN+004+EjoAUyVY+npbpZA?=
 =?us-ascii?Q?2/wbHabhIYdF1xTf7a70WJsA5Mjh5lt7hD+pVZekMQ5HVKmhOR0Cvuc7WK9x?=
 =?us-ascii?Q?LXSG3j4IlG/3NDCR/UaWOXagwtlSUH4MgQthDcTaNsIdC9MnKmUsD+C5JdUv?=
 =?us-ascii?Q?NOrHjsxQrM8WKzmrJZ2qE6XG4STyS5V1zEqDAmTDK7CBF9JVTkvChgz2kUgL?=
 =?us-ascii?Q?TiiKmBNbZdYsrHRoLP5ImNI9d+1TrxIKpcGvvc1Bz8JOpJCwfa0MBK5JHsDx?=
 =?us-ascii?Q?Vf+NJC5Wz67zlqKosiVnm9xDu+vNphR9tyA1GjK9w91vZB/LOeIWeN9zABVZ?=
 =?us-ascii?Q?mjSFKLZASenDDt0wAo0ZgpaeN62z4iWFP18qqeiAIA+zP+irJe4oshZjYvGq?=
 =?us-ascii?Q?6l00Q8NRjyDhcNl/tN6+kfUSBjw4pz8dkxyTm28z6PQFrWpUOR5gReL5AGQD?=
 =?us-ascii?Q?ktRNzrva43DfFLwmbcjzXrHK8EC/mBhamUHcOW/VGZWa1BpsHU1MykcVk7Xi?=
 =?us-ascii?Q?ghH5/rWU9Q5CU+DX9t2uHPHb3fEm2CO2wdkqbsdUFtnM/0U/mCsZQvoRZgR6?=
 =?us-ascii?Q?8/UwMNHsAvAp1TkbgC2kCkHQMmLK/DWCwEbB1XdQRcuGqJ3Ybi2uh4t99j+c?=
 =?us-ascii?Q?oXrAZxn8nF4CCzAlZlREvNAN+cu3AX9PgKnJ4S7woMR0qQYME6c8rfaO2qMm?=
 =?us-ascii?Q?9GV0Kxl/fSFMu8Eq2pjENSc3y/18KAfXZkWpGhr2lxMmaZ+5QKzLSoABXFs0?=
 =?us-ascii?Q?b1thKymi0SC6l1+vAWgO812ngoRKVIKOj/x6qnC//NkQGRteHFRBLPRGEHSS?=
 =?us-ascii?Q?DR4UCEe2Uaxo+lis3gx49YcWY+f7zxq6fxl/sZ6cinjyi0yGiAQaBNTzrNRT?=
 =?us-ascii?Q?nmy0AnsBcwh9EOMQJRFLFV9a/iYlqCkXlReWGhwykzIoG4SpeNC0dL3a1WFz?=
 =?us-ascii?Q?O7z1iQL5lqRGuS/Ue2axkOwR3i4P/GZNemnLeHeJD2tu1jCN8RJ9Vx8hZiGl?=
 =?us-ascii?Q?dUC7XwcwGmRcj62I1UwxhrQcMHWB/m0oxoGrW8eLgEqmWlvTRRDBJDs6u3tX?=
 =?us-ascii?Q?M9jJW80Ex9FZDkLjbygxQlEpCLtHOxRP8YOB5YGkX+2xHGGIoATrbfhaL2I4?=
 =?us-ascii?Q?eLLRj4kzVGSraDEk4VZOMwJ44xFgzxdx7GdEft/+KgsZPsr06lZezdDiKoDd?=
 =?us-ascii?Q?EqjfnZ9SzQ82WY8+PexVt5DReJbt92N/ysoPyLOQ2ezO3XM7TRf1dTTuOsFF?=
 =?us-ascii?Q?iVVmmDY0WbBIBlEihX4TSpFws9QRGERq0xa59ADiPuNljqgpAw/f8lcF4WOU?=
 =?us-ascii?Q?uQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac2c89bf-3f7b-417b-3feb-08daf24b101f
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2023 14:09:03.2829
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N/dlayqR4WqrzU7L3wytkhr0fVVFBjrCki0V2RxZ6Bw/4rKwj/Hh1aA1FFHhpTCcO++DQhsvqbUXXFCISi3UuDrGVz8uC41z3250wzXgQaA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7706
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -100,6 +100,8 @@ static const struct flash_info macronix_nor_parts[]
> > =3D {
> >  	{ "mx66u2g45g",	 INFO(0xc2253c, 0, 64 * 1024, 4096)
> >  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ)
> >  		FIXUP_FLAGS(SPI_NOR_4B_OPCODES) },
> > +	{ "mx77l51250f", INFO(0xc2751a, 0, 64 * 1024, 4096)
> > +		PARSE_SFDP },
>=20
> With the newest generic spi nor driver [1] this patch shouldn't
> be needed at all anymore. Could you verify, that your flash will work
> without it?
>=20
> -michael
>=20
> [1]
> https://elixir.bootlin.com/linux/v6.2-rc3/source/drivers/mtd/spi-
> nor/core.c#L1637

Tested now, the v6.2-rc3 recognizes the chip.
Does this mean that all SFDP-supporting chips will be recognized automatica=
lly?

Tomas, we can abandon upstreaming effort, I'll save the patch if it will ne=
eded by older kernel versions.

--=20
Thanks,
Sasha