Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0a3c520c75dcfe6ff86e96aa18fc5b52ce1e3f30.camel@collabora.com>
Subject: Re: [PATCHv6 4/7] dt-bindings: arm: rockchip: add initial rk3588
 boards
From:   Christopher Obbard <chris.obbard@collabora.com>
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Marc Zyngier <maz@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Date:   Mon, 09 Jan 2023 14:27:21 +0000
In-Reply-To: <20230107002854.2kok76qdvl4a3hzw@mercury.elektranox.org>
References: <20221214182247.79824-1-sebastian.reichel@collabora.com>
         <20221214182247.79824-5-sebastian.reichel@collabora.com>
         <d12fc3f83ace9285f7e1153003b14bc351ce95de.camel@collabora.com>
         <20230107002854.2kok76qdvl4a3hzw@mercury.elektranox.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2-1 
MIME-Version: 1.0
Precedence: bulk

>=20
>=20
Hi Sebastian,

> > To better match other boards from this vendor (e.g. RADXA ROCK 4)
> >=20
> > would it be best to capitalise this (and obviously the model field
> > in
> > the respective DTS patches) the same?
> >=20
> > So it would become "Radxa ROCK 5A" and "Radxa ROCK 5B".
> >=20
> > It's also capitalised this way on the documentation website [1].
> >=20
> > (I think the vendor has specifically dropped the Pi reference from
> > these boards, but I don't know why)
> >=20
> > Thanks!
> > Chris
> >=20
> > [1]: https://wiki.radxa.com/Rock5/5B
>=20
> The current format has been requested by Radxa:
>=20
> https://lore.kernel.org/all/892CB3E963AEF095+eaed7498-2324-9476-6a24-f940=
d62adb74@radxa.com/
>=20

The comment there suggests to use "Radxa ROCK 5 Model A" and "Radxa
ROCK 5 Model B", so can we make the following changes before the next
revision, to align on the model names?

PS. I think "board" is a terrible suffix, it's almost like when people
say "PCB Board". But maybe I am missing some historical context here ?


- Patch 4: "description: Radxa Rock 5 Model A" > "description: Radxa
ROCK 5 Model A"
- Patch 4: "description: Radxa Rock 5 Model B" > "description: Radxa
ROCK 5 Model B"
- Patch 6: "Radxa Rock 5A Board" > "Radxa ROCK 5 Model A"
- Patch 7: "Radxa Rock 5B Board" > "Radxa ROCK 5 Model B"


Thanks!
Chris