Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <758b66bb-6f9e-8a9a-8b0f-10cd79a65613@oracle.com>
Date:   Mon, 9 Jan 2023 14:58:35 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v6 1/7] perf vendor events arm64: Add common topdown L1
 metrics
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        Ian Rogers <irogers@google.com>
Cc:     Xing Zhengjun <zhengjun.xing@linux.intel.com>,
        Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Andrew Kilroy <andrew.kilroy@arm.com>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Zhuo Song <zhuo.song@linux.alibaba.com>
References: <1673017529-1429208-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1673017529-1429208-2-git-send-email-renyu.zj@linux.alibaba.com>
 <7f60c97a-18df-4f93-0e95-2a9a6dccbda7@oracle.com>
 <c2e5f9d7-c6d8-c70a-8eff-a8e1c5fcf0af@linux.alibaba.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <c2e5f9d7-c6d8-c70a-8eff-a8e1c5fcf0af@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHZkTjNVN3R0Q1FoOWo0VjZKQjRmb3hPeUhoditTMXk0azBLZUh5TFFmV1Nl?=
 =?utf-8?B?QyszV1haZTAyMHIrODQ2QTJnd3dCTHc4c3NaaVdlOTEva3R2aTZzMlh4dFY1?=
 =?utf-8?B?SkE2T00wdHZFWFhWVjBGRkd0ZG9uYVcxVDFHb3R6QTJGV0F2R3J2ZVgwNGMx?=
 =?utf-8?B?QXNXK0tyblRjMFJsSXpOU0xWTW9EMFArL00rVmJuRndlU1pmZy8wazRDWTNy?=
 =?utf-8?B?YXZiUUkzaUJLK0UvWW4rdmIxK0Y4N09iZ3FOenVzYlIvUWtWaWFmSUtiUUJi?=
 =?utf-8?B?VnpLeXFrb1c3MHJJSEF6akpLZWR3T0J0anlKUkhRb2dtd1gvbHZhbFp4eldx?=
 =?utf-8?B?MkJaZ0p4SWd2c3c5LzZQWlJpaUZwRFo0cTREc0tXOVM4eTFzVTVwV3JjR3JT?=
 =?utf-8?B?VG0vYzNjcEV5eFhkdXp5by96NE1jbzZBMndZZFY1TlFEY3duWTQ3aWVDTU5Y?=
 =?utf-8?B?dnFENTZISVgxcWRtVlV1Y3IxZ2lBNFUyN2YxVHpPN3hNVGk0eVVzZloyV2Jw?=
 =?utf-8?B?cXdyZVBESVpFZnM3Z3JoZzRGUzkyc1FTVDduWWtib0ZTZm05Qkw3eExZdmcy?=
 =?utf-8?B?dmoxa3dMK1ZKR1ovNlhMSkpyNVRlZmhZUVVTNExvdlJCbjVKTlJzMmpTb1M0?=
 =?utf-8?B?ZjUrODduS1B3ZkZMRTRNM2pobWFkbzU3eUFzd0tBU3R6TWtZR1N0c252bzl6?=
 =?utf-8?B?K015eUtqeGlGamlNU3Z5MUFKVVIrU2xIYlk0K3BkWUFZOE9FeE5tYXFlRDkr?=
 =?utf-8?B?RUpqdHNlMmdJaHM4R3VVaXhOQ0JYUzJrT0dqZ1ErbmVFWWY0aHJpNHZTeGlh?=
 =?utf-8?B?bGIzN0xlbitjcmlXak9PUUkxdlQrMk12MU56dHN4S2Q4bXpFblF1a29RQkZY?=
 =?utf-8?B?YWNGSjhPbG9lSVRpVEpuV2xORkdtMXNIc1BmQWdKTGF0U0xDWjlaYjFXT0tv?=
 =?utf-8?B?NG81a1VmaE9iQUs5eEpUUGJ5aTVmY3VjaUVobHg3N01tM1NFZzNWWVVxa1I5?=
 =?utf-8?B?SUZKUllmNFNCYXhQWndsUDZ4NThoS05zN2k1NnZWMWtOVWdmek4yOVpTdU1S?=
 =?utf-8?B?UVR6NUErVnFja0JncDhUczM5M0llNVBGdXcvR0dDN2x5NWtvQzR2VmRJNEpY?=
 =?utf-8?B?NTY4MjlpRElCdVBHa2VySG9oZW14Um1YM3p1N0NpMG40bHB6UEowZGRncEJ6?=
 =?utf-8?B?a1M5aTZoL1FHUkFyVUJEZTZwRVMvZWpVUjllTFdPTkIzUzkzTDVTNVFWNkJm?=
 =?utf-8?B?emEvZVZUbmlmWjBQaEVqQnh0WnNsYzR3azVZaG0yTnI4OVA1cXloam9LNHQ5?=
 =?utf-8?B?VzJ3OG9XMWRZWEVwSGh6eWJaSStYRUM1OW5oQlUxd0h6SDJVYjBJdUVoTmlq?=
 =?utf-8?B?Z1lsdWpDWmFkRTg2UXZlblMrTUxIL3RiUkZBNGgyNGJSWDRyYnpxMmNOODBY?=
 =?utf-8?B?OFQ0dUJ4dWFhWFZvTEdQU3FESXU2ZjRhdi8vcEdTTy9EMjk2Z2dSakhKcFJH?=
 =?utf-8?B?RklTN2lsRDdVc3dmbk1SUlRSL0VKQi9rSElCMVVvaTVqUkZpZWMycFJBUzJo?=
 =?utf-8?B?Qmx2VTN3ZVN6WnpUSWxTWFhjcDgrS2hNZllxZ0ZWb1haaXRiUXUvVG5ja1Rr?=
 =?utf-8?B?MEtyUW1zYWZZc3pJRHZaa3NMRXYrYW9qQnBpQll4STdESjJ0VDZSc2l6ZzYx?=
 =?utf-8?B?Q2VkVGx5eHNueTcrZTNjWjYwSlh1RjhReGtneWREUHpqdHFGeU9GOHNWRjdQ?=
 =?utf-8?B?N3dKeEtDQnlpd2JEV0g0cDQyMllZRlVQaGRhRWZpRTZmZWpxOFVBYmp3eCty?=
 =?utf-8?B?eDBkMjByMWY0TFFoaDA5aWoybUFIKzRzdU43Qm50bzhzUGoramQ0M2gzWDVl?=
 =?utf-8?B?L0hOYWZjWDJTZkxoM3h0MEdhNit5SkZySlhHOVYxQ1B0YTFFSEduMUJsT0dP?=
 =?utf-8?B?K05zbDIzbG5RaGdqc2Uxb2FFMlNINW9Bd3Nnd3RockFpalJKclRKL1E0UHp6?=
 =?utf-8?B?Ly9GdkxkeC90MnQybHJaWjlIMklBVkRlUUpBc1ZNVDdkV0Y1MDAvd2lzUy8x?=
 =?utf-8?B?NFFkcThLWVRUa3Mwa1lmam9DYm5hZ1FHR3R3Q0I2cWxPVTFXQ2R6R1pUOGsv?=
 =?utf-8?B?a2doSkJXYld5TFcyeXNIcnFCU2F1MGMvaXFldjhUZDdLK2djS2VGOTVMYTlv?=
 =?utf-8?B?NWc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?ZGFMRWVEMGxaVXVZTlFZRld4bjZPWkpoZjZoaklHTThxSExyVzFoVFI1cXJt?=
 =?utf-8?B?bGpSZzBOOEZCb0RQVWhrL0VSRHlRa3YrZDI4WnFHLyt3Y1VPZVRmUE5pL3VE?=
 =?utf-8?B?V1Bia3RPNkg5cWlFWmd1djJUQjUrNWQ1bVBDS0ZzMVRneUY5cGhUQmhSczFw?=
 =?utf-8?B?QTFpVGRZaUxYaVhBTzFIUWJjOVZLWVYyUTZlSjNJYlpDZWhsWnRJa3J1bHRN?=
 =?utf-8?B?VmYxVjF6SkszMXkyQVE1Ym43ejdXUm5YSU45ZGtVVG1wazZ4RkcxZEY4UlJy?=
 =?utf-8?B?bTM5YkZ6OXkwcnQ5N2p3bDh2aHF3MlFXNWxKeVZiMDN0QXZIVVM2eG44VVRE?=
 =?utf-8?B?ZUU3VWhVbEtxaWhRWjc0TFExK3BPek8zbTRNQVNPZ05yZVB2VTdBdkNEdTkr?=
 =?utf-8?B?OTVMVS9KT2pHLzh1YTMyUjlucDNTelZEUEllUVZnNUFzQW4waDlNK09hRlRK?=
 =?utf-8?B?TWJPVlpabjNweUpINXlzQXV2VDFGRHBsd2hFV0QwSEJ1NlNRWlp2K2RDSTQr?=
 =?utf-8?B?UkU1R2NkY1M2dmhKM3Jvd2tuQThuTkRuY0UzM0c2d01mN2xnTFVNYVVXZjFX?=
 =?utf-8?B?Yk9zZlhCLzFIMG1BRFpPZUU1aHlkVWRQcm96WTNyTjE1QStKd2I1YzA1TjVS?=
 =?utf-8?B?TG9FU0VHSEpIRllZaWNpbEV5d3Bwa0E5dVRINXVnZHYra25sdk1VTGNpLzFT?=
 =?utf-8?B?aU54Z1ZiRVRLVVU4MmNydDBOb0IyMGNycElyNG50UVhONDBiZWhRbXk2ckRJ?=
 =?utf-8?B?TzQxMzhuRUgvVDVONWFHYnZnUDNHZFhINzlQbWx6SGRZakxkS09sZFFwenNn?=
 =?utf-8?B?ZUk2VzZpZmVvK1BnWk1uTHIzL3gzZ2NUcXU2WldKcm5iRXNmNzVqWldSMmdi?=
 =?utf-8?B?TktsUUdnTUlYaFo1bWlHN1R1ZGVGTHozVmtyYldES1NzTHgyVmZ5TVFhdlJz?=
 =?utf-8?B?dXgrSEJ2aUdTcXY1YVgyZGZzOERwZnduVnltWGNtWmhzbDhQakw0RXNwcGs5?=
 =?utf-8?B?U2YwTGsyY2t2YzBCNCtROXRJUmhpNDVuaWcyckIxNkRsNWIzdTVnbGpmanIw?=
 =?utf-8?B?WkVpRzE4WVN5V1QreUZENUFWRTNUZWlwbnlrUERjRWFhNzc0WXRwcWgrY0t4?=
 =?utf-8?B?U3htdDlXSUhBTE51L1hvc0ZHLzRRdXY2NXNKQXg3Wi83L3kwbjVoN1NidWJ4?=
 =?utf-8?B?UWl6QjhsQldlVlF5R0RPWWZiejBpSE9idVhHVzBOdk94S3gvL0F1eTlVV2dN?=
 =?utf-8?B?dGZaejRia090aXZ4TEVCNU5rVVZ5VUxlNkZGdTdZMTdKNlBxNWx2dXY4emsw?=
 =?utf-8?B?SFB4dENzUzlaSU53VmV4TVRwejZPY1lwbEJZdWVIU1lZNGo1NGpEb0NBWmdi?=
 =?utf-8?B?ajVYOFBVbk5wc2xzNlF6Z1RhRXQ2K3did3BvTzBudWF5eHJjUStmR0gyWGhN?=
 =?utf-8?B?UGZqNVNSRDd3bGV2akZNK3IvWk5ZTzlkMjI0QUlnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59bd12aa-4e9e-427f-bf2b-08daf251fe3e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 14:58:40.1893
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qIXm1owHPPRTd68x5vYnvrWSG6bF8+KJn181bRav4iBHO0dcDOWdHq8FOlIfqs8Zi3ew/ytwibnOXZG/Uj92vQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5544
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-09_08,2023-01-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301090108
X-Proofpoint-GUID: CJ05WZPZ7LtEegI8fPDH5LKG_3gKfQpv
X-Proofpoint-ORIG-GUID: CJ05WZPZ7LtEegI8fPDH5LKG_3gKfQpv
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/01/2023 02:53, Jing Zhang wrote:
> I'll factor out the pmu_core__find function in tools/perf/arch/arm64/util/pmu.c:
> 
> static const struct perf_pmu *pmu_core__find(void)

maybe name as pmu_core__find_same() or similar to indicate that we're 
only dealing with homogeneous cores

> {
> 	struct perf_pmu *pmu = NULL;

no need to init to NULL

> 
> 	while ((pmu = perf_pmu__scan(pmu))) {

1x superfluous level of ()

> 		if (!is_pmu_core(pmu->name))
> 			continue;
> 
> 		/*
> 		 * The cpumap should cover all CPUs. Otherwise, some CPUs may
> 		 * not support some events or have different event IDs.
> 		 */
> 		if (pmu->cpus->nr != cpu__max_cpu().cpu)
> 			return NULL;
> 		return pmu;
> 	}
> 
> 	return NULL;
> }
> 

...

> 
>>> +}
>>> diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
>>> index 69ca000..a2f7df8 100644
>>> --- a/tools/perf/util/pmu.h
>>> +++ b/tools/perf/util/pmu.h
>>> @@ -259,4 +259,5 @@ int perf_pmu__cpus_match(struct perf_pmu *pmu, struct perf_cpu_map *cpus,
>>>      char *pmu_find_real_name(const char *name);
>>>    char *pmu_find_alias_name(const char *name);
>>> +int perf_pmu__get_slots(void);
>> I think that this name is a bit too vague. Maybe perf_pmu__cpu_cycles_per_slot() could be better.
>>
> Does cpu_cycles_per_slot mean "cpu cycles per slot"? In the documemt, Slots mean operation width.
> If slots are 5, the largest value by which the STALL_SLOT PMU event may increment in one cycle is 5.
> So, maybe perf_pmu__cpu_slots_per_cycle() could be more accurate？

ok, yes, fine.

Thanks,
John