Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 10:12:26 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc:     Quanfa Fu <quanfafu@gmail.com>, linux-kernel@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v3] tracing/eprobe: no need to check for negative ret
 value for snprintf
Message-ID: <20230109101226.7f75fc0e@gandalf.local.home>
In-Reply-To: <20230109235913.8ac99d54cff8b7c3fc5dcfa4@kernel.org>
References: <20230109040625.3259642-1-quanfafu@gmail.com>
        <20230109235913.8ac99d54cff8b7c3fc5dcfa4@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 9 Jan 2023 23:59:13 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> On Mon,  9 Jan 2023 12:06:25 +0800
> Quanfa Fu <quanfafu@gmail.com> wrote:
> 
> > No need to check for negative return value from snprintf() as the
> > code does not return negative values.
> >   
> 
> Thanks for simplifying, this looks good to me.
> 
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Masami, do you want to take it into the probes branch, or do you want me to
take it into the tracing branch?

-- Steve


> 
> > Signed-off-by: Quanfa Fu <quanfafu@gmail.com>
> >