Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6465120rwl; Mon, 9 Jan 2023 08:39:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXvQpNdTzxsizW7ZbMDI4L2euX8EuOxRMIKluII40bAtNk5ZU5eU5+PpSjq5fiomri1J+vP0 X-Received: by 2002:a17:90b:4f4e:b0:219:89c3:2847 with SMTP id pj14-20020a17090b4f4e00b0021989c32847mr68358738pjb.44.1673282384215; Mon, 09 Jan 2023 08:39:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673282384; cv=none; d=google.com; s=arc-20160816; b=UEVRcPIB/yDv4Lum1aRETZynESwKiRSuUOQLU3flDkXiqO6a6l/pgMcFGFbMeaBfRm 68vv/EL+vq6aZtGxvG9MXtVWI8f+L/lKAtFNmfHu/pTX2Zcv5d6vParBG+XHFPXO6KGB ixaZK9qcsDnS9AHnR/akAzGWoweq60nZl8qc/lyAE4WGqpBK6nhl7jJGGC3Lh/ko4Mz7 coJjggcAqBoVxABR4vDxGWcXcQQn1FYb/ji51gbVQ+c3ZUtTrlvatZYV7dVTUpYxycD7 T+NaMxGHljcXOsbA+Ng64zabZpHH8p+eL37Z+I84/+zWb0DhXxx/Tb+AtECS+ngA1pdx +Weg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=z+niQef/oIp19ZPZkiD3NOHrMKlrLAG21vq0oN2bzI8=; b=eouwXfV++tz4k+3SgB3jL+KqV+VwIAE31Gy4OFTUl1T0k5MrJc22silQQOH5wdkEJz 7X2i0z7t+xEZAKc7kPNLvHS8jvoO8z7I03VWyXnHzyd0sjRBNEG1ax/Gd9svstw9K/Ax MlLkJrQsu6gx2ZFXL08dka1zeIU1BnyeOuNGqkYxLcz06MX/mp4LAqnqh0oallQ48C6J BkedO4k/1LE/ylkmGUUpX8Ndb02trfENOaRxCnuZLfoQoP5xzIDMgy91vhtgGAqebRnu L55Qm0zBhgCfaNGNdkkTG5UVT06nbVvzVRfZHKPmMjLPw5WiyYYmG3Gs98vktB31zyuu g4wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=XOaraKj2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pi13-20020a17090b1e4d00b0020d5867aab6si10399372pjb.141.2023.01.09.08.39.37; Mon, 09 Jan 2023 08:39:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=XOaraKj2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234625AbjAIQFn (ORCPT + 53 others); Mon, 9 Jan 2023 11:05:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233804AbjAIQFj (ORCPT ); Mon, 9 Jan 2023 11:05:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340F71DDF7; Mon, 9 Jan 2023 08:05:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABAF9611BE; Mon, 9 Jan 2023 16:05:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F105BC433F0; Mon, 9 Jan 2023 16:05:35 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="XOaraKj2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1673280333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z+niQef/oIp19ZPZkiD3NOHrMKlrLAG21vq0oN2bzI8=; b=XOaraKj2DB2VFDzDX60zwUrFOyOgbAtEalCGXgZoKcew8HXZkEKWbtoYI7BI5SJwRGAKwh Lo+oIg9AP89/Fp6cWVKILhFRly1Dpn3yCm1LoJH7SK+5GL2tqzWQL7dqz0rQXHXgNVRiqp YxjflGD7X2Q8pUHpjdn6R6yC1jpCAAA= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id b1117af8 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 9 Jan 2023 16:05:33 +0000 (UTC) Date: Mon, 9 Jan 2023 17:05:28 +0100 From: "Jason A. Donenfeld" To: Linus Torvalds Cc: Luigi Semenzato , Thorsten Leemhuis , James Bottomley , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Jan Dabros , regressions@lists.linux.dev, LKML , linux-integrity@vger.kernel.org, Dominik Brodowski , Herbert Xu , Johannes Altmanninger , stable@vger.kernel.org, Vlastimil Babka , tbroch@chromium.org, dbasehore@chromium.org, Kees Cook Subject: Re: [PATCH v2] tpm: Allow system suspend to continue when TPM suspend fails Message-ID: References: <20230106030156.3258307-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2023 at 02:28:00PM -0800, Linus Torvalds wrote: > On Fri, Jan 6, 2023 at 12:04 PM Luigi Semenzato wrote: > > > > I think it's fine to go ahead with your change, for multiple reasons. > > Ok, I've applied the patch (although I did end up editing it to use > dev_err() before doing that just to make myself happier about the > printout). Thanks for fixing it up to use dev_err(). Final commit looks good to me. Jason