Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4a0bb956-c878-4516-11a0-b233cbc2b3de@oracle.com>
Date:   Mon, 9 Jan 2023 10:26:07 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH mm-unstable 6/8] mm/hugetlb: convert
 alloc_migrate_huge_page to folios
Content-Language: en-US
To:     Mike Kravetz <mike.kravetz@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        willy@infradead.org, tsahu@linux.ibm.com, jhubbard@nvidia.com
References: <20230103191340.116536-1-sidhartha.kumar@oracle.com>
 <20230103191340.116536-7-sidhartha.kumar@oracle.com>
 <Y7jCzW6oqlHpxusA@monkey>
From:   Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <Y7jCzW6oqlHpxusA@monkey>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXFTSktXd0lFcUs2cjYrWndsRDBEcm9hektiTmd1WVA5WkxheTZoM0JWSGgw?=
 =?utf-8?B?ZytDczdQUG94dzM4UEdrNTFLSWFCcTNaSzNyNTU0Qy9NZmtrb1Q3RWltOGRR?=
 =?utf-8?B?a05kM0hrVDBPRm52Y1pMZC92NzBHbWVYc1ZyeWtpeFhZYXp6MmJpL2N5Ulpx?=
 =?utf-8?B?a3dHRy96d3VvOG52dG5FVWdOOWUzNjNDZGVEeTd6R1p3dlgwNy8vbzdmVGRL?=
 =?utf-8?B?WVU2OGtrdWRzdGFoT0VWSlVYUitNUWQ1UkVianBLU2loOVZvM1NNaVEyNkFX?=
 =?utf-8?B?MG1aS1J6cXk2b0NTVHkwWStyRXkvaDVrS2ppem8vWjFmREVyWlhLd0htb0FZ?=
 =?utf-8?B?MWh0TEJVQ0RjclhvZldmT1NvdDRUZ3dadi9ESVB2NjlNWDJLMmJtc0s0L3B5?=
 =?utf-8?B?UGc0MHVoSVhJaDlEazZBdGJzNWFieXBhMG1MVjFDWHMrSGIvWlR1OE9DZWlj?=
 =?utf-8?B?UkN5MWdScGZZOVZHVmZ6NXRBUXN2Mi9EaFJvRXprSlVWbXNPWVdCalFaVGtV?=
 =?utf-8?B?bEc5MFd1U3ZpR0d1WE50OFE5Vm5xS3d1QmV6OE1RKzVtTzYxdldXU1BoOTFK?=
 =?utf-8?B?dHNadEwyczJIVmdFRTMvdy9hUlR3K3F3MGYwbXViRVZJUWVrRTZSYjNhM3Yz?=
 =?utf-8?B?V1prYU1hR245a1NzWGIzU0ROZzRNenFST2xYTzhDSGhhSm8wUzNVS0c4dGpq?=
 =?utf-8?B?WjhVdm9rZSsvV2J6TEtDVDJscW5VUmJ0c0hFQWJOYVR5dzIrbnJKT2tJMm8w?=
 =?utf-8?B?R1NHYnVqcjI1SXZoZWZESU9JRURHTG9RR2tzYzdSYVJyeTFiemRWUlFNRFp4?=
 =?utf-8?B?Rk84UEtObDZoR0liaENSZ3JmM25lazFTbkYzQ3grWnJaRmdCazN0ZFFPN3pJ?=
 =?utf-8?B?YjlEMG5OK3RPcGFKQkVTNjcrN1ZmZ1kwMndTR3lUM2pGY2JuMHh4QlpVU0x3?=
 =?utf-8?B?SThVS1h4MG5XWlRnSXVoNHgyU0NXa1JrdDlkODBuR0FOcWcyeXdtMDFOdnoz?=
 =?utf-8?B?cnJXS1E3enZmb0wvNmpOQ3h0dzF0c1hIMHdkYVpCUC9Tb0NBRmw1dm5MQnls?=
 =?utf-8?B?aHFVL2NxODVIa25DanZGTU5oUjZJbE1vdWNhRGlsYThlaGl2ZS9jZUx4YzV2?=
 =?utf-8?B?RkROYU9HODRPbm5CTjJtNkh1TFNBeEl5T1BrcFBCNWZhNWdjSE5xMndKU2lz?=
 =?utf-8?B?bmdseUVGZk5MSVg4SVlvSEFuNWhjdkM2WG1sY0Jnb2RVZ0paelMzOU5Da1VJ?=
 =?utf-8?B?UWpiNnFVZ2NzRmlMMzFvU0dURDRiQTNRSTlxQ3JBb2JzSmtDSFJNL3p0NE02?=
 =?utf-8?B?NkZORlIwMFZ5aGhqMERWSjJlSVRuQjZVTTRsZndmWWdSL0ZCNjgxNlN6eGpL?=
 =?utf-8?B?cXozRElYSWdIbktsRTdoT2ZqR0QxU2Y4QnI1Wm1sdEJCNnFKOXMrbjZPYXFh?=
 =?utf-8?B?bnZRUzBWd3Z4U2JpT3l4bHFpcmdWOWdvcFpMT1RkSWVoaVh3Mm5CMXhPOG9Z?=
 =?utf-8?B?NkVESmpVWHJHN2s4OURtN2VJbS91MnZHcWkzWmZoQkZWUmlQSFRCR3h2MUZP?=
 =?utf-8?B?REZUVXVEM2VoNzBuZnFsOStjSDFSaWxveGhHQ25Ha3FIY2pERit3T0FoeTd0?=
 =?utf-8?B?alM4bjUveVZaRy81Vk5POGt6SlNTNkxka1VkT3FMMVU4VG9aSEtQMk1sdndy?=
 =?utf-8?B?eG9VUXBGbGJiT3daRUcwcENrWjVzTkVBemxGRGpBQVU0VEpjakVNSlRCTTFD?=
 =?utf-8?B?bkt0cFk0RmxJK0dpaUJYQ0RkLzUvRDQ2LzlTOURCRGhGWElwY3BOYlpUOGlu?=
 =?utf-8?B?a1FLUFlPS0c4Sml1L29HNmNNaTVDbFdyUEt1OC9laTVwQlFzY1JVYlp3MENM?=
 =?utf-8?B?Rm1weGx0UEl1dkZFcWFoMW5XeTJ3b05tcHUzT2hSdnNUcHFjYlMxTHBDa1FL?=
 =?utf-8?B?c25JbUZqZ2VCbHJHaXp1OEIwZHVlUXczcHZZTUNBYXRrTVBPRUNPbHRkSURI?=
 =?utf-8?B?REVvY2hnMlcwakt4RWxkZ2ZNcnhjR1c3WTZpcit5UGozSmtyWnpINklNb3Z6?=
 =?utf-8?B?bjlQT3F4VDVCUGFuTEI3STZCYmR0ZDFSeEU3OFJXNmczdUozUi9uOEdJL1hR?=
 =?utf-8?B?TnlRc1JxUU1rL0I4TFl0eW1UQVZVeWlYTVE2OGZyTW9pWHRvTEU5b1ZIYVNI?=
 =?utf-8?B?QXc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?YlBDcDBWalRQWStRdXM1dEwyTUlWRzJVdjhxOHU3bURiQ3BjSVFkTmQvZW12?=
 =?utf-8?B?SUNwWEl0ZWtqSDZwM0xtT3I1NkZhQmwwMTltQVpjN05DekprYWMrSUJWM0kz?=
 =?utf-8?B?UGZtdzA2djdrN0hIMTdyOTRQUGRBVjNmNC8rUEtraU1MK0k3QVUrRHhyMThr?=
 =?utf-8?B?VVZKRnoya29wc0JSbk9qREtCR2RyY216SUJudStHQlV4ZTZJQ2w3b2ptMmM0?=
 =?utf-8?B?cEdoQXZpekkyblAzUGlPcTJaQlR6TnhwRWdZbGl4UjhuRjE2SUhiZ1A3QnA2?=
 =?utf-8?B?cDI3Q2JMVEQ1Qm1qRzFWeVFEaHJSTEpIcXpCaE13K3poRjN5NUhSdStBeGMr?=
 =?utf-8?B?QkZJbkY5NGRLU0NnNE5EYkZxd2FQdFBwTW4zN3hmWmROeEVwalJXdERvcGZG?=
 =?utf-8?B?ZTNaN2J2NHZHbVRaeENxaUNQeVcwS01VNU9iMkI5WjhUV1JZSEhnUUhiYmth?=
 =?utf-8?B?TmxZd05laEltdXh4M1d3RG9vSFBpQm1oL0lqWWJwd2t4ZVhKdnBGYjZCSXFt?=
 =?utf-8?B?ZXpTdnB1aGxiYkRwbUcwZ3RKcks3ajZjaC9TdHJOSnBCbUM5UkZJQlMvcW9D?=
 =?utf-8?B?U0tJZ2h4Vk55ZkJRUngwNDgxTmtyMjFWVUpBVUUxSVpsK3hNR3JwR2cwM05C?=
 =?utf-8?B?aU9XWThRNGxWUVplSzRYV0xqSFRWZnk5WXc2cGZkVFRiZ09mcm5GVFdPSlVz?=
 =?utf-8?B?OGJkNURMWWU0Ry95dE8zRDhhVGREeGtHdmwzdnhQb1JsejNVU1VDZkhqRjFs?=
 =?utf-8?B?OXVOZnJCb0N5OGtNM3FqTkZLOXFSQzNQY09pM2hiS1JKSWFHYVdJck5rYXpL?=
 =?utf-8?B?YnUwT2xKWmJHajVhMnFuNC92dVVXeGpDRkdtSVp4TzlBWExNcXlPRGVYcm1i?=
 =?utf-8?B?SzVrQU1ibTE3R3R4N0VGeHNpZzJBWEdaK0Npbm1BSktweE9XeXZaQWt4T2I1?=
 =?utf-8?B?dDh2Y2ZWWXFYUkNubEdXRm01UUhkb1VpaEp2K1l3N1JFUGREUVk5WlZYYkNL?=
 =?utf-8?B?VDRkTmhyZVFHN011S3ZXQksyREt2ZlRYUk11WWhnQ2FOTjJaaTkrUGd3UTB2?=
 =?utf-8?B?TDFIM3Q5R1l4OG56d0N3ZkY2bFp5c1g5SEVHY0Q1YURyM09kMllVM0dlTUNE?=
 =?utf-8?B?eDV1WDJWT2E0Wmk3c1hTdTE0UGtzdUU0OGtnWEtrejNQdkhyeThZOVRSbDlT?=
 =?utf-8?B?OWVIUDZDWU5OUVZoTnlkaWpuSVIvU2xVU2ovZThsc3pVaVE3djRMTlZ4a25o?=
 =?utf-8?B?NitzbjRqN0xEWFMwbEcwV1lVbTVBRnQrVjc1dEcwN1VtZmZYSHNMMHB4T3Vn?=
 =?utf-8?Q?GnnLJp2oh95a8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95c4754a-1c23-463a-b25d-08daf25e36a9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5117.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 16:26:08.6940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k4cUq5blsHT8lA2+id5Yjx2F2g826UhrZDHnAJnsTVjAwvVufntkq9AdilPJt7Mww/rHN+vAmhkVIy3+gbfH1pqofsnanEXJ0VYQ2juM948=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5032
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-09_10,2023-01-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 adultscore=0 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301090118
X-Proofpoint-GUID: TIqrU2V9GmPsWQtIlLUOvDO19XZG93cI
X-Proofpoint-ORIG-GUID: TIqrU2V9GmPsWQtIlLUOvDO19XZG93cI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/6/23 6:54 PM, Mike Kravetz wrote:
> On 01/03/23 13:13, Sidhartha Kumar wrote:
>> Change alloc_huge_page_nodemask() to alloc_hugetlb_folio_nodemask() and
>> alloc_migrate_huge_page() to alloc_migrate_hugetlb_folio(). Both functions
>> now return a folio rather than a page.
> 
>>   /* mempolicy aware migration callback */
>> @@ -2357,16 +2357,16 @@ struct page *alloc_huge_page_vma(struct hstate *h, struct vm_area_struct *vma,
>>   {
>>   	struct mempolicy *mpol;
>>   	nodemask_t *nodemask;
>> -	struct page *page;
>> +	struct folio *folio;
>>   	gfp_t gfp_mask;
>>   	int node;
>>   
>>   	gfp_mask = htlb_alloc_mask(h);
>>   	node = huge_node(vma, address, gfp_mask, &mpol, &nodemask);
>> -	page = alloc_huge_page_nodemask(h, node, nodemask, gfp_mask);
>> +	folio = alloc_hugetlb_folio_nodemask(h, node, nodemask, gfp_mask);
>>   	mpol_cond_put(mpol);
>>   
>> -	return page;
>> +	return &folio->page;
> 
> Is it possible that folio could be NULL here and cause addressing exception?
> 
>> diff --git a/mm/migrate.c b/mm/migrate.c
>> index 6932b3d5a9dd..fab706b78be1 100644
>> --- a/mm/migrate.c
>> +++ b/mm/migrate.c
>> @@ -1622,6 +1622,7 @@ struct page *alloc_migration_target(struct page *page, unsigned long private)
>>   	struct migration_target_control *mtc;
>>   	gfp_t gfp_mask;
>>   	unsigned int order = 0;
>> +	struct folio *hugetlb_folio = NULL;
>>   	struct folio *new_folio = NULL;
>>   	int nid;
>>   	int zidx;
>> @@ -1636,7 +1637,9 @@ struct page *alloc_migration_target(struct page *page, unsigned long private)
>>   		struct hstate *h = folio_hstate(folio);
>>   
>>   		gfp_mask = htlb_modify_alloc_mask(h, gfp_mask);
>> -		return alloc_huge_page_nodemask(h, nid, mtc->nmask, gfp_mask);
>> +		hugetlb_folio = alloc_hugetlb_folio_nodemask(h, nid,
>> +						mtc->nmask, gfp_mask);
>> +		return &hugetlb_folio->page;
> 
> and, here as well?

Hi Mike,

It is possible that the folio could be null but I believe these 
instances would not cause an addressing exception because as described 
in [1], &folio->page is safe even if the folio is NULL as the page 
offset is at 0.


[1] https://lore.kernel.org/lkml/Y7h4jsv6jl0XSIsk@casper.infradead.org/T/