Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0b711878-71b0-4a4b-4f0b-af157d6cac42@oracle.com>
Date:   Mon, 9 Jan 2023 10:36:44 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH mm-unstable 8/8] mm/hugetlb: convert demote_free_huge_page
 to folios
Content-Language: en-US
To:     Mike Kravetz <mike.kravetz@oracle.com>,
        Matthew Wilcox <willy@infradead.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        tsahu@linux.ibm.com, jhubbard@nvidia.com
References: <20230103191340.116536-1-sidhartha.kumar@oracle.com>
 <20230103191340.116536-9-sidhartha.kumar@oracle.com>
 <Y7jGyH9Atv3sPjcZ@monkey> <Y7jLVJ9kvBFCUhNd@casper.infradead.org>
 <Y7ncSXYzCmjzmS87@monkey>
From:   Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <Y7ncSXYzCmjzmS87@monkey>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDFRYjdGOU41amQ1M2VmbktvTTR4SktHV1J3L0wvdGdnK2R1aFo3MC9HWEF4?=
 =?utf-8?B?ai93OTduL0ZZQ21YVHBQU1QzaU16aUhvWjg2NUF1dnZ5c3ErU1FwMXJ3dU83?=
 =?utf-8?B?RldFZ1ZtODdzVDRuSno3ZFJlOTNzK2lJRzhsUGloenMwUlRISXVnQXg1c0I2?=
 =?utf-8?B?TCtBV1Rpdm1zK2NmdllYRG1ybXJOOTlJSHRVZGFCaDEveEY3QW1ZbDEvNDZv?=
 =?utf-8?B?MW0xb09DVUR5Tkd1UmhOUkoxT0EzZjk0blNxUFN2WFBVTE5od2paM200T0dk?=
 =?utf-8?B?QmRCaktHbWFqRHoxcmxUdjBtNjlBWTNJWGVabFlWRldkeFJMSE9ldmNFcWR0?=
 =?utf-8?B?N3QyNmlQdjEzc2ptUE5xNVcybDJIbXA0Tyt5YjVhUFdGOTlUeUlwY2djR25Z?=
 =?utf-8?B?cndJbGl1RnZ6Wng5SkRkUURiRDJLKy9taW05aXhJOTZ5RnVvTnBuRXZTaFJY?=
 =?utf-8?B?ZlBGWEZQbnJWbWtKdlVzOVhHY3JWaG9aVUszdzA5eG0xQ3JkT1JOSCs1WUJG?=
 =?utf-8?B?bkJ6YXRQOCtveWRJUjVzY0xaRnR6TkNMQWpESTlWTEdlQ2ZoN2hvTnZiY1Ny?=
 =?utf-8?B?R0xOR1owKzNFWXBwajdmcCtaL0h2MmIwNTdSbThJZ3lGOEZMWGNqNGNMcjZV?=
 =?utf-8?B?OHlYbzJ2dEdSMFB0NXdocnhUNnQ0SWhPV0FlSWpWS1BkdTJPdzgyUTNIN2Fw?=
 =?utf-8?B?YjlVcmxKZlpLRUZEOEVOZm14YTlNTlF6YnN6ZjE2TWZaYWdybzlPYXlDbDhZ?=
 =?utf-8?B?aHg2eG1OUS9lckJ2TEdIU1hydC9HOFVxN3U5MnVBaW5XTEpua0RtWmJQaFlV?=
 =?utf-8?B?ZDRhRjhQVjZ0cVpvUzNMMHhKYUtlakpBQklBWjYzWkxDOHRXYWR1cUlXVDZL?=
 =?utf-8?B?NThyM3B3S2phc2lMdnhyQzBETEZmZnpmajQzbkJXcGVNNStHQi90YlRkVHN4?=
 =?utf-8?B?SXFQaFBrbUY4dkJINmdEM3NJWHlCZS9SdWV2Y1l1eEkyem5oYnpQWGJ2MVJ3?=
 =?utf-8?B?dHdoTlNpM1hvY0VkNzlVQkVQVkZvN3l1UjRuNDdtQTZJai92TUNEY0JJbmNM?=
 =?utf-8?B?N2FkSTFqa1lYQmRMbWJEa1o5dW5TYVR0Ylphb0h3VDJzMmdTWlo1MXRDcDZu?=
 =?utf-8?B?WlJ2WFZpVmpGVW5rNjNjSG1ZSWNXUVJGdDlZTlNreHh5VlkxNkdzTm11UFF5?=
 =?utf-8?B?Sm1nWHpIaGNOQW9PL0lqazMwTThoRFFXWGdkVW1pWmNUaU9QSUlNckRsMW1D?=
 =?utf-8?B?UjhFUzJXRUJ2djVsLytoMERHbTBsVkhDckgvamlkalFzd3dROUo3TzRCWkFR?=
 =?utf-8?B?YVI0cmdJUTB1UjE0MURlQW1SeHphdVRUbU4vN3dzQkpZbHZ4UFlmTVlKKzgr?=
 =?utf-8?B?RHFxQ1ZORmp2QnRNV2dTOHVvRUtpS0lvbmQzdE5Ib2NtZ2JISzFWVktUOHVL?=
 =?utf-8?B?QzA3eUpGa1pVMlV3SGM5cVZaM3phbHdNSXFQK291emRsQlJCN1pObCtUMUxU?=
 =?utf-8?B?M2htdFJtSVRicStBZmtJM1hWUWVWaTFrZVlsZjNKVzZlaWs1UEkxaElhaXNZ?=
 =?utf-8?B?VXBRaUpiU1ljbnB0aCttc21oSG50eVlCT0tKd1ZwMmVQNlBNYlVHbWdaeHJy?=
 =?utf-8?B?c3VMOEhFN2xGelo4Y1VBMWhOZnYwYzJidXU2UnE5LzZZMzlldzJJZDdZK2V5?=
 =?utf-8?B?cjRaSEdTRHhPcVRKcTBXeWJ1R29kVm1QRGpFclNiZitZanlHaGtzNnNLdVhF?=
 =?utf-8?B?clJOUEJDM3JVSDJGb1hKbTd4Tmg4bUtqcUhGcFZYY1B1RzZHbjMyeEtDV1BN?=
 =?utf-8?B?UVdVNWdkNVd1ancxVlZ6NlEwa0RnK1RrbUI3SUttdUxKVXErbGhHT2VVUXlI?=
 =?utf-8?B?OFduUHUrZ0xYdkl4T0IxZnUzMlRWMjBHMjFaRzZEejlxL1A3YXhGbXcwemZj?=
 =?utf-8?B?L3BmUG5EZVA5WVVuZTlLRnIrN1BRUnd0eDB5RzlXVVlDYjhVcVRSK3B4WEtl?=
 =?utf-8?B?c0tGS2NjV2FIZi93TzUrNmZ6SlBmdnI1b1J6cSt5Z0VycTRTY0ZTeWZDMkxV?=
 =?utf-8?B?aklza0RTY3AzMXIxa0cvckdSaWQrUjdRSHBlU2dUU0RvSTZaeGdVZDRMblEy?=
 =?utf-8?B?TlBCdWpuSVdRQm5LTHduV0M5VGNEdTYxdTBRYmhReXQ3NE1uMWMwZDd3UmZK?=
 =?utf-8?B?N1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UmlORWpmUUZVc3h1Y1paaHZhWW9hZG50QVkvUndrdFQyVGlUenp0c3NIL1RY?=
 =?utf-8?B?cVNtMjNDVEJmTjZLNlplbHVGZmZYVnlFWk50MDNBVkZhQzdsSzV1UFE5WkZJ?=
 =?utf-8?B?WS9qbTBNTW44OS9iWVJuZnd1ZFV0aDlIWEE4dG5aOVZiTCs3TDZ4VmhidmlD?=
 =?utf-8?B?a2pXOGhOcUVkZllRc0lQanZmY1BTNFBXZHJEZDZodjBRdTRSQXZ2a2JVTUk1?=
 =?utf-8?B?RFoyRDA2bWw4bm12b25uYlBjRmlvYjlRMVlIWWMraTQwVEVnOHErMHRiUytT?=
 =?utf-8?B?RTd4Znl1TjI2cktMeWRKL0FDTnJtNmowRE1JdFZJTDJCOXFtaGIyS3dpc3Bw?=
 =?utf-8?B?MHM2TFpDRitBL2NzRUNPcFl6Y3Yyc0VXbzViSkV0U0dNNUhFYzhjWFNtOG8x?=
 =?utf-8?B?Yk55QW0zR29ROFU1MXFQMm5UNjlYNjVHanNwZUVUSEIzT2hOQ0lDVS9YWVlh?=
 =?utf-8?B?OHZqWjhsbzc2MWdvRG9UeStTSGszbG5hdUN3Tmc5bk9lOTY3U2Z2dEZPMmpx?=
 =?utf-8?B?RHBSckY3clBNQ3YxejJGUytxZnJ5WmU5dDlsSTNjNTVuYlhIN2Q1RnQ4MWNu?=
 =?utf-8?B?UHYxczRaa3lCNFExK0tXZ3M2azZXS2xlL2Q4Z252RlNaVkk1YnkvRVpSb1Iw?=
 =?utf-8?B?dXBtK0crYUNOUzdLQzFXN3ZKS0pDdTJtemVsTnVNT29UTzF3OE1JYU1vQys1?=
 =?utf-8?B?VkVzQmJTYy9RdW5GdzBBcnk4bldwUGtZVFE5V09rTEpZVThZU0tLOTZPb2o1?=
 =?utf-8?B?dWRIdnIxV2hpSGl2ZDIxQjBzSGM5K1FMMmd5T0REUlJwSVR1SWplcEpybXIx?=
 =?utf-8?B?TTNIaVV6Qm9qckNVdGppbitqZ29ldjVnS1NLZGRRbjNCbkhPQ2tCRW5ENHBo?=
 =?utf-8?B?TEtRcllFSVdjYWdrV3YwVmNxSjJFbHU5c0VHV0hCUnRuTHFVRGtoY2JIRHkw?=
 =?utf-8?B?RStpeEtxVzJveS9SeUp2a01ZRWJBYU8xNW1HUW1sU3BPNjlydC9odkdQbE5q?=
 =?utf-8?B?UmRxRkZ1YTNoRUZKRTdRM1JnMUNLT1ExNVIwcmI1a0VQb3dBeDBFSmhBMXZZ?=
 =?utf-8?B?ZFdUbnZhNzZkRkgvY1ZiVmJoMkM0T29FcUt3dDJkMDViSWlwTlY3bEdiTjJ1?=
 =?utf-8?B?bVc4NGFKYUMyWHRyWlcyenRodUptMnQzdi8yL2tQWlRRN3gwZU9FU0ZocTVl?=
 =?utf-8?B?N0IzZzR1V1NlRVI4ZWUvYlpnc0RkSDZjN2lwOFpsUlBCb2RKMUYySG9iVWU5?=
 =?utf-8?B?K0lndkRqTlNyUFdFT0xtd2RYckQxQnVkY3hsZlZYN09zNkVXMkh2OEVzTDdX?=
 =?utf-8?Q?bNCVrdGHYjVbo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a628666e-e80d-4d63-3745-08daf25fb2ad
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5117.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 16:36:46.4387
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jMmGXYFI7AGAoajYmr/lLmY8JtmlultG0uTDeR/TlFoFiAvPyhHhI77HOMirS2ennVcp7sS2yTkhm99s8WaGsafK1ijAwf7YKRAZk+J//Jk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6122
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-09_10,2023-01-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301090119
X-Proofpoint-GUID: RS0Nr8LZ_q5GIsHEbKl_Wca0Ny04ONQW
X-Proofpoint-ORIG-GUID: RS0Nr8LZ_q5GIsHEbKl_Wca0Ny04ONQW
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/7/23 2:55 PM, Mike Kravetz wrote:
> On 01/07/23 01:31, Matthew Wilcox wrote:
>> On Fri, Jan 06, 2023 at 05:11:36PM -0800, Mike Kravetz wrote:
>>> On 01/03/23 13:13, Sidhartha Kumar wrote:
>>>> @@ -3477,15 +3477,15 @@ static int demote_free_huge_page(struct hstate *h, struct page *page)
>>>>   	mutex_lock(&target_hstate->resize_lock);
>>>>   	for (i = 0; i < pages_per_huge_page(h);
>>>>   				i += pages_per_huge_page(target_hstate)) {
>>>> -		subpage = nth_page(page, i);
>>>> -		folio = page_folio(subpage);
>>>> +		subpage = folio_page(folio, i);
>>>> +		subfolio = page_folio(subpage);
>>>
>>> No problems with the code, but I am not in love with the name subfolio.
>>> I know it is patterned after 'subpage'.  For better or worse, the term
>>> subpage is used throughout the kernel.  This would be the first usage of
>>> the term 'subfolio'.
>>>
>>> Matthew do you have any comments on the naming?  It is local to hugetlb,
>>> but I would hate to see use of the term subfolio based on its introduction
>>> here.
>>
>> I'm really not a fan of it either.  I intended to dive into this patch
>> and understand the function it's modifying, in the hopes of suggesting
>> a better name and/or method.
> 
> At a high level, this routine is splitting a very large folio (1G for
> example) into multiple large folios of a smaller size (512 2M folios for
> example).  The loop is iterating through the very large folio at
> increments of the smaller large folio.  subfolio (previously subpage) is
> used to point to the smaller large folio within the loop.
> 
If folio does not need to be part of the variable name, how about 
something like 'demote_target'? The prep call inside the loop would then 
look like:

prep_new_hugetlb_folio(target_hstate, demote_target, nid);

so it is still clear that demote_target is a folio. A more concise 
version could also be 'demote_dst' but that seems more ambiguous than 
target.

Thanks,
Sidhartha Kumar