Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6600956rwl; Mon, 9 Jan 2023 10:22:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXvnVCeKpRMWgUDBf2SwoW2B17RG+7fb8qv6uD/WNF1Yp2kwlvKipzycyunjRXC2+2nsReW9 X-Received: by 2002:a05:6a21:9011:b0:b5:f6de:e299 with SMTP id tq17-20020a056a21901100b000b5f6dee299mr2058643pzb.35.1673288529067; Mon, 09 Jan 2023 10:22:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673288529; cv=none; d=google.com; s=arc-20160816; b=pXqBZsxbc+QJB8KYHPHJo9G5joedGsVerSrsKDl1eSy8z3FPrP17gJ11MRA6Jql+BI OhYdDk1VMWHOMSFozjVt1GxsB6wssLHWB43TY64vbMzpekbPXI9krqGJ9YFQf6L8s/pv pIfrL9lzzGExXoVqskcNoLTUSi0JGXYWyhYHeSRK04aG8uSaO89frZpV3U0BaYG3BRfY aSjEK7bvQf6oGoe0RTr9UJVFFqKYX65XGAmCVulujR7BEE43Yp11K0Z1UZ0kQvDR9wfL +weInV18GvrDtMWpdzA0JHvdgPPq+5ikuHuT5I3Xe6FkRTutGaIPhAlasZRgLoqkxQWI vrxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DVqtyBgR9RFo+4MqU266YSmw7nsc/65OUVDIpRwU9Dg=; b=nVm/mDeIoo6vrRVgSeusWcn90V85oFf3A6s+czp1DEAq6PT+BAXX9+RNIXuyBhltFl +Xn4IwrQc8pZtwEfQ3vZmkVC6jYlnUmAvFq+VYi7MQ2rKjBOu7bM9PJ3FMGhHeuhi0NN bH0W8iK3vEY2+6BDXCpLv5JTV9Fx/tn4P5yDOB/g1KJo+/+2gFIFyzudB7tgYPG+eNor hY6goBcvO7+GkNm9Ra0qOt1p3RI1gOEHeuJ9fckm5GaANVIb0cIKiTJh8zxLlTnS1Ivt SqC4QjkHA2w3a4Snlv7QJNBusImwdL2P3AyzGTrOnEahVMAnCldPm0j01UoqwR+iC2vZ qSDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=IwYGbeiG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q71-20020a632a4a000000b00476d95c5b54si10169998pgq.431.2023.01.09.10.22.02; Mon, 09 Jan 2023 10:22:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=IwYGbeiG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229618AbjAISJn (ORCPT + 55 others); Mon, 9 Jan 2023 13:09:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237714AbjAISIl (ORCPT ); Mon, 9 Jan 2023 13:08:41 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76E9044343; Mon, 9 Jan 2023 10:07:35 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 163191EC0104; Mon, 9 Jan 2023 19:07:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1673287654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=DVqtyBgR9RFo+4MqU266YSmw7nsc/65OUVDIpRwU9Dg=; b=IwYGbeiG0aCrE+oxXKqlH/ao29gV72tCEMgCId+NDTNvljeLDPCoPtM46/HFmskCJXBat1 jQACmnKk4lJ9UXUthjKUzm0jtsMBjpiRX+3STVWMpad1tLFjyGW/F/1Zp/5cfUonD2VyOz f6GUwmjNgJ6YX1XJTFBLrij/lqoTxps= Date: Mon, 9 Jan 2023 19:07:33 +0100 From: Borislav Petkov To: "Michael Kelley (LINUX)" Cc: "hpa@zytor.com" , KY Srinivasan , Haiyang Zhang , "wei.liu@kernel.org" , Dexuan Cui , "luto@kernel.org" , "peterz@infradead.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "lpieralisi@kernel.org" , "robh@kernel.org" , "kw@linux.com" , "bhelgaas@google.com" , "arnd@arndb.de" , "hch@infradead.org" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "thomas.lendacky@amd.com" , "brijesh.singh@amd.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , Tianyu Lan , "kirill.shutemov@linux.intel.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "ak@linux.intel.com" , "isaku.yamahata@intel.com" , "dan.j.williams@intel.com" , "jane.chu@oracle.com" , "seanjc@google.com" , "tony.luck@intel.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-arch@vger.kernel.org" , "iommu@lists.linux.dev" Subject: Re: [Patch v4 06/13] x86/hyperv: Change vTOM handling to use standard coco mechanisms Message-ID: References: <1669951831-4180-1-git-send-email-mikelley@microsoft.com> <1669951831-4180-7-git-send-email-mikelley@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2023 at 05:37:00PM +0000, Michael Kelley (LINUX) wrote: > OK. I have no objection to putting that code in a separate "helper" > function. The only slight messiness is that the helper function must > be separately wrapped in #ifdef CONFIG_AMD_MEM_ENCRYPT, or > marked __maybe_unused. I'd vote for __maybe_unused as that doesn't mean more ifdeffery. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette