Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6610632rwl; Mon, 9 Jan 2023 10:30:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXuhotvmxSWE6yaHIUFD8qBKUz5Ke9/vyNuaVMQSIQyyyR8fRg2PYodA+cgzQ37EHNJ9Fqhv X-Received: by 2002:a05:6a20:6709:b0:af:aa38:12e0 with SMTP id q9-20020a056a20670900b000afaa3812e0mr67808570pzh.34.1673289020562; Mon, 09 Jan 2023 10:30:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673289020; cv=none; d=google.com; s=arc-20160816; b=oU3xlTze0WLRH3D5ZEe0AwKemaW15EaMHBPrpDm9tPAJAqUziT7ce155UmGuEpo63/ qTDK3KRoqDuNrhGU2WcEqZIEYVoUv9t2uvDHL8lIF1jngDaOPDt6hbvJdAXukpcqJdQl H38n2s5yrNozKV/9Ht1Xher6KhLYmysfo90RGxK8eoVIuNYCNLq1LPO2nXxr9JED+Noc jd4LljaGleWt1e/nN0b0DyklcWHOcHofcHIc2N2MRcvRmZoN8lt9roXuGz9QQbIgGWpu VCkf23NSPUX7/MTWQxZo2f7hgJ3EduG9ZrQaGd+8q1EUawNedeyeuvAym95T+Nhheenn FoBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=lxJjwAHOg//xb6PbC9w5H5bNI0FxRe+sZG7E5JEhIxELjq5eoSckduCrghonCNqnCE 0HW/6zr+kq3TN/YTlUPBdegDnOL4r6UX+okQqBxkGdlErzU8nGc3Qdg1Vy/qsMBct4he X/p/MQQxwQA3kCmouzC2jwIxBsyNMSFsEmEZsT1YGb6RtfqlEeAKAgwkCXorFmMVpECx 9LoG1FgckdPCmFd78f0G4DYLJbQ/qbYcE0+f00TUZ8ZM2zz46gTnQoPIjB8RR46zuy6J xkiYzi74w4HFCEW0Oxxoen0a3gbm9qHc+5xwAQPBsFJwaFk7gFPIKvDEIk95eutHvvcI fImw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa2 header.b=xr+iUWmf; dkim=neutral (no key) header.i=@ravnborg.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k70-20020a638449000000b004abb6ff4e70si9321352pgd.378.2023.01.09.10.30.13; Mon, 09 Jan 2023 10:30:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa2 header.b=xr+iUWmf; dkim=neutral (no key) header.i=@ravnborg.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229979AbjAISXM (ORCPT + 55 others); Mon, 9 Jan 2023 13:23:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237482AbjAISWm (ORCPT ); Mon, 9 Jan 2023 13:22:42 -0500 Received: from mailrelay4-1.pub.mailoutpod2-cph3.one.com (mailrelay4-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:403::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43801765A for ; Mon, 9 Jan 2023 10:21:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=xr+iUWmfOB1CLBr6Qsy2YZMDRotm12WBZ/zh+3qIGnqD+WW38gq16Rl6LS9taWAIgXP2llv2ueyF0 fA3iIIxYnmuPGkwiK+SGk3l7yHRvIxggcTtT7x2q0+wwF6fVIQkEzPtcW04Q4A6X4SKS9m56vo7D0o hLzfG7GraTS31Ch8FAtoGue7T76SmYvTnNeZNZkj0/5oK6YNNivj7Wo0ExtjbmvCmHRBteAPdkj/Eg NkDkGI6lGIPAVh39LbMkR8Ej5M2GsnANIVRaeRashpzz54gdLod6v1ri7V6JrPjvdhVHIVaCwftjs+ 2rttIhFTMoveJDSDeM23dX3GpjUJUVw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=nxcQ2DNweooGl9o3PknXxmGKMXudrM7A8yocezPtlLEgBpQEu7WtSwjxUTWj2HhN7+D5H3vtKKz4P oB6b4GmAA== X-HalOne-ID: 5e23647e-904a-11ed-85ce-87783a957ad9 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay4 (Halon) with ESMTPSA id 5e23647e-904a-11ed-85ce-87783a957ad9; Mon, 09 Jan 2023 18:21:02 +0000 (UTC) Date: Mon, 9 Jan 2023 19:21:00 +0100 From: Sam Ravnborg To: Christophe Leroy Cc: Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han , "linux-fbdev@vger.kernel.org" , Stephen Kitt , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Jani Nikula , "linux-staging@lists.linux.dev" , Maarten Lankhorst , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Jason Yan , Souptick Joarder , Daniel Vetter , "linux-omap@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness() Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-2-1bd9bafb351f@ravnborg.org> <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe, On Mon, Jan 09, 2023 at 05:44:46PM +0000, Christophe Leroy wrote: > > > Le 07/01/2023 ? 19:26, Sam Ravnborg via B4 Submission Endpoint a ?crit?: > > From: Sam Ravnborg > > > > Introduce backlight_get_brightness() to simplify logic > > and avoid direct access to backlight properties. > > When I read 'introduce' I understand that you are adding a new function. > > In fact backlight_get_brightness() already exists, so maybe replace > 'introduce' by 'use' Thanks for your feedback. A similar patch is already applied to the fbdev tree, so this patch can be ignored. Sam