Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Ira Weiny <ira.weiny@intel.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Alexander Potapenko <glider@google.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Tony Luck <tony.luck@intel.com>, linux-kernel@vger.kernel.org,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Fix two spelling mistakes in highmem.h
Date:   Mon, 09 Jan 2023 19:09:46 +0100
Message-ID: <2269967.ElGaqSPkdT@suse>
In-Reply-To: <Y7cCprZBVrNO3aZ9@iweiny-desk3>
References: <20230105121305.30714-1-fmdefrancesco@gmail.com>
 <Y7cCprZBVrNO3aZ9@iweiny-desk3>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On gioved=EC 5 gennaio 2023 18:02:30 CET Ira Weiny wrote:
> On Thu, Jan 05, 2023 at 01:13:05PM +0100, Fabio M. De Francesco wrote:
> > Substitute two occurrences of "higmem" with "highmem" in highmem.h.
>=20
> The change looks fine but for Andrew's benefit I believe this patch is ba=
sed
> on the other one you submitted to fix kmap_local_folio()?[1]  Is that
> correct?

Yes, it is.=20
I had completely forgotten that previous patch.
Thanks for noticing it and for providing its link to Andrew.

=46abio

>=20
> [1]
> https://lore.kernel.org/all/20230105120424.30055-1-fmdefrancesco@gmail.co=
m/
>=20
> With that note:
>=20
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>=20
> > Suggested-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> >=20
> >  include/linux/highmem.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> > index 7b0085a61e67..ae1670ccdf45 100644
> > --- a/include/linux/highmem.h
> > +++ b/include/linux/highmem.h
> > @@ -86,7 +86,7 @@ static inline void kmap_flush_unused(void);
> >=20
> >   * virtual address of the direct mapping. Only real highmem pages are
> >   * temporarily mapped.
> >   *
> >=20
> > - * While it is significantly faster than kmap() for the higmem case it
> > + * While it is significantly faster than kmap() for the highmem case it
> >=20
> >   * comes with restrictions about the pointer validity.
> >   *
> >   * On HIGHMEM enabled systems mapping a highmem page has the side effe=
ct=20
of
> >=20
> > @@ -119,7 +119,7 @@ static inline void *kmap_local_page(struct page=20
*page);
> >=20
> >   * virtual address of the direct mapping. Only real highmem pages are
> >   * temporarily mapped.
> >   *
> >=20
> > - * While it is significantly faster than kmap() for the higmem case it
> > + * While it is significantly faster than kmap() for the highmem case it
> >=20
> >   * comes with restrictions about the pointer validity.
> >   *
> >   * On HIGHMEM enabled systems mapping a highmem page has the side effe=
ct=20
of
> >=20
> > --
> > 2.39.0