Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8349cf5f-1e26-f605-4404-978dbef9cee3@amd.com>
Date:   Mon, 9 Jan 2023 12:21:50 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RFC] Sound support for Huawei line of AMD laptops using ACP and
 ES8336 codec
To:     "Reddy, V sujith kumar" <vsujithkumar.reddy@amd.com>,
        Marian Postevca <posteuca@mutex.one>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        syed sabakareem <Syed.SabaKareem@amd.com>
References: <871qo7fqjp.fsf@mutex.one>
 <598ca0a8-8aef-a030-7060-f76ba4700bbf@amd.com>
Content-Language: en-US
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <598ca0a8-8aef-a030-7060-f76ba4700bbf@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkpGT2Y0Tkp2b04vbUsySG1OY0xpVW9ZNXlwRGVzd3pCZnZxc3FlVXl5RU1W?=
 =?utf-8?B?c25kTnpCK1pJdEF2V1ZqMTFXcWRFVEp4ZlZxSmhHUDRSbWF5NXFoUHAwNklh?=
 =?utf-8?B?a3NNSVdsd3RPdlFtdTQwYTN0cWZSUUdDTjJqNEFpcGV1OUhETFNpUmp1bE45?=
 =?utf-8?B?R3gyQTlTd3FmbVdDZlI2aThvY3JnaWdLc0tieVlIQUxXaW4rZmUzU0dCckdN?=
 =?utf-8?B?TG05UkJBbUI5UThPeTcwV0dlckVDYStQTzBLRzVMN0FOcFNZVE9PSHl0Rk9l?=
 =?utf-8?B?b2FhcW9IN0VlQ3UvS0wxcmxxdmdOWDV4NHVlcFNnaDlHZXBTL3R5R2g0bmFw?=
 =?utf-8?B?dXJzckI3VGNZS1M0ZWRONjhEek82ZEV0bm9CRGFueisyUCtWWHFPL3ZtU2Z3?=
 =?utf-8?B?bXpUTmJ6bDFRUksyQ0FZTzEzY1JtTEVCblBCM2U0V2RVb2FLRjFLa0d1L0pB?=
 =?utf-8?B?Vkx2Z0p5OG5IQnRZMGJxYVlpVGlROGU2aElDeXJWQmUyNFo2UU1ZOUZRU0t2?=
 =?utf-8?B?Z1lKMEtTdHJiTDNCYzkyRGJqcmluU0R0MktzRktxNStEQ0NKSXYrM1B3RVdh?=
 =?utf-8?B?d0doRDFNV3lUS0hwRmlHaEtETnVNcW9hRm5lRWlXRnViUXNTUjJZSlIzcXUz?=
 =?utf-8?B?a0dyaGpsZVVwaW5xZENZY3lsMU5lWVUraDlZUC9EeUZWa0hqUzBId20rQTVn?=
 =?utf-8?B?eWF2QUZFNEU3eXh5MXU0QzBxNnAwS2ZWOGJRc29rQUhoWUxSU0JkVmExWi83?=
 =?utf-8?B?amVncnkrU0UxMlhKOFBSaE9BbHVZeDRxRnpZWHIrYjhPVkFibG9LYmJISnk5?=
 =?utf-8?B?L01DVnIxV2QzVldxQ21lM1FmVHNQSGM5bDluN3d4amtSQjZWSWlOV21jUVhi?=
 =?utf-8?B?REpQMGdsUGJWeElFVGNKVDZvaFk4dHRqbTNWUWpsamhFRE5yRklIUUJ4dlB3?=
 =?utf-8?B?WWFtbXNBY3RsMlhsTGk4MURIOXE4Q0NEcGRydXZEUDBjdXlpU1JuWHFjZDlq?=
 =?utf-8?B?eC81YkVTaWpJZkpNY3lHMTdDOXBlR21xbE10cVZWMkt1TGpwb2ozUExFbHd5?=
 =?utf-8?B?WDYzVERXMlhOWTJ0WUg1emFkak5BMW95bHhraUpMWGE5YVpZTS9OU1FaRHBy?=
 =?utf-8?B?WGkvbnE1SlVBUS9GUEFSdjJIdE5ndC9mUVlvSUFNc09YUHArQWhlM2lJQTFT?=
 =?utf-8?B?SEc1dkREbjlCMU9OYXQvdFMycUNPZnlYNDZ1VnNBMkI5cFJoNmtjUEVjcFJn?=
 =?utf-8?B?SEwrUzdtb0dsVzVwOHdLaWNicWJUcGxnNTRuNVhJWm1MUlJvS1BGTlZRRkxo?=
 =?utf-8?B?ZjNvUnVaVkRrK2kvanBxMkVqUkhYQU0wYVNoVDFLVFV0UFcweWhqWlpORTVt?=
 =?utf-8?B?T1l6NVM4U042WGVYUVQzU1FjV05BOC9yWUloaExtT1NWbTlpSFZQM0hBTEFk?=
 =?utf-8?B?RkxQeFhadzBZT3luT1JCNmZsb0NOdUxZNVhEa25MQmZ3YlVRYmdYbnFSdi9M?=
 =?utf-8?B?RUlaaXNDV3JIb0E5TmFMTzV3ZUJzTjNrUTNNTi9xSVQxZHYzNWJHTit6emRW?=
 =?utf-8?B?RmdZd0tGNFJwMkJPMlpjNE5BYWpTSW9DYkpjVXdlanlwYWFzU0FhK3FrWStm?=
 =?utf-8?B?ejBvV1Y0THN4QXc4RnF1dUlYM05uL2FnWUFndktCN0Mxbk0zcE1GMDRaZE84?=
 =?utf-8?B?NkNuZ2dUSWNWVE5JdUVLMnZ4T2ZqUFJibVcwSmNVNEQyYVdLc003ck5XVEcx?=
 =?utf-8?B?WTlneXlNZUtvVHNMSlhWWENMRkpiQ2V2REI2RXF6eWpHQ0tpdEk2OFZPTkRM?=
 =?utf-8?B?L3JyOVI3R0psdnZzUHl1VVR2S1NIdElpcWhacFN1M1N2YXBYbEFrQ1hqZjY0?=
 =?utf-8?B?Z1BibUVqRC8rMllDVTVjK1pJaUNFaFQ5dmZrYW9kanAwMXM1MWZualVnOVVl?=
 =?utf-8?B?Z244L0ZUdzFHRk1PbnlTT2wzU2tFWlRhSlRHcE5hNklHVGlMRG0rWkFyV1Fq?=
 =?utf-8?B?ZWJJRld6ZjB0bFptMXVMRHVxckpRYTZiOWN6dlp2eUNMY3lYNHpNbTI5c253?=
 =?utf-8?B?Ym9URkhBU0RjRTFQbHJ0SVpSUjVJL2p3ZHgyb2Joc3g0MmpLbWpNRUtJY1BX?=
 =?utf-8?Q?W7LqtZQfseb/SjHDaQKg0xEb9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44f0a64b-0c23-4cab-05bc-08daf26e61d1
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 18:21:52.9321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4dhLi+bRMrQXqVHQu3V4dC0fzLGyDQ+O5hG5Vy/VLofhClQw31nHTR1L6czV3W/vZrgmPghRyfF85GABFObzgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7738
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/7/2023 00:58, Reddy, V sujith kumar wrote:
> Hi Marian,
> 
> Thanks for the query.
> 
> On 1/7/2023 12:17 AM, Marian Postevca wrote:
>> I have a Huawei Matebook 14 AMD 2021 laptop for which the sound isn't
>> supported on Linux. On further investigation in Windows and ACPI tables
>> I could determine that this particular SKU has an ES8336 codec connected
>> to the CPU ACP module.
>> The CPU of my laptop is an AMD Ryzen 5 5500U which seems to be codenamed
>> Lucienne and is a derivation of the Renoir family.
>> Acording to lspci the ACP is revision 1:
>>
>> 03:00.5 Multimedia controller [0480]: Advanced Micro Devices, Inc. [AMD] Raven/Raven2/FireFlight/Renoir Audio Processor [1022:15e2] (rev 01)
>> 	Subsystem: Device [1e83:3e4d]
>> 	Kernel driver in use: snd_rn_pci_acp3x
>> 	Kernel modules: snd_pci_acp3x, snd_rn_pci_acp3x, snd_pci_acp5x,
>> 	snd_pci_acp6x, snd_acp_pci, snd_rpl_pci_acp6x,
>> 	snd_sof_amd_renoir
>>
>> I have written a machine driver for this platform and managed to make
>> the sound and internal microphone work. I am looking to integrate this
>> support but there are some issues with the current implementation of ACP
>> support.
>>
>> As far as I can tell there are 4 directions I could take to add support:
>>
>> 1. A standalone machine driver in sound/soc/amd that uses the platform
>>    drivers from sound/soc/amd/raven/
>>
>> 2. An embedded driver in sound/soc/amd/acp/acp-legacy-mach.c
>>
>> 3. A standalone machine driver in sound/soc/amd that uses the platform
>>    drivers from sound/soc/amd/renoir
>>
>> 4. Use the SOF infrastructure
>>
>> Now as far as I can tell, all of these directions have issues:
>>
>> 1. The pci driver from sound/soc/amd/raven/pci-acp3x.c doesn't support Lucienne
>>     since it blocks rev 1 devices in :
>>
>>     /* Raven device detection */
>>     if (pci->revision != 0x00)
>>         return -ENODEV;
>>
>>     This is the approach I took and just changed the check to add support
>>     for rev 1.
>>     The sound and internal microphone worked ok and I didn't encounter any
>>     issues with it. Of course I don't know the internals of ACP and
>>     don't know what are the differences between rev 0 and rev 1.
> 
> 
> Not recommended
> 
>> 2. This approach could work but I would need to change the structure
>>     acp_card_drvdata and struct snd_soc_dapm_widget acp_widgets,
>>     to add proper support for jack handling (and maybe some other
>>     modifications).
>>     This driver seems to support rev 1 (in sound/soc/amd/acp/acp-pci.c):
>>
>>     switch (pci->revision) {
>> 	case 0x01:
>> 		chip->name = "acp_asoc_renoir";
>> 		chip->acp_rev = ACP3X_DEV;
>> 		break;
>>
>>     Also from the module description it seems that these drivers are
>>     meant only for chromebook support.
> 
> 
> Recommended. Please add below code
> 
> 	{
> 		.flags  =  FLAG_AMD_LEGACY,
> 		.device  =  ACP_PCI_DEV_ID,
> 		.dmi_table  =  (const  struct  dmi_system_id  [])  {
> 			{
> 				.matches  =  {
> 					DMI_MATCH(DMI_SYS_VENDOR,  ""),///change accordingly DMI_MATCH(DMI_PRODUCT_NAME, ""),///change 
> accordingly
>   },
> 			},
> 
> 
> at 
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/sound/soc/amd/acp-config.c#n50
> 
> As you said add the   structure static struct acp_card_drvdata and also 
> add the required dai_link of codec.
> 
> 
> 
>> 3. This seems like it would the best approach in theory, but the problem
>>     is that the drivers inside only seem to add support for DMIC.
>>
>> 4. I tried to use SOF early when I started tinkering, but I always got a
>>     timeout during init phase when loading the renoir firmware.
> 
> Could you please send  the error, we will check and let you know what is 
> missing.

Just a guess here without seeing the error.  Is this perhaps because the 
SOF F/W binary that was loaded was not signed with signature trusted by 
the platform and the platform required validation?

SOF on AMD was first introduced for Chromebooks which don't use the same 
authority for firmware binary verification that general purpose UEFI 
notebooks would use.