Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6641465rwl; Mon, 9 Jan 2023 10:57:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXsvM3nEjmu+s3UHbHVZ6fnsfgs8nuDSeYr5zPZVPU+3328/yDkBWko72MnuciVGVzNOoQVB X-Received: by 2002:a17:907:86a6:b0:7c0:fd1a:79f0 with SMTP id qa38-20020a17090786a600b007c0fd1a79f0mr78953126ejc.21.1673290661345; Mon, 09 Jan 2023 10:57:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673290661; cv=none; d=google.com; s=arc-20160816; b=UEwexuw7Llb7GIvgjRGwle1BjIGkogwj196Qcjdym2Pu7jDKFUfw4lc3qsOxqGaZu2 JAUsrKufzNjOnwfwkNCATS5TmPqSEfbB7hAX9KQ85gFMO56o7lfT3VcodNPDYM6lcohN y9qDV8W65j6eEIBvLQJeRbG2X9pt6cvTgaf3fWtfdHKXzhBM88DFOzKXQ3fgmAgVP9FH 1y2L2TpPy78WbZL3WoXSocdfmRNeAB281u2IR7dTLW/1jZv0FYqCPpweyBbmBmE3YeLJ JUgxnfjWNEaDisLS2YWQAlyLfn+NlH6elqcl+hWFzqfaN2fpqVCFCAvA6AHO/H1GTavW PVMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4xbEUz+l7pEeC2bJ2Istz4CduYkgmHAwjtj7GDJFIrg=; b=WlkGB30dJQeq1ea/dAbyW2p41C6+6i1PtQRugMpeY3HmRUforAO/ceasAaQ6cSNM/8 dJTplF+q6q9AQZPKIqMKiIt7wYGDdHTVzvaEWQzTpD8KPJ1cNR8nCSyGiJwwTg01FNIS qrLcAuQWq6DnGw+JJVN4LTdVLemksAxcd1tj9yXLjXlW7TaboE7a9UshoYpmHdkWMM/r 4L00MnOgPzyUmDiDUcLcG9521JVEpEj6pp3s2RJlilENPJqAnO8fA7Bgvc39c+11dbVW f1eBFOjYNdBUyUxndHjBAwi6r9xUjwtoqUwyVZ1dQjSnbDhzOWJualeyKlDZhrJ20ODg OD9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=gGM5QTd4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id uk41-20020a170907ca2900b0084c439a1d98si7273263ejc.454.2023.01.09.10.57.28; Mon, 09 Jan 2023 10:57:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=gGM5QTd4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234251AbjAISrE (ORCPT + 53 others); Mon, 9 Jan 2023 13:47:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235098AbjAISrC (ORCPT ); Mon, 9 Jan 2023 13:47:02 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 215FA1901C for ; Mon, 9 Jan 2023 10:47:01 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id w3so10510559ply.3 for ; Mon, 09 Jan 2023 10:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=4xbEUz+l7pEeC2bJ2Istz4CduYkgmHAwjtj7GDJFIrg=; b=gGM5QTd4jsaM5390khMYrTyPZ9B3Wntx0R6uefG5ndPWO8XUfIV1OL70LiklWfJ1mc IvlUz1GiJlG18OEJElMO15xzxSJJ28n//rCrp52037rbP3CB0JDQ8ZuDIQPZO/5Yr+Xd OvtDJGY1dDoRuiATgBKm1kZkGPDSu0TG5F2BWGPEyz1zRlVciNhAxkpsHeP1VoVXaqQA kUiewP5qGEshcInL2Kyfbi4o1V+oJ0nPr50gNYUZcwVLPgXg8q7OMWPKxqT8sMpL0j+e PSNghOAzlC3GRa67MDOynZU1xwr5bauqJK31Dl2NyVWa0lg72RoiBZVSfowmsWyXjGlX lW3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4xbEUz+l7pEeC2bJ2Istz4CduYkgmHAwjtj7GDJFIrg=; b=AGH9DA7ZV9iKJKLQtuoE3RhbVliCZQEATyatQBL4T1IPKDED6WGztdT3G65r0ZwzF/ PshubZKLzQ+GYbKhgzBfIslp3ItxVIzjx7vAPxMbcBdWYNHlcBfwPjGGixI36hLZGwzb XLzUAiUQhGJo1+p8dfEniz8ErQWqgWUDAWdtVymPI33Zf0WT4tC0WcHiOybFinpS1VaW QT2OGCq+R985Wn22BGIf3Fd9JPk6X6wWSZngCB71ypRifteR7H5Bp7Mcx10cfHXss6In Jx/77U2Nkac6U1+6oS2pFKEOA9Sqp4jcOGKkCRm317ksQ6GB0tDq5t35JEW5CwbsOhA9 b6EQ== X-Gm-Message-State: AFqh2koiWQQHD1JVM/Z8gMsP5myvgAYH1zpVDt880b62O+NtzpVKCExK sfZca+WuLSf3dh/RUPrcJJoKew== X-Received: by 2002:a17:902:b713:b0:190:c550:d295 with SMTP id d19-20020a170902b71300b00190c550d295mr64328108pls.9.1673290020669; Mon, 09 Jan 2023 10:47:00 -0800 (PST) Received: from localhost (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id j1-20020a170902c3c100b0018853416bbcsm6539787plj.7.2023.01.09.10.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 10:47:00 -0800 (PST) Date: Mon, 9 Jan 2023 19:46:57 +0100 From: Jiri Pirko To: =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= Cc: Horatiu Vultur , UNGLinuxDriver@microchip.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: lan966x: check for ptp to be enabled in lan966x_ptp_deinit() Message-ID: References: <20230109153223.390015-1-clement.leger@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230109153223.390015-1-clement.leger@bootlin.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, Jan 09, 2023 at 04:32:23PM CET, clement.leger@bootlin.com wrote: >If ptp was not enabled due to missing IRQ for instance, >lan966x_ptp_deinit() will dereference NULL pointers. > >Fixes: d096459494a8 ("net: lan966x: Add support for ptp clocks") >Signed-off-by: Cl?ment L?ger >Reviewed-by: Horatiu Vultur Reviewed-by: Jiri Pirko