Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 10:21:56 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        willy@infradead.org, tsahu@linux.ibm.com, jhubbard@nvidia.com
Subject: Re: [PATCH mm-unstable 6/8] mm/hugetlb: convert
 alloc_migrate_huge_page to folios
Message-ID: <Y7xbRE8xOsRU3DKN@monkey>
References: <20230103191340.116536-1-sidhartha.kumar@oracle.com>
 <20230103191340.116536-7-sidhartha.kumar@oracle.com>
 <Y7jCzW6oqlHpxusA@monkey>
 <4a0bb956-c878-4516-11a0-b233cbc2b3de@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4a0bb956-c878-4516-11a0-b233cbc2b3de@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4CCc4xGUKpSBNIuxd8En+lqIzTTYj/AqCK4A49A+Sr2gwGFL9Q7fA7v/CDEk?=
 =?us-ascii?Q?KXW7OIcGy4H77w1gxvRLWKyUqOokPoe+WR4KKs5ngd3q6sw3Ah/p6fKTkzyL?=
 =?us-ascii?Q?zOyw6cdRGr9eEpqlZSYCH594XJZ0SrDMdmm9RZy9hjz0QnvtEpCuES9NV+wC?=
 =?us-ascii?Q?kd1vHLS9SVdii1v0+o9ZA0yhKK0QKG9vjCf3TNGP+5sOmxezUtCAauP1BVXq?=
 =?us-ascii?Q?rebhMBYSJFbCHiCxLzVOlqdmRckiRZntLH7uLl+IxVm/Fq6nINJFCdBSsnpo?=
 =?us-ascii?Q?BlLd50JBT4Hfv9wmQAxmcXieVeNi78L6P9lYQY8UNI1iN5k/vBbmwW09Xn5O?=
 =?us-ascii?Q?2SxYqRECPXKSDsVAp4HIGNCdSQuF2qiQ7ox0oHhHA5cmycfTVmxPqjb+jAgR?=
 =?us-ascii?Q?/v4IYy2+cALZgjMV34CX9d1TmDBph/h3Lv8O9U2lryytjyR34Lws/oXu9vsc?=
 =?us-ascii?Q?6KKkXIwBBKw/5oIWXMNlcTwGkizeZgYP0LUMezJeS/AcR/ZwBx9JJL6VTTds?=
 =?us-ascii?Q?MYMQLSZJ+TxzUnq0Y6dgbacQ0R0MMVUh5GdIg6qswr9vrIh29PguXKmHI3e5?=
 =?us-ascii?Q?IcHEejxv4ROFrFG9QAl3CAVmGPdhYhaPOkgUuADlHdhmD373M4daUTWRdmuH?=
 =?us-ascii?Q?KYBOzbaJ9TFInNL1KWugESMeBmTzyrxr5orWEdKbOPEoXF35OFGG4lbsXvQU?=
 =?us-ascii?Q?N8iVof0JlqahVqEyfylXPM8Y9C8OznFIWfv1ontJVx0nl25wLahaFKMz3lsh?=
 =?us-ascii?Q?dLVDe3p4vfGjq8d7J3N/bpdKmX1TqC5GqtYOnW3bHjKoVaVPYqYg+SAoYHOB?=
 =?us-ascii?Q?4icmp1CktitaM21/t5G6UwhAjaIfbf+rmTVBVs/6M3F+ZeMX5s98qy6Z3N+G?=
 =?us-ascii?Q?NifxTOKMOpGvWKxc0Mnsf7s2DGzouwSdRydjZAdTqop67Vje2nnQ6GT2SYZS?=
 =?us-ascii?Q?HClkMDNlaKM9wq+rczZgc6vIBFwSHTQU6WPm41edpRNeb9kNjDl+tOfOcdM/?=
 =?us-ascii?Q?XbyJGvRq2jEBIUpwBTLbd+qFtJH445rm8/uGfYwxWwFcPRkdxtnY2bzwCV+1?=
 =?us-ascii?Q?gq/2LswBjO8PIZBItcmizIpE2qOPIXaxBo3gLQvXEWaBp5WVmNzVTbmHZgbD?=
 =?us-ascii?Q?nLM/qmMwQ/TkdmfOu+97my33Ki1jDYwWZgx7EC1cBJGzONPKp20gd+X1d65a?=
 =?us-ascii?Q?vnT3mUyk28UsLcIZSdplPnPyEGzz0+cdZaE16qaUa9tPmbDD4MtqKmrMfX+0?=
 =?us-ascii?Q?Xj5xKbZCc6Z/vhikTudCy/36qBFZm81tdsiP48jRcfHkzUyAEo5BpvC64GmT?=
 =?us-ascii?Q?XfVKwu2iA+karI4AAORn5KjyjnsN5iz60mDy4Z6th7uh+rmZCZ5MAwZ+ROOF?=
 =?us-ascii?Q?LuyHE4xzDePYPIq/Q6/6hXVEaWygZ8nDmKwwjBwDDefHJ6uE9ygHcY+uY+vC?=
 =?us-ascii?Q?I0sgzsB8U/CNHK0bwHLPjqBg6H/Sq3w3GKhLDWY1gAR+GP6aEiaawiTB/6on?=
 =?us-ascii?Q?kej9lgmt+uKyzywyLWU7bFBLBfYCA+fnnBNtlwD4vOhScbypg2iHa2dNKPN4?=
 =?us-ascii?Q?sdw5ku6wluGIGVh+BqnpwLmzrbk1MKgCdHa8qpMK1JG0BZ978lxtHBUMBWbI?=
 =?us-ascii?Q?gg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?iJEIanKNPqrpJuPFc5Z/es0UchwLzGC6O6YigMB6pS4R8qij5DaAc0Mzghv+?=
 =?us-ascii?Q?ICyn8xmZHwtaHb3fOkxgweKEJ/Zi8eKopfPy4aO0uKULkvpmt2G9VHZ2uBC2?=
 =?us-ascii?Q?zXrgpcwHxyBy6z75ZiOaOxMfPHV+oDhQSgzdGs4lWa4jScWlZCMQR/IF0Jeh?=
 =?us-ascii?Q?qO6HURiuNlnvjqLpOkNCSkWjgKO+X2AssY6sFku9+CJHaW3aKtfo4HnCNFlk?=
 =?us-ascii?Q?mvRmTAWMhB6JLbn9Yq6+n8J3LZ1ioyfzZdQo+1ptxzWwyTy8Q9tcigLQrhQc?=
 =?us-ascii?Q?lQbqnMbscBGC+VpFuxtAXm1WpV1xX5OQBOn9sfoP0+qMZM6UHn0Ll7KbDOCZ?=
 =?us-ascii?Q?OuRpMQovkR1BXzmSYCUsqqQcVw82Wr+yLY7WS4zT//rIuL+WyJDyTmYCstuW?=
 =?us-ascii?Q?52Vk4u5joobPQYOwhylfrCGOmYeDO9wR64udAoRikmtFyWcynfIFb75Fva3T?=
 =?us-ascii?Q?KlYKZJYwiBmTv9xY1YDBTaMCBGBB8wYPmWCU3Ow66+QnRZM79D6/grKsIll2?=
 =?us-ascii?Q?0CbUZfmLfUrKTFtedhVEuyVb4cALbIbFrJTRNe1b+q+Yt9SrBKOwv/4eh+zB?=
 =?us-ascii?Q?MCspBR1CqykIrhWLnSSvljpJxaEAVQD9dMrxII5hKrTGLn2nvGh1ghrxQFKy?=
 =?us-ascii?Q?e8jTvUIOYtRXa8dAnRdIoFgbaTLyPCiNEAtvM7+RMjeBaJlpVv0A9/b8JMpk?=
 =?us-ascii?Q?CpL7wPoBIdEyai11c+Ha06nMbNLpVO6nD8mI4bXlJkkq0qdvghfvzOUoM8eE?=
 =?us-ascii?Q?rVg8/Welc8+lcQ2N2dVIiV+ArTTh+Jy5h7oI2xQQFL4z7HnjihD6qD+ESus/?=
 =?us-ascii?Q?If1aTgY3eDcs88xClbNvu7Xa0O2XyXN+7F4eEsMQhveNKl8kM99IWh6aAPNV?=
 =?us-ascii?Q?22uHwsYUlnc5y+O11DNdYYR7Bw0iAOra5nr34K27NbXQ3KOnIMcxoqcinoam?=
 =?us-ascii?Q?c8289K6jim1yAE7URjxTYPyygfKO8IMSDQIGS8LLwiI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f5509a2-83aa-412b-93b8-08daf26e65bf
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 18:21:59.5443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wEeOybrpHwA3gQfeAdPmkMkYwqMDDwiy2PQBBf6YyU/Tz/c7yzmi8kTjRiMXmzy5vaKJLSFzW/Awu6Whgrjp+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5739
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-09_12,2023-01-09_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 malwarescore=0 bulkscore=0 phishscore=0 mlxlogscore=999 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301090131
X-Proofpoint-GUID: KcmTfwlCwssdFO3Rp-ezMen8nqmCmSmJ
X-Proofpoint-ORIG-GUID: KcmTfwlCwssdFO3Rp-ezMen8nqmCmSmJ
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/09/23 10:26, Sidhartha Kumar wrote:
> On 1/6/23 6:54 PM, Mike Kravetz wrote:
> > On 01/03/23 13:13, Sidhartha Kumar wrote:
> > > Change alloc_huge_page_nodemask() to alloc_hugetlb_folio_nodemask() and
> > > alloc_migrate_huge_page() to alloc_migrate_hugetlb_folio(). Both functions
> > > now return a folio rather than a page.
> > 
> > >   /* mempolicy aware migration callback */
> > > @@ -2357,16 +2357,16 @@ struct page *alloc_huge_page_vma(struct hstate *h, struct vm_area_struct *vma,
> > >   {
> > >   	struct mempolicy *mpol;
> > >   	nodemask_t *nodemask;
> > > -	struct page *page;
> > > +	struct folio *folio;
> > >   	gfp_t gfp_mask;
> > >   	int node;
> > >   	gfp_mask = htlb_alloc_mask(h);
> > >   	node = huge_node(vma, address, gfp_mask, &mpol, &nodemask);
> > > -	page = alloc_huge_page_nodemask(h, node, nodemask, gfp_mask);
> > > +	folio = alloc_hugetlb_folio_nodemask(h, node, nodemask, gfp_mask);
> > >   	mpol_cond_put(mpol);
> > > -	return page;
> > > +	return &folio->page;
> > 
> > Is it possible that folio could be NULL here and cause addressing exception?
> > 
> > > diff --git a/mm/migrate.c b/mm/migrate.c
> > > index 6932b3d5a9dd..fab706b78be1 100644
> > > --- a/mm/migrate.c
> > > +++ b/mm/migrate.c
> > > @@ -1622,6 +1622,7 @@ struct page *alloc_migration_target(struct page *page, unsigned long private)
> > >   	struct migration_target_control *mtc;
> > >   	gfp_t gfp_mask;
> > >   	unsigned int order = 0;
> > > +	struct folio *hugetlb_folio = NULL;
> > >   	struct folio *new_folio = NULL;
> > >   	int nid;
> > >   	int zidx;
> > > @@ -1636,7 +1637,9 @@ struct page *alloc_migration_target(struct page *page, unsigned long private)
> > >   		struct hstate *h = folio_hstate(folio);
> > >   		gfp_mask = htlb_modify_alloc_mask(h, gfp_mask);
> > > -		return alloc_huge_page_nodemask(h, nid, mtc->nmask, gfp_mask);
> > > +		hugetlb_folio = alloc_hugetlb_folio_nodemask(h, nid,
> > > +						mtc->nmask, gfp_mask);
> > > +		return &hugetlb_folio->page;
> > 
> > and, here as well?
> 
> Hi Mike,
> 
> It is possible that the folio could be null but I believe these instances
> would not cause an addressing exception because as described in [1],
> &folio->page is safe even if the folio is NULL as the page offset is at 0.
> 
> 
> [1] https://lore.kernel.org/lkml/Y7h4jsv6jl0XSIsk@casper.infradead.org/T/

Thanks!
I did not follow that thread and did not look closely as to whether
&folio->page was safe with folio == NULL.

I must say that it is going to take me some time to not pause and think
when coming upon &folio->page.  Perhaps that is good.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz