Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 14:06:13 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Julia Lawall <julia.lawall@inria.fr>,
        Nicolai Stange <nicstange@gmail.com>,
        Julia Lawall <Julia.Lawall@lip6.fr>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Saurabh Singh Sengar" <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug
 attributes
Message-ID: <Y7xlpbEDspHaT5Gq@intel.com>
References: <Y6qmNW6cOHjGwn03@qemulion>
 <Y6sn1BmhFJFssW0h@intel.com>
 <Y6s0FSK9+F+/oKSf@qemulion>
 <Y6wl9NhYZG5RjJL7@intel.com>
 <Y7PG5Hx5dDE7aHSx@qemulion>
 <alpine.DEB.2.22.394.2301041850570.7216@hadrien>
 <Y7XABJ9MWCWO5IUA@intel.com>
 <991ac2b4-f458-f6f2-f494-648ed61efcff@inria.fr>
 <Y7nQHfbKNmZ1sRbO@ubun2204.myguest.virtualbox.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y7nQHfbKNmZ1sRbO@ubun2204.myguest.virtualbox.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0I7Sc2XG1IiOUZZQ0lUt/5vYZmKkoHT4bKhRsjodtBpLET8jBN6hsMR+VJJo?=
 =?us-ascii?Q?ujdMnZHMw2/63aqGExStmP4bUSsex63hJXq74RH8D5A1YdcyCQJwYjkXfSDs?=
 =?us-ascii?Q?YtWyLxfqPsZ9+Y2B8yHbS585EkvANoRO6DDz5KQTRoBWk1UHtMFKBzrZnPel?=
 =?us-ascii?Q?yd2sI1G3/+dx5TeZQmJilVQl1SayRCCZBSTgWjrb8U3Q+Ba+EEeox9vAUe+Q?=
 =?us-ascii?Q?9KZAnO1myCnyFNcFNuybcTKKR90Fc2VLhjrpYuVQvRAATIsWgrFgYXyk7h3D?=
 =?us-ascii?Q?gpyUIh2B43VFUXYOOhvpQW9YVQNBbVBUkugr6p4b0Ha/W26ZZvWqTr0wJ3xt?=
 =?us-ascii?Q?QBG+mRITsUx5D8OD0lOUaWyUnpLNdi7Zr3GGXEgvWgY00yXi7Am/KYmeYh+X?=
 =?us-ascii?Q?J2BKgKmz2en7lgI3ZpESTxQbM+4pkv+iZj6ns3U+5OjS+OSdk2kf5UOZQJkz?=
 =?us-ascii?Q?m3kA6p6aYEpg70gOTPCNOMxl+lfKnIT3v1XEMZi+lHu6povsCdvksbxWTT4Q?=
 =?us-ascii?Q?+yeSQDmhfeF4woYy3C90vWyrJySW2qWqgwEmuKjmrd9tQ32lRYDK/smWtLa0?=
 =?us-ascii?Q?YbYXNJNhPZvRDQbQN/vMJltih/7yQXoFoQZudT6bu5T6KravWt6f8Lnhya9h?=
 =?us-ascii?Q?waIis5dLSCxZlANZkUDN4KP6L1q2JGWVJ+5sz7D9MamT9X/OhAg7pSSEzqhu?=
 =?us-ascii?Q?hmuRdBUJHHCh0P1kinQ8w42joD2KvOAXpvcSta57nVzItmGKheEE7zeDf44O?=
 =?us-ascii?Q?oKMQZwJSp9ZzzIPJyqZPNyTpYBzQDPPESoNHUWeX7XZNLBx+7XOOmyY9ZBLe?=
 =?us-ascii?Q?2Uxre1ShcgsBlPi21x+KGvZy/leQ++WacyI4fw2J3RKK0l60PcFp21H+v1yx?=
 =?us-ascii?Q?QdTpXz5C2rz6yYnRWFz6ngHrshYkyw8J1YNl+x4bY89fctCBFvBM/PMaM8rs?=
 =?us-ascii?Q?nqFtUKXF1PQ/4tDHIaJfCrFnU7jBgv3qrKl5hnCcOcLMUz6QGGg+4ps2erRC?=
 =?us-ascii?Q?JoxOlxvdbAn/RfFEbnNBpNXbYp+eVW0KCPjGV/4z1jEjN2+jmBdJ+y/BPzDa?=
 =?us-ascii?Q?WUJcCFOig1dBBd+cc/5tMJEvpQVAQ+cqv97fcHNiK/dTPhkwoWut3tjudGBn?=
 =?us-ascii?Q?WS3JQ5g+1LwnTQ8RHqcXlodh9SFOSoY598MUfQ8tAygsxx2b8ks/PmXoheuv?=
 =?us-ascii?Q?NxBRRqFqSQ58KIYp+COrAuA4O5NXeWx0nFIEatmiACpyg6cCqEKbLnenGQzG?=
 =?us-ascii?Q?rZg2PYXU8+A9/lTCpvco/xU3jF5IEk29K9bjbiVCw6/66EgR3RQA0SQnN1TZ?=
 =?us-ascii?Q?M5CW/G8/qmJY5GcnKEHT7WZQVsctETUgp8v1I/UeBisepPQ0kQMjiI/eF4FX?=
 =?us-ascii?Q?fuDst86kP/FFkOHDQB+UfsiH5EZE7KjoVuIzdQiIJ6ELAp3Tk6Mh7kitNaDs?=
 =?us-ascii?Q?1gDwNFamujydp24zZD63d80jS9+/bZjeD5sltDZF+7LK1XIA4lPU+OVh3jFm?=
 =?us-ascii?Q?F1ETHFmDOuDwrSQaiwQtJ8xWpsPXpUooZgorxqEaliqExxJ2GEd6tUHOQ0Xe?=
 =?us-ascii?Q?PflISnbT2zzmhUT+mCpQfJrDQJZk8pnlpiBoVPqtPi0uaCN2LgqmLXuIfKEi?=
 =?us-ascii?Q?ZA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ade286d-390c-46da-8180-08daf2749753
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 19:06:20.2649
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: io7ifq6d3k7ahMqLvBCQ8EQv+BahkHyrg3id2ZRElHbfvub5Ey+65Pk9AxDFIkl/05zGoa7ndukPT/EzZaBCtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5379
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 08, 2023 at 01:33:41AM +0530, Deepak R Varma wrote:
> On Thu, Jan 05, 2023 at 09:13:35AM +0100, Julia Lawall wrote:
> > > Hi Julia, thanks for helping here.
> > >
> > > So, my question is why this
> > >
> > > make coccicheck M=drivers/gpu/drm/i915/ MODE=context COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> > >
> > > didn't catch this chunck:
> > >
> > > -		debugfs_create_file("i915_fbc_false_color", 0644, parent,
> > > -				    fbc, &intel_fbc_debugfs_false_color_fops);
> > > +		debugfs_create_file_unsafe("i915_fbc_false_color", 0644, parent,
> > > +					   fbc, &intel_fbc_debugfs_false_color_fops);
> > >
> > > When I run it it only catches and replaces this:
> > >
> > > - DEFINE_SIMPLE_ATTRIBUTE(dsa_fops, dsa_get, dsa_set, dsa_fmt);
> > > + DEFINE_DEBUGFS_ATTRIBUTE(dsa_fops, dsa_get, dsa_set, dsa_fmt);
> >
> > There is something strange in your question.  You have MODE=context but
> > you show the output for MODE=patch.  The rule dcf matches a call to
> > debugfs_create_file, and the context rule matching DEFINE_SIMPLE_ATTRIBUTE
> > is only activated if dcf succeeds.  So when the context rule gives a
> > report, there is always a corresponding call to debugfs_create_file in the
> > same file, it is just not highlighted.  So the request is that it should
> > be highlighted as well?
> 
> Hello Rodrigo,
> Not trying to speak for you, but I think Julia's comment appears to be the
> correct interpretation of your observation. Would you mind confirming/clarifying
> and suggest next steps for this proposal?

doh! newby coccinelle user detected! My bad, sorry!

make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

do shows everything.

So, could you please mention this line in the commit message so we don't forget that?

Also could you please provide patches for the other cases?
1 patch for each file is desirable in this case since it touches different areas.

> 
> Thank you,
> ./drv
> 
> >
> > julia
> >
> 
>