Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221207104005.v10.1.If7926fcbad397bc6990dd725690229bed403948c@changeid>
 <20221207104005.v10.2.I9e018ecb8bdf341648cb64417085978ff0d22a46@changeid>
 <Y7WkeCi7/x/t37JM@google.com> <Y7YjmtwByTR+8tbZ@google.com>
 <Y7bdmiZ9lqKZXCfq@google.com> <Y7buUdgLfnQqnG+x@google.com>
 <Y7b6dC6dDNO2bVjr@google.com> <Y7cSKFIakdGKKokE@google.com>
In-Reply-To: <Y7cSKFIakdGKKokE@google.com>
From:   Mark Hasemeyer <markhas@chromium.org>
Date:   Mon, 9 Jan 2023 12:06:38 -0700
Message-ID: <CANg-bXDrSJCGk27YKheupm9YND1fSaBaYfQ1Bd-4C-PnH67ioQ@mail.gmail.com>
Subject: Re: [PATCH v10 2/3] dt-bindings: mfd: Add compatible string for UART support
To:     Tzung-Bi Shih <tzungbi@kernel.org>
Cc:     Lee Jones <lee@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Raul Rangel <rrangel@chromium.org>,
        Bhanu Prakash Maiya <bhanumaiya@chromium.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        chrome-platform@lists.linux.dev, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 4, 2023 at 9:08 AM Lee Jones <lee@kernel.org> wrote:
> I changed the subject line and applied the patch, thanks.

Hey Lee, a couple comments/questions:
1. The subject line of this patch was updated in v11 of the series.
2. What tree was the patch applied to? I don't see the changes in linux-next.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml

On Thu, Jan 5, 2023 at 11:08 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> On Thu, Jan 05, 2023 at 04:27:32PM +0000, Lee Jones wrote:
> > > > You should gain permission from the maintainer before you apply patches.
> > > >
> > > >   % scripts/get_maintainer.pl -f Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > >      Lee Jones <lee@kernel.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> > > >      Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > >      Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > >      Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC support)
> > >
> > > I see.  I guess for the case, I should get both MFD and DT bindings
> > > maintainers' Acks before applying the patch.
> >
> > Yes.  The situation isn't overly clear and differs from subsystem to
> > subsystem and maintainer to maintainer.  In the MFD case, Rob and
> > Krzysztof conduct the first reviews.  99 times out of 100, if they're
> > happy, I'm happy and I merge the changes via the MFD tree.  Same goes
> > for Backlight and more recently, LEDs.
>
> I see.  Apologize for that and I will pay more attention next time when
> handling cross-subsystem patches.