Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 19:19:14 +0000
From:   Mark Brown <broonie@kernel.org>
To:     William Zhang <william.zhang@broadcom.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Linux SPI List <linux-spi@vger.kernel.org>,
        Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
        anand.gore@broadcom.com, tomer.yacoby@broadcom.com,
        dan.beygelman@broadcom.com, joel.peshkin@broadcom.com,
        f.fainelli@gmail.com, jonas.gorski@gmail.com,
        kursad.oney@broadcom.com, dregan@mail.com,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/16] dt-bindings: spi: Add spi peripheral specific
 property
Message-ID: <Y7xosoZMJEwRi1ok@sirena.org.uk>
References: <20230106200809.330769-1-william.zhang@broadcom.com>
 <20230106200809.330769-4-william.zhang@broadcom.com>
 <Y7iPS48viBg0QRok@sirena.org.uk>
 <3ff9a7fa-25dd-701c-078e-03e47bd3c08b@broadcom.com>
 <CAL_JsqJ7kr-6xs53NYJufem=wXnXVRnj3-1t1rG+W6g09kJ3ew@mail.gmail.com>
 <6720e3a4-dbbb-f490-98db-511a52b9a2ab@broadcom.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="lmcZn8x/tmKJQ3ye"
Content-Disposition: inline
In-Reply-To: <6720e3a4-dbbb-f490-98db-511a52b9a2ab@broadcom.com>
Precedence: bulk


--lmcZn8x/tmKJQ3ye
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 09, 2023 at 12:06:13AM -0800, William Zhang wrote:
> > On Fri, Jan 6, 2023 at 9:27 PM William Zhang <william.zhang@broadcom.com> wrote:

> > Keeping the clock on or not would affect all devices unless you have a
> > per device clock you can gate, so making this a per device flag
> > doesn't make sense.

> This applies only to each chip select. There is only one device under each
> chip select.  So won't impact any other devices under other cs.

I don't understand how this would work - usually a SPI controller has a
single set of clock, MOSI and MISO lines with the only per device thing
being the chip select.  If the clock line is used by all devices then it
must be kept on for all of them if it's to be kept on for one of them.

--lmcZn8x/tmKJQ3ye
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmO8aLIACgkQJNaLcl1U
h9DqAQf8CYCqNr+Diaohf358fnuLfnlMbJCW8n2slDDq0RjrhBRy8QpuXKsw6ug1
hd7C56/d+UUDBgj0PtsQEcSRl1092xgblNfUTQPAeEltcRogkKwOuLxtP6Z0dlka
T4mDP8iJOmREbLaN2P6oyS6DlXfnnEUMm0bjgeUCdqOLF0dBgNtcAkDTb7VH8nPO
ZRUBnlcihawhrHZKfiwIYyhWqel4XylYCok+JURDvqVvTVbHQpC0epNk/zJJH3fg
zQyZykohWUty87j+sTmYkhsLWiPZAC0nUlCJaoae4GDw7mc3V0gZNxP/zS6XqR4K
qcs6uYpSzKkCGloysSZMs6UrfaZE/Q==
=x6ap
-----END PGP SIGNATURE-----

--lmcZn8x/tmKJQ3ye--