Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 11:28:01 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Frederic Weisbecker <frederic@kernel.org>
Cc:     Zqiang <qiang1.zhang@intel.com>, quic_neeraju@quicinc.com,
        joel@joelfernandes.org, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: Fix missing TICK_DEP_MASK_RCU_EXP dependency check
Message-ID: <20230109192801.GW4028633@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20221220141625.3612085-1-qiang1.zhang@intel.com>
 <20221221201634.GH4001@paulmck-ThinkPad-P17-Gen-1>
 <Y7nmihQ126cjqEss@lothringen>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y7nmihQ126cjqEss@lothringen>
Precedence: bulk

On Sat, Jan 07, 2023 at 10:39:22PM +0100, Frederic Weisbecker wrote:
> On Wed, Dec 21, 2022 at 12:16:34PM -0800, Paul E. McKenney wrote:
> > On Tue, Dec 20, 2022 at 10:16:25PM +0800, Zqiang wrote:
> > > This commit add TICK_DEP_MASK_RCU_EXP dependency check in
> > > check_tick_dependency(), fix commit df1e849ae4559 ("rcu: Enable
> > > tick for nohz_full CPUs slow to provide expedited QS").
> > > 
> > > Signed-off-by: Zqiang <qiang1.zhang@intel.com>
> > 
> > Again, good eyes, thank you!!!
> > 
> > I have queued this for further review and testing, given that it affects
> > pretty much only RCU.  However, if someone else would rather take it:
> > 
> > Acked-by: Paul E. McKenney <paulmck@kernel.org>
> 
> Thanks for picking it up! Please also add the following tags:
> 
> Fixes: df1e849ae455 ("rcu: Enable tick for nohz_full CPUs slow to provide expedited QS")
> Acked-by: Frederic Weisbecker <frederic@kernel.org>

Thank you for looking it over!  I will apply these on my next rebase.

							Thanx, Paul