Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 11:40:54 -0800
From:   Benson Leung <bleung@google.com>
To:     Prashant Malani <pmalani@chromium.org>
Cc:     linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
        heikki.krogerus@linux.intel.com,
        Benson Leung <bleung@chromium.org>,
        Daisuke Nojiri <dnojiri@chromium.org>,
        "Dustin L. Howett" <dustin@howett.net>,
        Evan Green <evgreen@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Guenter Roeck <groeck@chromium.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Lee Jones <lee.jones@linaro.org>, Lee Jones <lee@kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Tinghan Shen <tinghan.shen@mediatek.com>,
        Tzung-Bi Shih <tzungbi@kernel.org>,
        Xiang wangx <wangxiang@cdjrlc.com>
Subject: Re: [PATCH 02/10] platform_chrome: cros_ec: Add Type-C VDM defines
Message-ID: <Y7xtxo3V050rvMTe@google.com>
References: <20221228004648.793339-1-pmalani@chromium.org>
 <20221228004648.793339-3-pmalani@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CpmHd8ttyUe4GQ8r"
Content-Disposition: inline
In-Reply-To: <20221228004648.793339-3-pmalani@chromium.org>
Precedence: bulk


--CpmHd8ttyUe4GQ8r
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 28, 2022 at 12:45:05AM +0000, Prashant Malani wrote:
> Add the EC header changes need to support USB Type-C VDM (Vendor Defined
> Messages) communication between the system and USB PD-enabled
> peripherals.
>=20
> The headers are already present in the EC code base, from which they've
> been ported [1].
>=20
> [1] https://source.chromium.org/chromium/chromiumos/platform/ec/+/main:in=
clude/ec_commands.h
>=20
> Signed-off-by: Prashant Malani <pmalani@chromium.org>

Reviewed-by: Benson Leung <bleung@chromium.org>

> ---
>  .../linux/platform_data/cros_ec_commands.h    | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>=20
> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/lin=
ux/platform_data/cros_ec_commands.h
> index 7c94bf5c8f05..6665e7da6ee2 100644
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -1300,6 +1300,18 @@ enum ec_feature_code {
>  	 * mux.
>  	 */
>  	EC_FEATURE_TYPEC_MUX_REQUIRE_AP_ACK =3D 43,
> +	/*
> +	 * The EC supports entering and residing in S4.
> +	 */
> +	EC_FEATURE_S4_RESIDENCY =3D 44,
> +	/*
> +	 * The EC supports the AP directing mux sets for the board.
> +	 */
> +	EC_FEATURE_TYPEC_AP_MUX_SET =3D 45,
> +	/*
> +	 * The EC supports the AP composing VDMs for us to send.
> +	 */
> +	EC_FEATURE_TYPEC_AP_VDM_SEND =3D 46,
>  };
> =20
>  #define EC_FEATURE_MASK_0(event_code) BIT(event_code % 32)
> @@ -5724,6 +5736,8 @@ enum typec_control_command {
>  	TYPEC_CONTROL_COMMAND_ENTER_MODE,
>  	TYPEC_CONTROL_COMMAND_TBT_UFP_REPLY,
>  	TYPEC_CONTROL_COMMAND_USB_MUX_SET,
> +	TYPEC_CONTROL_COMMAND_BIST_SHARE_MODE,
> +	TYPEC_CONTROL_COMMAND_SEND_VDM_REQ,
>  };
> =20
>  /* Replies the AP may specify to the TBT EnterMode command as a UFP */
> @@ -5737,6 +5751,17 @@ struct typec_usb_mux_set {
>  	uint8_t mux_flags;	/* USB_PD_MUX_*-encoded USB mux state to set */
>  } __ec_align1;
> =20
> +#define VDO_MAX_SIZE 7
> +
> +struct typec_vdm_req {
> +	/* VDM data, including VDM header */
> +	uint32_t vdm_data[VDO_MAX_SIZE];
> +	/* Number of 32-bit fields filled in */
> +	uint8_t vdm_data_objects;
> +	/* Partner to address - see enum typec_partner_type */
> +	uint8_t partner_type;
> +} __ec_align1;
> +
>  struct ec_params_typec_control {
>  	uint8_t port;
>  	uint8_t command;	/* enum typec_control_command */
> @@ -5752,6 +5777,8 @@ struct ec_params_typec_control {
>  		uint8_t mode_to_enter;      /* enum typec_mode */
>  		uint8_t tbt_ufp_reply;      /* enum typec_tbt_ufp_reply */
>  		struct typec_usb_mux_set mux_params;
> +		/* Used for VMD_REQ */
> +		struct typec_vdm_req vdm_req_params;
>  		uint8_t placeholder[128];
>  	};
>  } __ec_align1;
> @@ -5833,6 +5860,8 @@ enum tcpc_cc_polarity {
>  #define PD_STATUS_EVENT_DISCONNECTED		BIT(3)
>  #define PD_STATUS_EVENT_MUX_0_SET_DONE		BIT(4)
>  #define PD_STATUS_EVENT_MUX_1_SET_DONE		BIT(5)
> +#define PD_STATUS_EVENT_VDM_REQ_REPLY		BIT(6)
> +#define PD_STATUS_EVENT_VDM_REQ_FAILED		BIT(7)
> =20
>  struct ec_params_typec_status {
>  	uint8_t port;
> @@ -5876,6 +5905,28 @@ struct ec_response_typec_status {
>  	uint32_t sink_cap_pdos[7];	/* Max 7 PDOs can be present */
>  } __ec_align1;
> =20
> +/*
> + * Gather the response to the most recent VDM REQ from the AP
> + */
> +#define EC_CMD_TYPEC_VDM_RESPONSE 0x013C
> +
> +struct ec_params_typec_vdm_response {
> +	uint8_t port;
> +} __ec_align1;
> +
> +struct ec_response_typec_vdm_response {
> +	/* Number of 32-bit fields filled in */
> +	uint8_t vdm_data_objects;
> +	/* Partner to address - see enum typec_partner_type */
> +	uint8_t partner_type;
> +	/* Reserved */
> +	uint16_t reserved;
> +	/* VDM data, including VDM header */
> +	uint32_t vdm_response[VDO_MAX_SIZE];
> +} __ec_align1;
> +
> +#undef VDO_MAX_SIZE
> +
>  /***********************************************************************=
******/
>  /* The command range 0x200-0x2FF is reserved for Rotor. */
> =20
> --=20
> 2.39.0.314.g84b9a713c41-goog
>=20
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--CpmHd8ttyUe4GQ8r
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCY7xtxgAKCRBzbaomhzOw
wldCAQC78NC9IQIYLqOZQXd8fQCOa4OPJd8rszj0QRhB0GcO9wEAqRmaao9paHIy
Jytje0kN/NhKZZJUHYTrTEiAFWNo2w4=
=MhSQ
-----END PGP SIGNATURE-----

--CpmHd8ttyUe4GQ8r--