Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bc4ade74-dcbc-88f6-2d88-2bd4c2be38ba@oracle.com>
Date:   Mon, 9 Jan 2023 13:43:39 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH v16 7/7] x86/crash: add x86 crash hotplug support
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com
References: <20230105151709.1845-1-eric.devolder@oracle.com>
 <20230105151709.1845-8-eric.devolder@oracle.com> <Y7vD6bm9xy9uyvRD@fedora>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <Y7vD6bm9xy9uyvRD@fedora>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHNscFAxRGY2dDgwbDFJUHdpM2xtZ09xelNXT0dTNXNLNzhuUXJGZkI2TDJw?=
 =?utf-8?B?bzJBdGs1UGZJcTRWOFJnY3I0QUNaR01xWXBReHJtWTh0ZkYvaGdyVWtaWjNj?=
 =?utf-8?B?NnpvdlM0VE1ZUEZRWmR4azVyUGorUnV3Y2YxNElabC9QdzFWM21QeW4zNG1K?=
 =?utf-8?B?dGdDaTB3Z3FTbW8wN21rbGJNZGVMbkdDcC85d1lldzV4ZWFIcWc1QVJqTXZU?=
 =?utf-8?B?SHgrSFVtV1paWkUrMys1K0RhNnMwZTlsVTFlRW0vMTJ0K0VDemh2Yi9DQk1D?=
 =?utf-8?B?ZVBHWTlIWENLMWdXOTJqam4wWnNGK0pERm9pSStpSit0NlpVWmk3MXlJSmww?=
 =?utf-8?B?bmhOOWdBY24yS2RJVldqdUE3YUZyQ3BwRjVtZ05TZzk2OWgzMk12VElySlBF?=
 =?utf-8?B?bEMxTktnOGsyK3VBR1FqK2svdVAvaUl6cytoMnBLSXFHZnlBQ3VmeW5KajlM?=
 =?utf-8?B?UTZ3Rys1RmJsb0svcXlObmMzdHdaMi9sb2RhNzMzajlyNW5nTXQxRVY0eWpM?=
 =?utf-8?B?dzA2V2NUVWdhQSt2UVg1TGtMeXNPbGx6UE5PYTZGTE82N0l6VzNUVnI1MnZV?=
 =?utf-8?B?NUJxTktqNm5STVJFVk56VnNlNTZrYjhWL3hQOVVPYS91ZzlDWVRjNFFqWnI2?=
 =?utf-8?B?ZW8vVnBleGF5UUhyNThkdis2UHpkS3FCMXBFSmpDMU5OZDk5OTByOEtOU2ly?=
 =?utf-8?B?ZEJFK2RjNURJQWxTZ2E1Zlh3ckxKVXJ1MDNDenFKRWFJY3ZPVUVVeTFOcUNJ?=
 =?utf-8?B?bkkwNEFpWVRySFlKMzV0VGZMd1gzWW5UNHUyaXBxRXdUUWlObmdEaTB2VmNH?=
 =?utf-8?B?Wlh3UDR5OXFOSVlFa0xhS3VvTktiTXJiTzNpK3phU0JpbGZweFM2bGp4eC9G?=
 =?utf-8?B?dkdFa3FyeVA3VzU3QVdjNFE2Nndwbm9mUmgwUTBVbm1VaVJESm5TajFmeE5B?=
 =?utf-8?B?TXBWVmlVd0x3T0Ztcnp1RWhjN0FNNVo5dDV4cHRoWlZzR3BDQ1JMMXB1YVpM?=
 =?utf-8?B?dlkxRTV6TU8xWE1zall3WmZ1Q1NpVWhYWFhGQmIyOStDVU5EUUFUSUVLa0ZZ?=
 =?utf-8?B?QmVJelBOOGEwc0JjQXhQSm9Rd0JDcFg3bWdGQjFVTFVneGExOHl5RkJXaHZl?=
 =?utf-8?B?aUZqVnV1RDhSUGs3NktIMkhSNW9DMElNcWFKdE5XRHN4bjhmbEpzc012YXBL?=
 =?utf-8?B?VzVESWRnNTZsYklvNHZFeVVwMDhiVjNRVzRsTEd5UTVTTW5LdkZzM2pyb01D?=
 =?utf-8?B?SGEvQTV5NHd1bGt3cWNmdHhCTG1vd0d1d0lGemZKbkdyUW5peDhTbk5EN2VB?=
 =?utf-8?B?dk1UNnUxYk5MTGRLV2FraU1VazJvRm05VHdvQlVTOXBPY1piWlA1Q084Nytw?=
 =?utf-8?B?SmtwQnl3anpqaFNuRVByL2xIK1F0ZHdZTTQyc0dvVTlORXhqZnJXR1ZqZHBn?=
 =?utf-8?B?aG54SzZZKzluU0xjWmdmQkt6bUs2Vks1V2craTFQR0wzTEkrbnF0b1NITjRK?=
 =?utf-8?B?K2RSWFBYMm5LckE0Rjhaa0xaQktxdkpRUVV5YlZsMitmdU9Kem5yT2RWUy9G?=
 =?utf-8?B?eE04ZTRRazN5UGIvSVY5MzNSNDBnNFV2aTlEZStJaW1XVGFzbkVTclJmQkR6?=
 =?utf-8?B?dWRkUitpVTFGaWsrWmorSjUxVTFKMXpvcTl4Q3hlQ2Ezd00xajJFSUlUaHl3?=
 =?utf-8?B?V3lseW94UjM5ZndEekZFSHo3bEE5UlpxaFQzQ3pkL0NWUFB1aTRtbUlqRWs2?=
 =?utf-8?B?Q1RrNjJBN0plZzNoeDh0bkNud0hhRy82MU9NV3AxaXZZY29SaWFjV2RmejZL?=
 =?utf-8?B?ZE5CTWRMdy9aU3RSbHZURDdOM2tRZ0RMT0lkVGorVUpDZU9BUUt4cU5vb0xJ?=
 =?utf-8?B?d3dUVkVyZzBJdTI3emswSTVERkZWMmFOcXpBUkxWSHBSY1lrbkVhUndyUnR3?=
 =?utf-8?B?ZEVReENteU95UFhSY3JsbmpvK1dOZEJLdXZoL3hCSHlqYmlJWlZUeFFrMUoz?=
 =?utf-8?B?TWpxbEIveTllRERpV254b01SWlFJSWUvWE5sWGREYzFhcVRyaGU2UFhCdzV2?=
 =?utf-8?B?U3BkQkduOTYzQWp4dG00cHE1Wnl3dEd2SG9JcXU1Wk5tQXpNeXYwcDVZWVlp?=
 =?utf-8?B?d25tbDNzaUl6RC9JbXczemNmZDhPS2NCWnFlQW5rdTBSam1tWG1nWFhGNDc3?=
 =?utf-8?Q?Z7bwXcxXa+D9HXuLpaqlFqk=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UTJSRHM1Q0FwOHhNckkzSGd1aWxsMVFnSjBESy9lWkF6Q0dSQXhjL0hUSU5U?=
 =?utf-8?B?M0x6ZUdIOG5vVmxLL1hHQVh4Y1hrenJ1UmFCa1I4aGd5c2g4ZCthdG1Ybzh0?=
 =?utf-8?B?WDU0TVdRTGYzT2pBb0hYMU1pb2Q3NEh1Mm1rTUZ1Ky9uM0Q2eTdJUlhQWEx4?=
 =?utf-8?B?V2VaMmcwM2orcmxyTnJBa0I2ZWFJTVkrVXpLZ3l4N1NjTFEwTkJHQW42clAr?=
 =?utf-8?B?a0hnL1g5L3JxaXAvTEl2SnlSdW9HcEJicXhWbjFPQlkxTHVoTXdrMHVmWkNm?=
 =?utf-8?B?R096bHVIMGtyaG9nenNRbnN4NlI1MG8wenlXQlFObk5ESlRiTExJM3pwSFN4?=
 =?utf-8?B?d3U4ckdNKytDZzVJb00yMTl0YXllUVFIUCtnUUxnTm9rZjJjOVRlR0xGNExS?=
 =?utf-8?B?cUcxeGZMVU1GNDJYVG5FQVI4K3pKbExPVytjQmZTd3h3eHBxcUpCZ0Qwa2JY?=
 =?utf-8?B?QlNRVzBoblZMT1pKUkFTWHRhY0FLOEZLQ3BQbE1teWhnWkl4Mkk3c0N5eEkz?=
 =?utf-8?B?bmtkZTNhS3FIYmxsUGRYYkxPejdKamQ1dUFKWnV4VHFxeStsYW9uUno1dHMz?=
 =?utf-8?B?bFFXZTNzUTVBOVF5YW5XeGR0STFQN0FoM3JwRWJIcE9uR0YxLzdKS21lY2lL?=
 =?utf-8?B?Y0Znbm5ZMXFuU29TWWgyMDhXbGNscGp4WTRiK2gwYStCemJCeVlFYjRsZmhZ?=
 =?utf-8?B?VHdUeGFILzk3K01vbU1QY2trZFAxTFFxczkxeWR1UGVsdzltYWZvd0RHaGNS?=
 =?utf-8?B?YlNuZk5mTzdKZVBqbkI5U1JGY2JkRDJncm4zZWN3cjhHbS8xUGJMZDdUWEJp?=
 =?utf-8?B?V1VHNzVxQ0tsa2RCb1NWd2FuL3E2VmJvOU5sOUFxR1hNMXhndGo0dHFJNi95?=
 =?utf-8?B?bkV4RDAwcm1YTG93cEd0UWZBUkhrUkhsUU8zYlovdXExQitGR3NVZHk0ekhO?=
 =?utf-8?B?K0xoNGVIVW1KalhqaEV3dmtHVDh0YVU0NEc1bmN2bndrMTdOSk8rZU0xYk5q?=
 =?utf-8?B?UWQrWWYvQ0NGbHFJVjllR21nZ2lOWTMvNXl2cHkxT1IxQmlOTU9rODlCeEov?=
 =?utf-8?B?RW43MGZkc21zRXM0NG85MTY1Yy81Y1YwbkxROXdSd3VFbDAzc1M3N1RkNjBB?=
 =?utf-8?B?M002NzVseC9TSUhhaUhEZlFiRzZoT2h5L1NEOEFYMldUbUVVbThOZ3dIL0VZ?=
 =?utf-8?B?VkVmZ0twVHE2ajJMQ1B5bWY3MTJpSTc0YlNGVG9MZEU0VHhidTBRU1RoMG9S?=
 =?utf-8?B?bGtCNmZUak50WTZCdFpCZDZ6eUZxbldidmQ1ZXV5T3RYR0RCSlJIcnYyWmdN?=
 =?utf-8?B?WGUyOEFjN2poMFl1ajJFOEZ1Y0NxbnBvV0hqSzViWVZ1eDBRVjh2OTg4c2RM?=
 =?utf-8?B?OGNXS011SzVhU3FpQ2ZlSmRzTmh2bzNJci9hK0puRm5RMFFSTjJjWktUbEUy?=
 =?utf-8?B?Y2xOQTJEMG5GVE9VNVl2cWExTlZua2R6eXppYUhWWTNtVVdmNUJ1eExydHQw?=
 =?utf-8?B?WTFsaU1kNXI5b1VrODNEM2JGTWtHbDNjTHlBV3ZsdmpvRjIxQ3A4RE8ydEZK?=
 =?utf-8?Q?g1UNYLCkMWgxVoJYOhlIbBRDg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 160d3282-528c-495c-bfaa-08daf279d229
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 19:43:45.9761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wcJ0dpGavEaKszLI1jpsDSOmPL7+OZKmTulZ02nIKoqKLFPE0FDdMswhTpRWFFUCrFwaIejTfgSL6z29VdvHb88z3hyGXthpwBD49Wa/KQk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR10MB5397
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-09_13,2023-01-09_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 malwarescore=0 bulkscore=0 phishscore=0 mlxlogscore=999 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301090140
X-Proofpoint-GUID: XklVL9FYvLS0w7tEL5m0kSttgRKcSwty
X-Proofpoint-ORIG-GUID: XklVL9FYvLS0w7tEL5m0kSttgRKcSwty
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/9/23 01:36, Baoquan He wrote:
> On 01/05/23 at 10:17am, Eric DeVolder wrote:
> ......
>> @@ -394,10 +409,37 @@ int crash_load_segments(struct kimage *image)
>>   	if (ret)
>>   		return ret;
>>   
>> -	image->elf_headers = kbuf.buffer;
>> -	image->elf_headers_sz = kbuf.bufsz;
>> +	image->elf_headers	= kbuf.buffer;
>> +	image->elf_headers_sz	= kbuf.bufsz;
>> +	kbuf.memsz		= kbuf.bufsz;
>> +
>> +	if (IS_ENABLED(CONFIG_CRASH_HOTPLUG)) {
>> +		/*
>> +		 * Ensure the elfcorehdr segment large enough for hotplug changes.
>> +		 * Start with VMCOREINFO and kernel_map.
>> +		 */
>> +		unsigned long pnum = 2;
>> +
>> +		if (IS_ENABLED(CONFIG_HOTPLUG_CPU))
>> +			pnum += CONFIG_NR_CPUS_DEFAULT;
>> +
>> +		if (IS_ENABLED(CONFIG_MEMORY_HOTPLUG))
>> +			pnum += CRASH_MAX_MEMORY_RANGES;
> 
> Logic of pnum calculating is a little confusing to me. If I only enable
> one of CONFIG_HOTPLUG_CPU and CONFIG_MEMORY_HOTPLUG, is it OK? Say I
> only enable CONFIG_HOTPLUG_CPU and CONFIG_SMP, on x86_64,
> CONFIG_NR_CPUS_DEFAULT will be 64. pnum will be 64, is it OK. Am I miss
> anything?

Ah, your understanding is correct, and the issue you point out I need to fix.
Specifically is only one of HOTPLUG_CPU or MEMORY_HOTPLUG is set, then I need
to allow a default for the other. Using the example you have above, there would
not be room for a single memory region, so I need to allow for a default number
of memory regions.

Good find!
eric

> 
>> +
>> +		if (pnum < (unsigned long)PN_XNUM) {
>> +			kbuf.memsz = pnum * sizeof(Elf64_Phdr);
>> +			kbuf.memsz += sizeof(Elf64_Ehdr);
>> +
>> +			image->elfcorehdr_index = image->nr_segments;
>> +			image->elfcorehdr_index_valid = true;
>> +
>> +			/* Mark as usable to crash kernel, else crash kernel fails on boot */
>> +			image->elf_headers_sz = kbuf.memsz;
>> +		} else {
>> +			pr_err("number of Phdrs %lu exceeds max\n", pnum);
>> +		}
>> +	}
>>   
>> -	kbuf.memsz = kbuf.bufsz;
>>   	kbuf.buf_align = ELF_CORE_HEADER_ALIGN;
>>   	kbuf.mem = KEXEC_BUF_MEM_UNKNOWN;
>>   	ret = kexec_add_buffer(&kbuf);
>> @@ -412,3 +454,67 @@ int crash_load_segments(struct kimage *image)
>>   	return ret;
>>   }
>>   #endif /* CONFIG_KEXEC_FILE */
>