Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 19:06:09 +0000
From:   Mark Brown <broonie@kernel.org>
To:     William Zhang <william.zhang@broadcom.com>
Cc:     Linux SPI List <linux-spi@vger.kernel.org>,
        Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
        anand.gore@broadcom.com, tomer.yacoby@broadcom.com,
        dan.beygelman@broadcom.com, joel.peshkin@broadcom.com,
        f.fainelli@gmail.com, jonas.gorski@gmail.com,
        kursad.oney@broadcom.com, dregan@mail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/16] spi: bcm63xx-hsspi: Add polling mode support
Message-ID: <Y7xloRuHk5BHSOCb@sirena.org.uk>
References: <20230106200809.330769-1-william.zhang@broadcom.com>
 <20230106200809.330769-8-william.zhang@broadcom.com>
 <Y7iW38Fsj0nIewDm@sirena.org.uk>
 <ec84b84b-41be-32ad-2e76-afac59a621d0@broadcom.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5HqRRYJJbMpHDR2G"
Content-Disposition: inline
In-Reply-To: <ec84b84b-41be-32ad-2e76-afac59a621d0@broadcom.com>
Precedence: bulk


--5HqRRYJJbMpHDR2G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 06, 2023 at 07:35:59PM -0800, William Zhang wrote:
> On 01/06/2023 01:47 PM, Mark Brown wrote:
> > On Fri, Jan 06, 2023 at 12:07:59PM -0800, William Zhang wrote:

> > > When interrupt is not defined in the HSSPI dts node, driver switches to
> > > polling mode for controller SPI message processing.  Also add driver
> > > banner message when the driver is loaded successfully.

> > This should not be something the user selects via the DT, if the polling
> > mode is better then the driver should just use it regardless of there
> > being an interrupt wired up.  Generally there's some point at which the
> > benefits of polling become minimal (and the costs more impactful) but if
> > the DMA setup is as bad as it sounds then the driver should just ignore
> > the interrupt.

> I agree but this is more for backward compatibility as the original driver
> uses interrupt to work with MIPS based SoC and I do not want to change that
> behavior.  For newer devices I added, they work in polling mode by default
> with the dts I supplied.  IMHO it is also good to have this fallback option
> to use interrupt in case user is sensitive to cpu usage.

You can put whatever logic is needed in the code - for something like
this an architecture based define isn't ideal but is probably good
enough if need be (though I'd not be surprised if it turned out that
there was also some performance benefit for the MIPS systems too, at
least for smaller transfers).

--5HqRRYJJbMpHDR2G
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmO8ZaEACgkQJNaLcl1U
h9CV6wf/cG0BlL3QXcA4PCDR+DndbCMNxAB5I/YCjZucCrKmqH/QeswtCXCdEZbk
C1R/hO/MTyhXWZBm1xR2KqHL2x/yeoJyRmOjmia3YGjfO6rISSmenKS8bcUbq8gF
N+TzgS8QoxJxoXBcgWNxA+DpHFxiu17+rYpDvWnAFRB0FOrPW4CCeX3aWoEAHJ1+
QzuAx+pix0iPxFrPiGqBOSEKLUZUgwiOGgaBfA4xguZMA9ehudIK6TO/rQ1eQIjS
KfSXZ9hkm37Gzqdez/wmRvHIblBbSS/+vpx83OnTmVerC98qvdbYXdNR2OI40m5I
LDWtN3dpqmZBYW77sjpEPPNRTrP4MQ==
=Ht9K
-----END PGP SIGNATURE-----

--5HqRRYJJbMpHDR2G--