Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5afd0a7c-3fbe-dfea-f1b4-2fc35fbb4f13@amd.com>
Date:   Mon, 9 Jan 2023 13:49:09 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v11 04/13] x86/cpufeatures: Add Bandwidth Monitoring Event
 Configuration feature flag
To:     Borislav Petkov <bp@alien8.de>
Cc:     corbet@lwn.net, reinette.chatre@intel.com, tglx@linutronix.de,
        mingo@redhat.com, fenghua.yu@intel.com,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <20230109164405.569714-1-babu.moger@amd.com>
 <20230109164405.569714-5-babu.moger@amd.com> <Y7xjxUj+KnOEJssZ@zn.tnic>
Content-Language: en-US
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <Y7xjxUj+KnOEJssZ@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2JvY0R0QUlpekhZV3liQ3NIM3dVVDkxQkh5WUxLUlhmc1BsSjMyUDJUTkJs?=
 =?utf-8?B?YlliWlpGMEVPVW9OUThNMTJRNkUwamd6YXkyYStLK2V5MVV4a21rdjBCOE9j?=
 =?utf-8?B?VjdLeDBhTTVVU1Q0SVpUNlVUaE5YTlhlV0xYNFlXN2pZd3dITFl5SkNOQy8z?=
 =?utf-8?B?SFBDMWdXMk9lTjlYTzZZSHJZQ0xlVFdIbjRxOG1tdngzTmVMK0JwWHpwcndC?=
 =?utf-8?B?UVEzRXl2RXlHc3VvY1lvamV1RlZWN0N5ZDJqN2QwZUpMSjNPQVBwQ1NqOUpG?=
 =?utf-8?B?bE14aVBzU1EzTmw4T1RQSGw3WDhBdFY1RDdVRDE0cGgvQW1xQzFHV0MyVHVv?=
 =?utf-8?B?VHhtbi8vWkRlRHltaEhzaldnZjBJVTk2NWtxL1pzQjVoUnNyd1RsZzlSQmgx?=
 =?utf-8?B?ZkErUkZmZWZZNEU0YnpRa2poTk5JejVUandFbTE4emtzaHpkcUpMMVUzRDNx?=
 =?utf-8?B?T1BHcXg3bHUwS3dRcnFUVExFbGJwRnlId0xNQnZ1WWV6KzdwMVNPSmJqTDhW?=
 =?utf-8?B?MEdrT0Yrd2xSRGNQOHhlZkRXZWp3b3R5Q1hmNzBsUmU0WXk4ZEZ1eC9wN2lO?=
 =?utf-8?B?L0dmNHNJeThXZGw2Zzljbk8xc0lsNE52TldjWncrWC9sditmSG00N3MzOEts?=
 =?utf-8?B?SzZDMW8xZjdiTDluQ0RqQnY2SXhGWGR2RXpYZTlNZTlLeHBJU0RrNjNZakl1?=
 =?utf-8?B?dmNuMm1wRlBiNXIzTzVLekZoc1RvWnhvY2wvY3ZuSE9vSVJVYWUwVWo2K0FC?=
 =?utf-8?B?UTFtUGhncDFrT1UrdEk4OGovdEVHYWkxOHJRRXJNbFF2UVF0VStuS2F2Rjkv?=
 =?utf-8?B?MlU4UEUvemFSTzdhR3B0UGtNSnFmaFZIdEQ2a285bnltMVBJdEZ2MHdOeEZr?=
 =?utf-8?B?RzdZNUs3aU1CU0R3eEZ4YWJEWVB5ejVubGowZHZwTG5iRXdsRmV3TlhqN2Vh?=
 =?utf-8?B?MWdwZ3JNcjNxcC9rMld2bkxQdUVRTURNNFpxWHZZUWJnT3g1Q1c5elJPKzJT?=
 =?utf-8?B?eDhOeG9FKzkzTGVxV1NYWEZMbmM4Wjk0WkdUd3ArQTVCek90Z3dKbzBKbm1z?=
 =?utf-8?B?VWlvWnhmeXZRV2RoN2g1QWF1NjZkUGUzM21idmo2NSsxQmx0QWlKeFczM1ZH?=
 =?utf-8?B?TXBJSDJZWVdnbHJBQjFIalhydFJYOEpRdFB2VHFQNlQ2M2M4a2xqVHlaSkpD?=
 =?utf-8?B?VHBFTy9iMGM2VmwxVDFXWEtER1hYU2IxWkh5ZFU1K0JpcHJSWFNDNjFSc1Bz?=
 =?utf-8?B?TmRSU0s2R2s5eXRxN3ZwL2hqTm1vNjRmMXg2TkhDS21rc0lwTE9VeGtqWFZK?=
 =?utf-8?B?dTlrU29qVlE2RGZDMnNsV2pBZlRhZWFURkFLaWRyL3pNZUV6WXNVNDFxano4?=
 =?utf-8?B?ZWluNnFrd1pzNXdWR25GdDB5eVdCS0doR3NSeWFBdmxyTUxYL09OZ1lJS3Nu?=
 =?utf-8?B?aW42THJQbG9JdmVwTXh2ZWI2YWdLWkUvUGJxUWgwLzBxdmk0N3VtRGpZaGRE?=
 =?utf-8?B?UGI1eklGemNJN2lLdGUvMjJuMXIwVnNwYzViNWVjdSszb3k0MnFMWHN0L0dE?=
 =?utf-8?B?eXR6Sk0wUnZvSFFoT0ZkU1hReGdaQ21SMDdQdllPc211THpRdGViVEtMY2Zi?=
 =?utf-8?B?M21PbWwrcDNJUVNuWGJuTWtFK2NpZVB4SWMrTTY1WTBvQXM1ZnNwYUd1WHZn?=
 =?utf-8?B?UnVWaEFPaVVjMTdsODVESm5ZSDcyUFdrUmsvNUNGUDEwOC9NVTJMaXJWUXZG?=
 =?utf-8?B?NisyV1Q4NWwxMVRkR3ZKd0RiSkpDbTRpL09UU0ZOS2hVY3gyWTVraWNoZWtt?=
 =?utf-8?B?MHR4NnBTVlNocjFPV0EwZUVXb20yUDg3KzhUMVV6ak5oTy9Hcjd6Ris1ZXRJ?=
 =?utf-8?B?aFhwWmFYZEl4ZGtJK3VEcnN1dlRPTWNlM29SVGNzSW9ZdzRHMEZUbmh2NEJT?=
 =?utf-8?B?ak1YY2NraDFOdFJmSXR1RFZvZ3BYNEY0cS9pZitSNVZtRUpRM3NyckMrblpa?=
 =?utf-8?B?dDExeldERXpiVEFKcUhFVWRIaVIyY1FlSHJ1SjhrNzdwd21iQWZ2V3NZNkpY?=
 =?utf-8?B?V3lna0hvT3JWVFpxbm1ZY2E5TG9JNFQ3OFovcjF3elV3Wlk2ZHRveForRU43?=
 =?utf-8?Q?Tbjc=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78d1117f-3751-4392-a56c-08daf27a96bd
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 19:49:15.7476
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FoMOyfzvzHRbGEu9LZtI6ILiO1WbiT/vMzg2rGo7Q+mKrqxbN23XnM9kfTHjnqgf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6542
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,

On 1/9/23 12:58, Borislav Petkov wrote:
> On Mon, Jan 09, 2023 at 10:43:56AM -0600, Babu Moger wrote:
>> diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
>> index 00045123f418..db5287c06b65 100644
>> --- a/arch/x86/include/asm/cpufeatures.h
>> +++ b/arch/x86/include/asm/cpufeatures.h
>> @@ -308,6 +308,7 @@
>>  #define X86_FEATURE_CALL_DEPTH		(11*32+19) /* "" Call depth tracking for RSB stuffing */
>>  #define X86_FEATURE_MSR_TSX_CTRL	(11*32+20) /* "" MSR IA32_TSX_CTRL (Intel) implemented */
>>  #define X86_FEATURE_SMBA		(11*32+21) /* Slow Memory Bandwidth Allocation */
>> +#define X86_FEATURE_BMEC		(11*32+22) /* Bandwidth Monitoring Event Configuration */
> If those flags are meant only for internal kernel code use - it looks like it -
> and userspace doesn't care, pls put "" in front of both in the comment like the
> others above them do.

All the QoS(or RDT) features are visible so far. If we make them visible,
users can easily figure out if this specific feature is supported or not.

There is some benefit if we make it visible. What do you think?

Thanks

Babu