Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3c85676b-ded2-3941-6c57-5b11397cdd81@oracle.com>
Date:   Mon, 9 Jan 2023 13:40:50 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH v15 1/7] crash: move crash_prepare_elf64_headers()
Content-Language: en-US
To:     Sourabh Jain <sourabhjain@linux.ibm.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
References: <20221209153656.3284-1-eric.devolder@oracle.com>
 <20221209153656.3284-2-eric.devolder@oracle.com>
 <09567e13-c5ed-d1b9-027c-9340fce6a0a8@linux.ibm.com>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <09567e13-c5ed-d1b9-027c-9340fce6a0a8@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djJmSktUYk50N1ZBL3d3SDZpUmlleFRjRlpRTGxYanlxa0RoZEVzYVpYcFdS?=
 =?utf-8?B?YnMyZjBOM2ZUTlhaTEIxMlc2ZGtGR0QvOU9US1p2UWo1NXYva1dkanpQMHNL?=
 =?utf-8?B?NlVUeDdkTjdWTTczMWIyMVZZNzkxc2d1SWxtQTVWWmdoUzZWdGpCaUZXSjlo?=
 =?utf-8?B?dFpyREhXcEVuYVZkaHliaWtBV1ZqdnBxdk1uZ1VKb21ZbjdUSUhaRHl4TWNK?=
 =?utf-8?B?bkVPOFgwTnI3cVE4RFVOM3FmMm1ydERwYVB3TjUvK3JKRTlTWTBjU0doNFRT?=
 =?utf-8?B?eXZQTklES0JQWHU1SnRPd2lqdEVZTjJQWnBwb3psY3ZxWi9zd0ZiSHJuaWtT?=
 =?utf-8?B?bm5BZmZDL0lKcStELzRMT2lseGkzNTF3SE1yUXo2Zlk0bkZCZkZWais4WFFa?=
 =?utf-8?B?RnVUWWdUcXFGZjl6ZGh3V3JmdkhGOWZhUERENGtzNFR3L0RzOXRkSnBPVWlT?=
 =?utf-8?B?Sk5hK0paSU1ETWVuN1hEQkRsTmQzRG43dGZlNDRqbEtuVm1LbWZtL2lXaTNR?=
 =?utf-8?B?ZXJyNkwvemlqY0ZnUDJ1WjVqRU5UY3J1d3hhbGVldUloSldLa3hIQUc2YXBD?=
 =?utf-8?B?dFdvQUJiSWM3TGw5ZHpReFBwcWxJSktMa3laWUowU2R2VHpUMGlTVlIxVGJM?=
 =?utf-8?B?SWJEVlBFcWRvOWFwdXhmYXhHdVhTUGV2aldyL0hxUFVKVnZGcjFhNW04Nktn?=
 =?utf-8?B?UDk0VHNHSzRvM01LOFE3ZG9SODhhWXlsSUR3WHIzVG5aZlhDcmJjWlNobFkx?=
 =?utf-8?B?Q0cvelhUM0RpUERxcGZFSDgxTjU3V2VYRjdIQUFUK2JpbnhzMnR0OERKL1dK?=
 =?utf-8?B?MU43bFVFZ2JIT09LN2t4cW9ieklHZ1lzeEd6TzJWQk8zd3lQemlwSFI3L21s?=
 =?utf-8?B?RmNmNlVkMS9yUnlHK051YThpa1dweDdrRzhHT0c5Q3VYcDJkYlMxQldyWFp6?=
 =?utf-8?B?ZkVzaU5FNTYzcVhzSXlyQzJHbzVyemZZQXJESm1uZmRBMlJCcjJuVzd2WU9I?=
 =?utf-8?B?WUFFRzA0Q0puSnVUVGFPY3ZuWjJHZmNLcGpsWEx1V2tNWXB5clpLVTFDdDJz?=
 =?utf-8?B?WCsyeDZScndRSTlhbm1Yd1BsSVNLM2E5QjZ2QTJqY2dJRU1MSlZ1SCsyUGZr?=
 =?utf-8?B?UlBBcGFqNzl6UHg0dkYyeWVKQ2xQM3ZmbmNmYVE5RnI3cFVGQzZRd0oxUEUy?=
 =?utf-8?B?cVREN3k3eU5hQ1gxZ2NOc2hxMldBcVJCbGE0bGlMd0dUMTBUWmR2T25rUnpO?=
 =?utf-8?B?OUhDWFBzc29lZklBNzRqUXd1OXgyaVVST1A5WGllVUlsdGFRQmQybWNyOHIx?=
 =?utf-8?B?ZW53b3RHQ1BjcUZvS09ic2pYMEI0VDlpbk4rdHJxUHczdjB5bHAvS0gxZHd6?=
 =?utf-8?B?VjdYelJRQk5BSVAzb2NLbXdkYndpTXdPSkcrMEZrbXhsN0xHV0V6QnZvbkwx?=
 =?utf-8?B?NHd6K1VBQ0xlblRIVXo2aHhoNmtpQWNHZ0lFdk14MlY0aStaY0hOWW1vMjYx?=
 =?utf-8?B?UjlrQm00ekd1UDVyM2ExZVcvYVJCYU0rTWFCeFk2L21hZEdta0VSVWgydCty?=
 =?utf-8?B?N1pTSG5GN1RyOXpDTkNKN0FBQ09yRmVNbTZaQlgreDdNSWt2Z3ppb293WEM3?=
 =?utf-8?B?d0pmYmlPcVNWL1ZNQ0hqTUhXQjVDaE5FRzY4K1dOVWVCMXBlWGh5eEk0TWg2?=
 =?utf-8?B?eFFPUnNRL2hLakR2a0xHMkxncFNFWDhlYkpUcTdmQmVhd2RBTm9RSkFJUlEv?=
 =?utf-8?B?K1gvMWFuc2tsV3RIdnppMVVnaXFCZHBLRmRZMjB0V0J6NGtULzlucnN6WVRz?=
 =?utf-8?B?Q3ZxWU1ZeUZ2K29SYlBrMzcyUXlqa3NWNlJJWUxwSHFqczIyUkx3ZWdJc2J4?=
 =?utf-8?B?Mis2SUIxTC93SldVMEpsSEtmakcvcjdWa241WmRvZXJZNlRVUnh0VUdZeitT?=
 =?utf-8?B?eTFpc1FRdVdQMEgycWFJeTVRV0M4eGpSdnBtVFdVOVRZNE5DcUZPY01rY1ZB?=
 =?utf-8?B?U0NUdVlNUnRNQXIza1U4UEFOdmhUWlBJRlNwZHhkSWZWRWZLN09BUlF2aXlO?=
 =?utf-8?B?K0VyRlh0UFhNK3E1MWY4aVorL1dpMVNBbFgxNitNY3djTklvS3ZaQ1VqblVw?=
 =?utf-8?B?U0hOS0o2dE9uYTY1TnlmajhHc1VVeThWVDg1bTJub290NEZQeTJVN1ZEUDJx?=
 =?utf-8?Q?oDN/fJeFR6/1B1lnCAGsk7c=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UzcwdWpUdHFybmdUYnVRYTMzZU1ZeDJCQkJGbmNJdVlwUENERmNzdWprMUxI?=
 =?utf-8?B?c3dzZnRzT0t1Tk5qNDgwbk9FcHp1NkF5VzJvQi9HdDE4RDFCMzRZQ1BLWUdO?=
 =?utf-8?B?RGFUbWozcmdIbnh0MnVHc2paaE9UVStDZytiQUZuV0hDYWVBL0dwTFlTMk1l?=
 =?utf-8?B?QWZEK3FQTGozOC9MV1FjTm1IVG84Vm9DVEVGU1F6SUlUSEtvaENra21IaUE0?=
 =?utf-8?B?K1o3YWExTjJZczc5Rk03UVNoQWc3RWdQV3lXd3huMEY3NEhrY3hxQ2Z6VHlS?=
 =?utf-8?B?NGZEMURkaGFFemswSThrenBaSURHaGxQSi9Lc0NUMi91VWJHZGVtQVJCd3VX?=
 =?utf-8?B?eSs1OUE1N1FrVnVMb240aUpZemI1dThncHYxQ3Y5TmVLWml6YjJWekc1eHN3?=
 =?utf-8?B?R0dwek1Ub2NGaGZKRERPK2kvaUZkSWEzQlZBUnk4TEJCcHY1emx1L1pTUXFh?=
 =?utf-8?B?U2FtT2pqNUxkYXcvUU9KTmdrcnNBVWllcm9WTFFiRDVBYURZbDVvcCtOdXRQ?=
 =?utf-8?B?S3VFcXVOclp1OXV2b1FDU0FCb0dRSnRQZTYxczZVdkpDQXBDK1BiNlowSnI2?=
 =?utf-8?B?bHFXeGI0c1dpOUY4STQzY1FiempYQW5ZUlh0d3pRNVhkeDNKVnIvSUFaUGNN?=
 =?utf-8?B?RkdIK2tqcUk5ZDY3NnUzKy9BU3NXN0pCbDNnZE5NanZiNDh1S1l3Yi9MOUtq?=
 =?utf-8?B?U1RONFBHR0d4MkRGdStrQldYb2h5OWJFc0EvWTJzdnY5UitsbjlmSmFKKzJ0?=
 =?utf-8?B?OEJlOTJzMWRWR290Q29UeDlISkVOaDZ3YkFrOXp1M0Y1dkgrWDUxUG1XbnFi?=
 =?utf-8?B?YmcxMjlOYm1QcUZOeWhJUEhVdVVHNkU3cDRlV3lMdlJQdGFKancxRENDa3Nn?=
 =?utf-8?B?WDBSMEN2eVNTKzVub0djeWdSSFV2N21XdUpkTis2TUhFZVh1R1NJdzhYODFD?=
 =?utf-8?B?bDlYVWE3TU9pWFE3cFIzaWpQVWpWWE1zQUxIcTl3VVJRM0hMWmV3Q2FJS0tN?=
 =?utf-8?B?R1VaMTRnSmpCdFAxNUYzbjRLRGV1OW83LytlbU4wc0M0RkVTMkNqZ09ROFo4?=
 =?utf-8?B?ZC82UjdIQkk1b0prRlJEK0FIVjZaUWpLN3dhblRDYWI5c21HU3lSblB3K01Q?=
 =?utf-8?B?U0hWWkhFTDB4MVpzQ2I2MlJmVjRVZnI2OTFGRkVyUDV3MmdvOWJzWW1IVjBo?=
 =?utf-8?B?azRHemdSUGpIRGRSSEpQVU5xZUxDOU1KTXR1eENraHV5Z0hyei9Wd3BLUDly?=
 =?utf-8?B?aEhucTJVRU9TN2dRenlDeldwaW5vZmhzUUhWNmwvTnBUam10RCsxek16T0tG?=
 =?utf-8?B?TElXZnR2bnNCUHQ1ayt6YnVoSEgyQWVwekZ2bjN3WWlqVnNFWjFQQlBCSnBs?=
 =?utf-8?B?aDB5RXZuRGdiQ3M0ckNNQVFtK3J4c3ljVHpMY0JRVzh5bVozeUZ1b3F0MHRi?=
 =?utf-8?B?Z1d3dE54SEdiNWI5eE9LR3l6ajE1TUprVDhuUU93WXJKbk1RYktMM0VDMGNN?=
 =?utf-8?B?S0hxV3hEbTF1QUpNZ280cGswMmwybDhTLzFZdFpuMnI1TitiRk1rVkhhOEdF?=
 =?utf-8?Q?ZzqCu52tpjHRZIRpJFDXVHNLI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d91e8227-234b-4ee9-3447-08daf2796cbf
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 19:40:56.7182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hwZicrE/MvOQYRaDEiczxOIIgBcbQGRLCxTN6rcts/a6axklxy57VX3mG1REjoNjrBBJHW7uU00Gfx49ed1Ucv++wpFBPFrpmZfptVnEiyk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4654
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-09_13,2023-01-09_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 malwarescore=0 bulkscore=0 phishscore=0 mlxlogscore=999 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301090139
X-Proofpoint-GUID: -jMecQXlOjIf2XybcQx6dBaTXvtVkgxu
X-Proofpoint-ORIG-GUID: -jMecQXlOjIf2XybcQx6dBaTXvtVkgxu
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/8/23 23:05, Sourabh Jain wrote:
> 
> On 09/12/22 21:06, Eric DeVolder wrote:
>> At the outcome of this patch set, the crash_prepare_elf64_headers()
>> is utilized on both the kexec_file_load() and kexec_load() paths. As
>> such, need to move this function out of kexec_file.c and into a
>> common location crash_core.c.
>>
>> No functionality change.
>>
>> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
>> Acked-by: Baoquan He <bhe@redhat.com>
>> ---
>>   kernel/crash_core.c | 100 ++++++++++++++++++++++++++++++++++++++++++++
>>   kernel/kexec_file.c |  99 -------------------------------------------
>>   2 files changed, 100 insertions(+), 99 deletions(-)
>>
>> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
>> index a0eb4d5cf557..46c160d14045 100644
>> --- a/kernel/crash_core.c
>> +++ b/kernel/crash_core.c
>> @@ -10,6 +10,7 @@
>>   #include <linux/utsname.h>
>>   #include <linux/vmalloc.h>
>>   #include <linux/sizes.h>
>> +#include <linux/kexec.h>
>>   #include <asm/page.h>
>>   #include <asm/sections.h>
>> @@ -314,6 +315,105 @@ static int __init parse_crashkernel_dummy(char *arg)
>>   }
>>   early_param("crashkernel", parse_crashkernel_dummy);
>> +int crash_prepare_elf64_headers(struct crash_mem *mem, int need_kernel_map,
>> +              void **addr, unsigned long *sz)
>> +{
>> +    Elf64_Ehdr *ehdr;
>> +    Elf64_Phdr *phdr;
>> +    unsigned long nr_cpus = num_possible_cpus(), nr_phdr, elf_sz;
>> +    unsigned char *buf;
>> +    unsigned int cpu, i;
>> +    unsigned long long notes_addr;
>> +    unsigned long mstart, mend;
>> +
>> +    /* extra phdr for vmcoreinfo ELF note */
>> +    nr_phdr = nr_cpus + 1;
>> +    nr_phdr += mem->nr_ranges;
>> +
>> +    /*
>> +     * kexec-tools creates an extra PT_LOAD phdr for kernel text mapping
>> +     * area (for example, ffffffff80000000 - ffffffffa0000000 on x86_64).
>> +     * I think this is required by tools like gdb. So same physical
>> +     * memory will be mapped in two ELF headers. One will contain kernel
>> +     * text virtual addresses and other will have __va(physical) addresses.
>> +     */
>> +
>> +    nr_phdr++;
>> +    elf_sz = sizeof(Elf64_Ehdr) + nr_phdr * sizeof(Elf64_Phdr);
>> +    elf_sz = ALIGN(elf_sz, ELF_CORE_HEADER_ALIGN);
> Seems like above function is out of CONFIG_KEXEC_FILE but some of the
> structure/attributes like crash_mem and ELF_CORE_HEADER_ALIGN are
> still defined under CONFIG_KEXEC_FILE (look for include/linux/kexec.h).
> 
> This leads to kernel build issue when CONFIG_KEXEC_FILE is disabled.
> 
> Thanks,
> Sourabh Jain
Thanks Sourabh, I'll look into this further.
eric