Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 Jan 2023 16:13:27 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Matthew Rosato <mjrosato@linux.ibm.com>
Cc:     alex.williamson@redhat.com, pbonzini@redhat.com, cohuck@redhat.com,
        farman@linux.ibm.com, pmorel@linux.ibm.com,
        borntraeger@linux.ibm.com, frankja@linux.ibm.com,
        imbrenda@linux.ibm.com, david@redhat.com, akrowiak@linux.ibm.com,
        jjherne@linux.ibm.com, pasic@linux.ibm.com,
        zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
        linux-s390@vger.kernel.org, kvm@vger.kernel.org,
        intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: async kvm_destroy_vm for vfio devices
Message-ID: <Y7x1Z64g4H0kWOo/@nvidia.com>
References: <20230109201037.33051-1-mjrosato@linux.ibm.com>
 <20230109201037.33051-2-mjrosato@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230109201037.33051-2-mjrosato@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cQGkv9WK05Q0FMNC625sVEr1puvhlB1fwM+TP1bOpXrE7SXgZsMkrurgs8XJ?=
 =?us-ascii?Q?YOL5mHRVAhD1dQg1EGC+lzZ3GUspDxIiNF3pAaESv9qqdjzJ0jRZPkAg0OF+?=
 =?us-ascii?Q?CQ4XbdBUrj4S/QG1jUt+BD7e7yuOjJsterB+tcVl8jfKW/n3gubjPbWXOBO3?=
 =?us-ascii?Q?MaxdLD4iqL8UYnXH3+pWTlNqXrHrWQKrdFG8v4IbxfMFKCAsG795uNqhauhS?=
 =?us-ascii?Q?Yp/tWsfmZLLfTpeOxjfPzIgPJFot5M9VBjOxpwLSM6P15L1EV/c10NGvyQNu?=
 =?us-ascii?Q?EHUwjTktEyrg0IhYEJPd4YtIIHOoYH1IDaZ6pVTkqHftKvmD0SjBaRrMbO1f?=
 =?us-ascii?Q?MQfffLRmOpMeINhM2PhatXuVtTkVE7Qv0lTbyzpzeKOKs4eNnjO4mVX4zl27?=
 =?us-ascii?Q?B3oSAHcRQ8T3/Ur6u5SplCA/tRKlhpP75MpzhXqn+M311IZZxYfUtrzTLuF1?=
 =?us-ascii?Q?02x2iCiQXYYg+2rJgdtQS1bX4g/rrRwiT9811dnsAvBRUMn9V/K1Pe+rOz7J?=
 =?us-ascii?Q?0GX1NRgDr55KV0gIO/7UWBNQmhZoIU6UBxcwO6XYCJq+Dci30OgHi9pGdwmP?=
 =?us-ascii?Q?Wf/x4HemWCHyuLdvFUg0Hk5LXbyoLUk3A56N/0n3Jg0cAEdlxXmulXPUpC7y?=
 =?us-ascii?Q?KtTeEMiM6n2EHvM4TuzCeU2GKwCk/tpu9P4+OE/4PdBSuNISUtJjgY89xe1K?=
 =?us-ascii?Q?9620UuvzGYNPpN213/xpsXvBjl6GsnVnfplGNXikRrdadmhBolcDjfSRUNIU?=
 =?us-ascii?Q?HlqUND5mMWHpu+mxrweSsnptTP+tsZH79qaNJvZaOMddCOgmwA+0oUANbhkM?=
 =?us-ascii?Q?o4a8pA/O6st+zk822o70GvMXqwzZRQ1U2Ddl1+cUCLDJHPuALJyTtWzju5wp?=
 =?us-ascii?Q?IHkgx6HlomuN0X8B3Y7U0MC9RkeOyeNP06WX2AFyHpx4JIq2goTRF6n5QQgE?=
 =?us-ascii?Q?Okn2a/J9E9MwM+BHaxvVKaiNdaV27ZHMAmEE2pWwFBUqLkxZ0reTbUxSfSlH?=
 =?us-ascii?Q?7Gr/H5LvldZuyeCtzupAF+SOQgBvclXU6hbKfMf0qEdAPQTBjrPh83rZPkfd?=
 =?us-ascii?Q?OSo664gHgmmqaQMn4OPFwmwYxh5YxJAljKETCsvub1i2xrRRpkLY0nQr3dij?=
 =?us-ascii?Q?OQ3ZZi4jjamjIFaQKO+eNKDcfa27hIhCaRFIktHLnpm2+ZGx3WGZUoCmC5ce?=
 =?us-ascii?Q?ngYBwJ+CNgp9EX3oUNEqo5g6rfSPeWqWRxa9A7emYrsgJHQ2Y8Jm0eGoFuuU?=
 =?us-ascii?Q?/dlpa9tz0eTDrOHy9oz6F9q3/uIUSPP1bSF2i/FoiUFgi0o5Ud8FvrjOJECW?=
 =?us-ascii?Q?TBXAlXcTzaDVH8F0NImRu2APeGsMNjhZ74UTvraHTnCdzGixe4RcCHn+3mx6?=
 =?us-ascii?Q?VuKgSRFBLAV3eIwnWhYlyKaPt4LHyJnN6oMmLxfhwsrfzY92lCWzOBEq8K6z?=
 =?us-ascii?Q?nWTzS8UIc39FACDIZmKfk3ocdv24Zawg2WQAQkozfYBTyQ1AofJ94rkHgyf8?=
 =?us-ascii?Q?ZK+PRAj0R+or0nXoGq5Ddr/YuiIJRuc6VRUPIiAgI9EKnyiYJu/Eeu+YpdLx?=
 =?us-ascii?Q?4+tZRic4jUKFev2dB0cR44FAhAYIsg9IRw7bmV9f?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e744c70-a4ac-458b-3e24-08daf27df905
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 20:13:29.1393
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2RnyAtYdkgBhSvKiZ3Oaq0i75GYQi0f4aaGGt/eIlKDxaJf1aJs0nN8kMKq159We
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5281
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 09, 2023 at 03:10:36PM -0500, Matthew Rosato wrote:
> Currently it is possible that the final put of a KVM reference comes from
> vfio during its device close operation.  This occurs while the vfio group
> lock is held; however, if the vfio device is still in the kvm device list,
> then the following call chain could result in a deadlock:
> 
> kvm_put_kvm
>  -> kvm_destroy_vm
>   -> kvm_destroy_devices
>    -> kvm_vfio_destroy
>     -> kvm_vfio_file_set_kvm
>      -> vfio_file_set_kvm
>       -> group->group_lock/group_rwsem
> 
> Avoid this scenario by adding kvm_put_kvm_async which will perform the
> kvm_destroy_vm asynchronously if the refcount reaches 0.
> 
> Fixes: 421cfe6596f6 ("vfio: remove VFIO_GROUP_NOTIFY_SET_KVM")
> Reported-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
>  drivers/gpu/drm/i915/gvt/kvmgt.c  |  6 +++++-
>  drivers/s390/crypto/vfio_ap_ops.c |  7 ++++++-
>  include/linux/kvm_host.h          |  3 +++
>  virt/kvm/kvm_main.c               | 22 ++++++++++++++++++++++
>  4 files changed, 36 insertions(+), 2 deletions(-)

Why two patches?

It looks OK to me

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason