Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b408632218fd0f06ec862a51822cf08e0f50a57.camel@collabora.com>
Subject: Re: [PATCH] drivers/media/v4l2-core/v4l2-h264 : add detection of
 null pointers
From:   Nicolas Dufresne <nicolas.dufresne@collabora.com>
To:     Dong Chuanjian <chuanjian@nfschina.com>, mchehab@kernel.org,
        hverkuil-cisco@xs4all.nl, sebastian.fricke@collabora.com,
        ezequiel@vanguardiasur.com.ar
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 09 Jan 2023 16:27:29 -0500
In-Reply-To: <20221227023625.7261-1-chuanjian@nfschina.com>
References: <20221227023625.7261-1-chuanjian@nfschina.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Le mardi 27 d=C3=A9cembre 2022 =C3=A0 10:36 +0800, Dong Chuanjian a =C3=A9c=
rit=C2=A0:
> When the pointer variable is judged to be null, null is returned
> directly.
>=20
> Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>

Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

Please add the missing Fixes tag.

Fixes: d3f756ad629b39 ("media: v4l2: Trace calculated p/b0/b1 initial refli=
st")

If someone have time, the pr_debug should be ported to v4l2_debug according=
 to
some other reviews.

> ---
> v2: Directly return when pointer allocation fails.
> v3: problems in synchronous repair format_ref_list_p
>=20
> diff --git a/drivers/media/v4l2-core/v4l2-h264.c b/drivers/media/v4l2-cor=
e/v4l2-h264.c
> index 72bd64f65198..f6684c1d7319 100644
> --- a/drivers/media/v4l2-core/v4l2-h264.c
> +++ b/drivers/media/v4l2-core/v4l2-h264.c
> @@ -305,6 +305,8 @@ static const char *format_ref_list_p(const struct v4l=
2_h264_reflist_builder *bui
>  	int n =3D 0, i;
> =20
>  	*out_str =3D kmalloc(tmp_str_size, GFP_KERNEL);
> +	if (*out_str =3D=3D NULL)
> +		return NULL;
> =20
>  	n +=3D snprintf(*out_str + n, tmp_str_size - n, "|");
> =20
> @@ -343,6 +345,8 @@ static const char *format_ref_list_b(const struct v4l=
2_h264_reflist_builder *bui
>  	int n =3D 0, i;
> =20
>  	*out_str =3D kmalloc(tmp_str_size, GFP_KERNEL);
> +	if (*out_str =3D=3D NULL)
> +		return NULL;
> =20
>  	n +=3D snprintf(*out_str + n, tmp_str_size - n, "|");
> =20